Thanks Wolf,
I usually have that exception on and nothing is being thrown. It did step over all of my code to send the features though. Let me be clear that we didn't change anything except for rebuilding. Name and location of dll is the same. Our apps are talking to each other via RPC. No exceptions being thrown. I can paste the code below for the heck of it, but I don't think we need to worry about this right now since we have a workaround. What we are doing is updating all Z's that aren't valid from our DTM. They are updating just not being sent back to us, since we changed some logic to "smartly refresh" graphics. LOL. We have a button in ArcGISPro that sends them all over with brute force and that works.
I think we will hold off this issue for now and soon start working on making changes to work with ArcGIS Pro 3.0. A little birdy told me that all Addins are going to break in that version. I really appreciate having 2 senior developers weighing in on this. Thanks Charles and Wolf!!
Anyways, here is the method that just steps to the end in the debugger. All formatting is gone and everything is left justified. LOL.
public void SendFeatureGraphics(
Coordinate2D ll, Coordinate2D ur, bool xform = false, int index = -1)
{
QueuedTask.Run(() => {
MapView mapview = MapView.Active;
if (mapview == null) {
SfaLogger.Log("Unable to send feature graphics - mapview is null.");
return;
}
SfaSettings.FeaturesRequested = false; // processing request
int command = SfaConstants.API_SFA_DRAW_GRAPHICS;
int select = 0;
int data_len = 0;
bool features_sent = false;
int total_features_sent = 0;
Envelope extent =
EnvelopeBuilder.CreateEnvelope(ll, ur, (xform) ? GeoCS : MapCS);
if (xform) {
extent = GeometryEngine.Instance.Project(extent, MapCS) as Envelope;
}
CIMMap map = mapview.Map.GetDefinition();
ClippingMode clipping_mode = map.ClippingMode;
string clip_uri_str = map.CustomClippingShapeURI;
string[] layers_excluded = map.LayersExcludedFromClipping;
Polygon clip_poly = null;
if (clipping_mode.Equals(ClippingMode.CustomShape)) {
try {
// find the clipping custom shape file in the temporary directory for now
string temp_directory = Path.GetTempPath();
string clip_folder_path = clip_uri_str.Substring(clip_uri_str.IndexOf("=") + 1);
string[] sub_directories = Directory.GetDirectories(temp_directory);
string full_file_path = "";
foreach (string sub_folder in sub_directories) {
if (File.Exists((sub_folder + "\\" + clip_folder_path))) {
full_file_path = sub_folder + "\\" + clip_folder_path;
}
}
if (full_file_path.Length != 0) {
byte[] buffer = File.ReadAllBytes(full_file_path);
EsriShapeImportFlags importFlags = EsriShapeImportFlags.esriShapeImportDefaults;
clip_poly = GeometryEngine.Instance.ImportFromEsriShape(importFlags, buffer, SpatialReferences.WGS84) as Polygon;
}
} catch (Exception ex) {
SfaLogger.Log(ex.Message);
}
}
else if (clipping_mode.Equals(ClippingMode.MapExtent)) {
// get the custom extent from the Map Extent
clip_poly = PolygonBuilder.CreatePolygon(mapview.Map.GetCustomFullExtent());
}
Polygon sgxp_polygon = PolygonBuilder.CreatePolygon(extent);
Polygon polygon_intersection = sgxp_polygon;
// only send feature that are within the intersect regions
if (clip_poly != null && sgxp_polygon != null) {
// check to see if the clipping extent in Pro intersects with
// the extent in SGXP
if (!GeometryEngine.Instance.Intersects(sgxp_polygon, clip_poly)) {
return;
}
// get the intersecting extent where the custom extent
// and SGXP intersect
polygon_intersection = GeometryEngine.Instance.Intersection(sgxp_polygon, clip_poly) as Polygon;
if (polygon_intersection == null) {
return;
}
}
IEnumerable<FeatureLayer> layers =
mapview.Map.GetLayersAsFlattenedList().OfType<FeatureLayer>();
foreach (FeatureLayer fl in layers) {
using (FeatureClass fc = fl.GetFeatureClass()) {
// Test for valid layer index
int layer_index = GetSfaLayerIndex(fc);
if (layer_index < 0) continue;
if (index >= 0 && layer_index != index) continue;
SfaLayer layer = SfaSettings.Layers[layer_index];
layer.IsVisible = fl.IsVisible;
layer.IsDrawn = fl.IsVisible;
if (!layer.IsDrawn) {
SfaLogger.Log(
"Skipping feature graphics for layer: " + layer.Name);
continue;
}
bool selectable = fl.IsSelectable;
bool editable = fl.IsEditable;
SpatialQueryFilter spatial_filter = new SpatialQueryFilter();
spatial_filter.FilterGeometry = polygon_intersection;
spatial_filter.SpatialRelationship =
SpatialRelationship.Intersects;
if (!clipping_mode.Equals(ClippingMode.None)) {
foreach (string lay in layers_excluded) {
// if layer is excluded, send all features for that layer
if (lay == fl.URI) {
spatial_filter.FilterGeometry = sgxp_polygon;
}
}
}
List<int> features_to_send = new List<int>();
List<int> features_already_present = new List<int>();
using (RowCursor rows = fl.Search(spatial_filter)) {
int i = 1;
do {
int reserve = 3 * sizeof(int);
SfaBuffer.BeginFeatureBlock(true, true, reserve);
try {
while (rows.MoveNext()) {
using (Feature feature = rows.Current as Feature) {
int feature_id = (int)feature.GetObjectID();
if (layer.FeaturesSent.Contains(feature_id)) {
features_already_present.Add(feature_id);
continue;
}
features_to_send.Add(feature_id);
if (!layer.HasSymbol) {
layer.LookupSymbol(feature);
}
SfaBuffer.PackFeature(
layer_index, feature, true, editable, selectable);
feature.Dispose();
}
if (SfaBuffer.DataLength >
(SfaBuffer.GetBuffer().Length - SfaConstants.BUFFER_CUSHION)) {
// We are close to filling the buffer, send what we have.
//rows.Current.Dispose();
break;
}
}
} catch (Exception e) {
SfaLogger.Log("Exception occured: " + e.Message);
}
if (SfaBuffer.NumFeatures > 0) {
features_sent = true;
total_features_sent += SfaBuffer.NumFeatures;
SfaBuffer.EndFeatureBlock();
int ftr_data_len = SfaBuffer.DataLength;
// We reserved space at the beginning of the buffer for these.
SfaBuffer.PrependBuffer(BitConverter.GetBytes(command), sizeof(int));
SfaBuffer.PrependBuffer(BitConverter.GetBytes(select), sizeof(int));
SfaBuffer.PrependBuffer(BitConverter.GetBytes(ftr_data_len), sizeof(int));
data_len = ftr_data_len + reserve;
if (SfaSettings.FeaturesRequested) {
// If a new reload request is made, need to stop this request
SfaLogger.Log("Starting new feature refresh query");
return;
}
SendMessage(SfaBuffer.GetBuffer(), data_len);
}
i++;
} while (rows.Current != null);
foreach (var ftr_id in features_to_send) {
SfaSettings.Layers[layer_index].FeaturesSent.Add(ftr_id);
}
}
}
}
if (!features_sent) {
// Inform SOCET GXP that refresh graphics is finished. Needed
// when nothing is sent in order to reset a flag in SOCET GXP.
SfaLogger.Log("There were no features to send for current extent.");
select = 99;
ResetBuffer();
AppendBuffer(BitConverter.GetBytes(command), sizeof(int));
AppendBuffer(BitConverter.GetBytes(select), sizeof(int));
AppendBuffer(BitConverter.GetBytes(data_len), sizeof(int));
SendMessage(_buf, _buf_pos);
} else {
Dictionary<MapMember, List<long>> selection = mapview.Map.GetSelection();
// Preserve any selections in the ArcMap canvas
if (selection.Count > 0) {
Thread.Sleep(500); //07-21-2022 BillSmith - this looks suspect, why are we sleeping?
SendSelection(mapview.Map.GetSelection());
}
}
});
}
