3.1 SearchWidget update

[KennyHoran]

I've been building a custom extension to the SearchWidget and needed to make a couple tweaks to support it.  I've removed some globals and the dependence on indexes (in order to allow filtering), making it a tad more flexible and streamlined.  If my logic's sound I hope it can be considered for 3.2.  I think I found a tiny bug too.  I've attached an updated 3.1 SearchWidget.mxml with the replaced lines commented out.

[BjornSvensson]

...SearchWidget ... I hope it can be considered for 3.2.  I think I found a tiny bug too.  I've attached an updated 3.1 SearchWidget.mxml with the replaced lines commented out.

Kenny, thanks for offering to contribute your work back to the flex viewer 🙂

I'm not sure if you are familiar with Git and GitHub, but the best way to suggest code improvements to the Flex Viewer source code is to create a pull request on GitHub:
1. Fork the Flex Viewer source code.
2. Make the changes to your own repo.
3. Make a pull request

See https://github.com/Esri/arcgis-viewer-flex/blob/develop/CONTRIBUTING.md for more information.

[KennyHoran]

Thanks, I appreciate it.  I haven't used GitHub much and have never contributed directly to a public repository, but mainly I'm developing on a private network and only have one license for Flash Builder.  Are there any alternatives I could use?  Or perhaps I could proxy changes through someone?

As I've been working I've found lots of nitpicky details to fix and it would be nice if they made it in.  I posted two examples here.

http://forums.arcgis.com/threads/79468-3.1-SearchWidget-graphic-fix
http://forums.arcgis.com/threads/79463-3.1-ResultAttributes-extra-newline

[GISDev1]

Thanks, I appreciate it.  I haven't used GitHub much and have never contributed directly to a public repository, but mainly I'm developing on a private network and only have one license for Flash Builder.  Are there any alternatives I could use?  Or perhaps I could proxy changes through someone?

As I've been working I've found lots of nitpicky details to fix and it would be nice if they made it in.  I posted two examples here.

http://forums.arcgis.com/threads/79468-3.1-SearchWidget-graphic-fix
http://forums.arcgis.com/threads/79463-3.1-ResultAttributes-extra-newline

No need to download the Client and do pulls like that if all you're doing is changing a few lines like you've mentioned.

Create a GitHub account and just do your edits inside the GitHub Text Editor on the exact files that you have edited in your own FlashBuilder and it will work just fine.

[KennyHoran]

Great.  I'm about to leave for a trip so I'll give that a shot when I get back.  Also I hear you can setup the Flex 4 SDK with Eclipse so perhaps I can get that working too.

[BjornSvensson]

Just wanted to follow up and let you know that we made some changes to the search widget based on the issues you highlighted.  This will be part of the 3.2  release (see GitHub Issue #21).

FYI - you can see the exact code change of our "commit" on GitHub:
https://github.com/Esri/arcgis-viewer-flex/commit/2999dfbfb6c4c25d1c82e23dae41cc061e61a983

Thank you 🙂

[KennyHoran]

Thanks a bunch, that works beautifully.  I see each ComboBox was changed to a DropDownList in 3.2, and with these changes I was easily able to update my search extension.

I think I'll install the trial of Flash Builder and try some simple contributions to get the hang of it.  Thanks for the help.