Bug with dojo/on is version 3.7

[ShawnHolyoak]

In upgrading my application to version 3.7 of the api, I've run into what I believe is a bug.  When I try to connect to the layers-add-result event for my map, I try to use the dojo/on amd method.  My code for that is:

on(map, "layers-add-result", function(e) {   var toc = new agsjs.dijit.TOC({    map: map,    layerInfos:legendLayers   }, 'legendDiv');   toc.startup();  });

That returns an error "TypeError: Cannot read property 'tagName' of undefined ".  When I try using the old dojo.connect method, though, everything works.  My code using the old dojo.connect is:

dojo.connect(map,'onLayersAddResult', function(results){   var toc = new agsjs.dijit.TOC({    map: map,    layerInfos:legendLayers   }, 'legendDiv');   toc.startup();  });

According to the documents, version 3.7 is using dojo version 1.9.1, which should certainly support the dojo/on functionality.  What, if anything, am I doing wrong.  If I'm not doing anything wrong, how do I file a bug report?

[MattLane]

Should it not be

map.on("layers-add-result", function(e) {
...

?

[ShawnHolyoak]

Not according to the dojo/on documentation, https://dojotoolkit.org/reference-guide/1.9/dojo/on.html

[JonathanUihlein]

Both are valid.

map.on("layers-add-result", function(e) {
//stuff
});

on(map, "layers-add-result", function(e) {
//stuff
});

In that document holyoaks linked, there is another document linked at the bottom that discusses both uses.
https://dojotoolkit.org/reference-guide/1.9/dojo/Evented.html#dojo-evented

Map is an object that fires its own events, as explained here:
https://developers.arcgis.com/en/javascript/jsapi/map-amd.html

Now, onto troubleshooting...
Does the event fire?
What happens when you wrap the problematic code in a try/catch?

[ShawnHolyoak]

Both are valid.

map.on("layers-add-result", function(e) {
//stuff
});

on(map, "layers-add-result", function(e) {
//stuff
});

Does the event fire?

What happens when you wrap the problematic code in a try/catch?

The error is caught, with the message originally mentioned, "Cannot read property 'tagName' of undefined".  map.on(), though, as suggested by mattlane86, also works properly.  So it seems it's the on(target, event, listener) style that is returning the error.

[JonathanUihlein]

Are you able to fire the event with a simple console.log in the function block, like in this jsfiddle?


http://jsfiddle.net/NcCWw/


*edit

Also, you should probably be creating the TOC object earlier on in your code (preferably before the parser runs). You can still start it up inside your event.

[JeffPace]

i have noticed similar issues with layers add

map.on works, on(map style does not

[ShawnHolyoak]

Are you able to fire the event with a simple console.log in the function block, like in this jsfiddle?


http://jsfiddle.net/NcCWw/


*edit

Also, you should probably be creating the TOC object earlier on in your code (preferably before the parser runs). You can still start it up inside your event.

No.  The event isn't fired.  The error seems to be in attaching the event handler to the map.

[ShawnHolyoak]

i have noticed similar issues with layers add

map.on works, on(map style does not

How do I file a bug report?

[JonathanUihlein]

No.  The event isn't fired.  The error seems to be in attaching the event to the map.

Hmmm... could you replicate the issue with http://jsfiddle.net/ so I can take a look at your code?