Python field calculator syntax

[MarcGuidry]

I keep getting a syntax error, but I'm not sure where the problem is.  Any suggestions?

The point of this is to concatenate a Last name field and First name field separated by a comma if there is both a last and first name.  If one of the fields is blank, it leaves out the comma (there are no nulls).

def name (!OWNER1_LAST_NAME!, !OWNER1_FIRST_NAME!) if len(!OWNER1_FIRST_NAME!)>0 and len(!OWNER1_LAST_NAME!)>0:   return !OWNER1_LAST_NAME! & ', ' & !OWNER1_FIRST_NAME! else:   return !OWNER1_FIRST_NAME!+!OWNER1_LAST_NAME!

name (!OWNER1_LAST_NAME!, !OWNER1_FIRST_NAME!)

Thanks,
Marc

[DarrenWiens2]

Python's concatenate character is +, not &.

[MarcGuidry]

I corrected that, but there is still a syntax error.  see anything else?

def name (!OWNER1_LAST_NAME!, !OWNER1_FIRST_NAME!)
if len(!OWNER1_FIRST_NAME!)>0 and len(!OWNER1_LAST_NAME!)>0:
  return !OWNER1_LAST_NAME! + ', ' + !OWNER1_FIRST_NAME!
else:
  return !OWNER1_FIRST_NAME!+!OWNER1_LAST_NAME!

name (!OWNER1_LAST_NAME!, !OWNER1_FIRST_NAME!)

[MathewCoyle]

Looks like missing colon at end of function definition

def name (!OWNER1_LAST_NAME!, !OWNER1_FIRST_NAME!): # add this
    if len(!OWNER1_FIRST_NAME!)>0 and len(!OWNER1_LAST_NAME!)>0:
        return !OWNER1_LAST_NAME! + ', ' + !OWNER1_FIRST_NAME!
    else:
        return !OWNER1_FIRST_NAME!+!OWNER1_LAST_NAME!

[MarcGuidry]

I've fixed that and there's still a syntax error.  Argh!

def name1 (!OWNER1_LAST_NAME!, !OWNER1_FIRST_NAME!):
  if len(!OWNER1_FIRST_NAME!)>0 and len(!OWNER1_LAST_NAME!)>0:
    return !OWNER1_LAST_NAME! + ', ' + !OWNER1_FIRST_NAME!
  else:
    return !OWNER1_FIRST_NAME!+!OWNER1_LAST_NAME!

name1 (!OWNER1_LAST_NAME!, !OWNER1_FIRST_NAME!)

Thanks!

[MathewCoyle]

Did you change the indentation as my code shows as well?

[MarcGuidry]

I did.

This is the error I'm getting when I run it in the field calc gp tool.

ERROR 000989
Python syntax error: Parsing error : invalid syntax (line 1)

[ATTACH=CONFIG]11590[/ATTACH]

[DarrenWiens2]

Oh, right. You pass in the arguments as fields:

name1(!OWNER1_LAST_NAME!, !OWNER1_FIRST_NAME!)

In the code block, you reference the arguments as variables:

def name1 (lastname, firstname):
  if len(firstname)>0 and len(lastname)>0:
    return lastname + ', ' + firstname
  else:
    return firstname + lastname

See the example for Using Code Blocks here.

[MathewCoyle · Accepted solution]

Oh sorry, you need to take those exclamation points out.

def name1 (OWNER1_LAST_NAME, OWNER1_FIRST_NAME):   if len(OWNER1_FIRST_NAME)>0 and len(OWNER1_LAST_NAME)>0:     return OWNER1_LAST_NAME + ', ' + OWNER1_FIRST_NAME   else:     return OWNER1_FIRST_NAME+OWNER1_LAST_NAME

name1(!OWNER1_LAST_NAME!, !OWNER1_FIRST_NAME!)

Sorry it took so long to spot that, I don't use the calculator much, prefer UpdateCursor

[MarcGuidry]

Thanks folks.  I finally ended up using the UpdateCursor.  Worked like a charm.