Your conditions need to be written with "==", not "=". The single equals sign would attempt to assign the value to a variable. And it looks like you're trying to check if the rounded average is equal to the value, but you have "avg = 9" inside the Round function.
if (Round(avg) == 9)
Second, your if/else if/else statements have no return in them, so that's probably also going to give you errors.
if (Round(avg) == 9){
return "Excellent to good";
}As for the code itself, this can be made a bit more concise. Since the variable avg is being rounded every time you use it, you may as well round it off at the start. It also looks like some of your conditions evaluate to the same output text, so you can combine those together.
Finally, you might check out the Where function. As with your if/else if/else statements, conditions in the Where function evaluate in order, so you can simply check if avg is greater than your threshold values.
Here's how I might re-write your expression.
var c = $feature["DECK_COND_058"]
var ss = $feature["SUPERSTRUCTURE_COND_059"]
var sb = $feature["SUBSTRUCTURE_COND_060"]
var avg = Round(Average([c, ss, sb]))
return When(
c == 5 && s == 5 && sb == 5, 'Fair, soon to be poor',
avg > 6, 'Excellent to good',
avg > 4, 'Satisfactory to fair',
avg > 1, 'Poor to critical',
avg == 1 || avg == 0, 'Failed to imminent failure',
'unknown'
)
- Josh Carlson
Kendall County GIS
