Having Issue on Adding/Removing Service Layer by Checkbox

[BruceGreen]

Can you please take a look at this code and let me know how I can add and remove some layers based on their index number in a Map Service? I tried this before but it is not working!

Layer 52 : <input type="checkbox" value=52 name="overlayLayers"><br  />
Layer 53 : <input type="checkbox" value=53 name="overlayLayers"><br  />

   var service ="http://renewablestoolbox.biol.sfu.ca/rorapp/rest/services//RORApp/MapServer";
   
    $('input:checkbox[name=overlayLayers]').on('change', function(){
    if($(this).is(':checked')){
        var index = $(this).val();
        map.addLayer(service+index);
    }
    else{
        var index = $(this).val();
        map.removeLayer(service+index);
        }
});

[RobertScheitlin__GISP · Accepted solution]

Behrouz,

   The main issue in your code is you are trying to add a string to the map and not an actual layer.  Try something like map.addLayer(new FeatureLayer(service+index));  and map.removeLayer is expecting an actual layer as well.

Look at the docs for map.getLayer:

Map | API Reference | ArcGIS API for JavaScript | getLayer​

This would mean that you need to assign an Id to the layer when it is added.

[BruceGreen]

Thanks Robert but I tried to do what you recommend but I am not sure why I am getting this error

I already register the  "esri.layers.FeatureLayer", and  function(Map, FeatureLayer,

but still getting this!

[RobertScheitlin__GISP]

Behrouz,

You say that you have registered "esri.layers.FeatureLayer". This leads me to believe that you are developing using the old legacy style and not AMD Legacy code. Legacy will not be supported any more when JS API 4.0 comes out and you should quit using Legacy style. It would help to see more of your code.

Just looking at the snippets you provided you also have an issue with the service url.

You have:

var service ="http://renewablestoolbox.biol.sfu.ca/rorapp/rest/services//RORApp/MapServer"; 

It should be:

var service ="http://renewablestoolbox.biol.sfu.ca/rorapp/rest/services/RORApp/MapServer/"; 

Notice double slash removed and a slash added to the end of the url since you are just adding the layer id to this string.