Hello,
Just tested @arcgis/create: thanks JS team, great initiative !
I was surprised though to find out that `package-lock.json` is in .gitignore by default.
According to npm, this file is meant to be commited:
https://docs.npmjs.com/cli/v11/configuring-npm/package-lock-json
```
This file is intended to be committed into source repositories, and serves various purposes
```
Obviously, you did it on purpose for a reason and I would curious to know why.
Thanks
Solved! Go to Solution.
Nice catch!
We developed the application templates part of the `@arcgis/create` CLI to be package manager-agnostic, which is why lock files are not included by us. Another reason is that Dependabot is enabled by default in https://github.com/Esri/jsapi-resources, and adding `package-lock.json` to `.gitignore` reduces noise. We still monitor things elsewhere outside the repository.
However, we can see how this would be an inconvenience.
We'll update the `.gitignore` files now and report back once complete.
Thanks,
- Omar Kawach
UPDATE: https://github.com/Esri/jsapi-resources/commit/47dbd4d551581ad3bf5d122d04c02fa8f1f3437d
Nice catch!
We developed the application templates part of the `@arcgis/create` CLI to be package manager-agnostic, which is why lock files are not included by us. Another reason is that Dependabot is enabled by default in https://github.com/Esri/jsapi-resources, and adding `package-lock.json` to `.gitignore` reduces noise. We still monitor things elsewhere outside the repository.
However, we can see how this would be an inconvenience.
We'll update the `.gitignore` files now and report back once complete.
Thanks,
- Omar Kawach
UPDATE: https://github.com/Esri/jsapi-resources/commit/47dbd4d551581ad3bf5d122d04c02fa8f1f3437d
Thanks for your quick reply and fix @OmarKawach !