Latest Contributions by CarlosPiccirillo

Thanks Ken, the windows cursor seems to be more stable than the IMouseCursor one. I will give the StatusStrip with a progress bar/message a try. I have never tried that before, do you have some code I could look at? Thanks! Carlos ... View more

Rich, Thanks for your reply. Yes, I have tried using the IProcessDialog and it works fine but I was trying to avoid opening yet another pop-up form. My boss REALLY likes how the progressbar set to marquee looks and wants the fewest pop-ups/forms as possible so I was trying to get it to work that way first and only go with the IProcessDialog as a last resort. I have never tried setting the Windows cursor to a wait one. Can you show me how to do that? Thanks for your help and time, I really appreciate it! Carlos I have found the IMouseCursor to behave strangely so tend to avoid it. I think each time your code calls external methods then you need to call .SetCursor() again. Have you looked into using IProgressDialog? You can use it with a step progressor bar if you know how many iterations the process will take. If you don't know then hide the step progressor as shown below:             //CREATE OBJECT TO ALLOW USER TO CANCEL             ITrackCancel trackCancel = new CancelTrackerClass();             trackCancel.CancelOnClick = true;             trackCancel.CancelOnKeyPress = true;             //CREATE A PROGRESS DIALOG             IProgressDialogFactory progDialogFact = new ProgressDialogFactoryClass();             IStepProgressor stepProg = progDialogFact.Create(trackCancel, Handle.ToInt32());             IProgressDialog2 progDialog = (IProgressDialog2)stepProg;             progDialog.CancelEnabled = true;             progDialog.Description = "Querying database...";             progDialog.Title = "Progress Dialog Title Here";             progDialog.Animation = esriProgressAnimationTypes.esriProgressGlobe;             stepProg.Message = "Click below to Cancel...";             stepProg.Hide(); Don't forget to close the dialog in your Finally block: progDialog.HideDialog(); This progess dialog will not be embeded in your form but pop up in front. However, I have found it to be the most reliable way to show the user that lengthy background processes are occuring.  For shorter processes where a WinForm remains open you may just want to set the Windows cursor to a wait one. ... View more

Alexander, Thank you so much for the reply, I really appreciate it! I think I understand the majority of what you are saying. I'm very much a visual learner. Do you happen to have some code examples (or even pseudo code) showing the logic you are talking about? I've never done custom exceptions before. Thanks again for your help and time! Carlos A clean way of doing it is taking all the return values and making them input variables by ref to the function and retuning a boolean that is success or fail.  In some coding styles that is pretty standard.  Another way of doing is raising your own exception in the catch block.  You can use an application exception or create your own custom .net exception, you can put your own message, or pass in the first exception into the new exception.  You can even re-throw the same exception you caught.   Creating a custom exception allows you to catch it separately (if you define a catch block with a specific type of exception, you will only catch that type of exception.)  You can have more than one catch block for different exception types. Personally, I try to only put try catch blocks at the highest possible level in the code, at the event handler level.  For example in an OnClick event of an Icommand.  Any exception that happens in a call to a procedure will automatically bubble up to the highest level to be caught.  So you handler in procedure 1 will catch exceptions raised in procedure 2.  Exception handling can be performance intensive and putting it in private functions or worse in non user interface classes is usually not an good idea (exception made when an edit operation needs to be terminated correctly on exception.)  The reason for that is imagine if someone re-uses your code and calls it in a loop and it generates and catches/logs/deals with hundreds of exceptions.  This also allows you to deal with exceptions differently with the same code base for example,  on a form (errorProvider), an ArcGIS command or tool (message box), an edit session (abort operation), an exe (write to console), a service (write to event log or database.) Also, if you know an exception condition is likely to occur, it is not an exception any more, you are better off checking for the condition than using the exception handling. ... View more

Samham, Thanks for the reply! pAppLayer is in a file geodatabase and pEnsLayer is in SDE. Not sure I follow you when you say, "From my experience arcobjects should never be instantiated in every iteration of while loop if possible." Do you have an example of what you mean? I will be out until Monday so my appologies ahead of time if I am late replying to any replies you post. Thanks again! Carlos How many records are stored in  pAppLayerand pEnsLayer? Is it sde? ... View more

Thanks Duncan, I appreciate it. 🙂 ... View more

Hi Ken, Thanks for the reply. You are right on, I did not have pGeoprocessor.OverwriteOutput = "true" set. I added that line to the code below and now it gets further along but after a couple hundred records or so, it starts failing every time the method below gets called (inside loop of another method) and the error is "Object reference not set to an instance of an object." I know what's happening, but no clue as to why. The problem occurs because line: ISelectionSet pSelectionSet = pFeatureSelection.SelectionSet as ISelectionSet; suddenly stops returning a selection set. This line should always return something because the method only gets called when a spatial query determines that two polygons from different layers intersect each other so I don't understand why suddenly it stops working. Sounds like a memory leak or object not being cleared correctly but I've tried adding lines like, if (pWorkspaceFactory != null) { Marshal.ReleaseComObject(pWorkspaceFactory); pWorkspaceFactory = null; } for every object to clear it but it doesn't help. I can post the method calling this method if you want. Just have to do it in another message because it's too large to fit in this one. Thanks again for your help and time, I appreciate it!!!         public static bool DetermineOverlapArea3(IFeatureLayer pAppLayer, IFeatureLayer pEnsLayer,                                                  IFeature pAppFeature, IFeature pEnsFeature)         {             try             {                 IQueryFilter queryFilter = new QueryFilterClass();                 IDataset pDataset1 = null;                 IDataset pDataset2 = null;                 IFeatureSelection pFeatureSelection1 = null;                 IFeatureSelection pFeatureSelection2 = null;                 IFeatureClassName pInFeatureClassName1 = new FeatureClassNameClass();                 IFeatureClassName pInFeatureClassName2 = new FeatureClassNameClass();                 IDatasetName pInDatasetName1 = null;                 IDatasetName pInDatasetName2 = null;                 IFeatureClassName pOutFeatureClassName1 = new FeatureClassNameClass();                 IFeatureClassName pOutFeatureClassName2 = new FeatureClassNameClass();                 IDatasetName pOutDatasetName1 = null;                 IDatasetName pOutDatasetName2 = null;                 IWorkspaceFactory pWorkspaceFactory = new InMemoryWorkspaceFactoryClass();                 IFeatureLayer pFeatureLayer = new FeatureLayerClass();                 IFeatureWorkspace pFeatureWorkspace = null;                 IWorkspaceName pWorkspaceName = new WorkspaceNameClass();                 pWorkspaceName = pWorkspaceFactory.Create("", "TEMP", null, 0);                 IName pName = pWorkspaceName as IName;                 IWorkspace pWorkspace = pName.Open() as IWorkspace;                 pFeatureWorkspace = pWorkspace as IFeatureWorkspace;                 if (pAppLayer != null)                 {                     pFeatureSelection1 = pAppLayer as IFeatureSelection;                     queryFilter.WhereClause = "APP_NO = '" + m_AppNo + "'";                     pDataset1 = pAppLayer.FeatureClass as IDataset;                     pFeatureSelection1.SelectFeatures(queryFilter, esriSelectionResultEnum.esriSelectionResultNew, false);                     pInFeatureClassName1 = pDataset1.FullName as IFeatureClassName;                     pInDatasetName1 = pInFeatureClassName1 as IDatasetName;                     pOutDatasetName1 = pOutFeatureClassName1 as IDatasetName;                     pOutDatasetName1.Name = "APPTEMP";                     pOutDatasetName1.WorkspaceName = pWorkspaceName;                     pOutFeatureClassName1.FeatureType = esriFeatureType.esriFTSimple;                     pOutFeatureClassName1.ShapeType = esriGeometryType.esriGeometryAny;                     pOutFeatureClassName1.ShapeFieldName = "Shape";                     IExportOperation pExportOperation = new ExportOperationClass();                     pExportOperation.ExportFeatureClass(pInDatasetName1, null, pFeatureSelection1.SelectionSet, null, pOutFeatureClassName1, 0);                 }                 if (pEnsLayer != null)                 {                     pFeatureSelection2 = pEnsLayer as IFeatureSelection;                     queryFilter.WhereClause = "BASIN_NAME = '" + m_Label + "'";                     pDataset2 = pEnsLayer.FeatureClass as IDataset;                     pFeatureSelection2.SelectFeatures(queryFilter, esriSelectionResultEnum.esriSelectionResultNew, false);                     pInFeatureClassName2 = pDataset2.FullName as IFeatureClassName;                     pInDatasetName2 = pInFeatureClassName2 as IDatasetName;                     pOutDatasetName2 = pOutFeatureClassName2 as IDatasetName;                     pOutDatasetName2.Name = "ENSTEMP";                     pOutDatasetName2.WorkspaceName = pWorkspaceName;                     pOutFeatureClassName2.FeatureType = esriFeatureType.esriFTSimple;                     pOutFeatureClassName2.ShapeType = esriGeometryType.esriGeometryAny;                     pOutFeatureClassName2.ShapeFieldName = "Shape";                     IExportOperation pExportOperation = new ExportOperationClass();                     pExportOperation.ExportFeatureClass(pInDatasetName2, null, pFeatureSelection2.SelectionSet, null, pOutFeatureClassName2, 0);                 }                 IFeatureClass pAppFeatureClass = pFeatureWorkspace.OpenFeatureClass("APPTEMP");                 IFeatureClass pEnsFeatureClass = pFeatureWorkspace.OpenFeatureClass("ENSTEMP");                 //Execute clip.                 Clip pClip = new Clip();                 pClip.in_features = pAppFeatureClass;                 pClip.clip_features = pEnsFeatureClass;                 pClip.out_feature_class = "in_memory\\APP_ENS_OVERLAP";                 Geoprocessor pGeoprocessor = new Geoprocessor();                 pGeoprocessor.AddOutputsToMap = false;                 pGeoprocessor.OverwriteOutput = true;                 IGeoProcessorResult result = pGeoprocessor.Execute(pClip, null) as IGeoProcessorResult;                 //Get the resulting intersection polygon.                 IFeatureClass pOverlapEnsFeatureClass = pGeoprocessor.Open("in_memory\\APP_ENS_OVERLAP") as IFeatureClass;                 pFeatureLayer.FeatureClass = pOverlapEnsFeatureClass;                 IFeatureSelection pFeatureSelection = pFeatureLayer as IFeatureSelection;                 pFeatureSelection.SelectFeatures(null, esriSelectionResultEnum.esriSelectionResultNew, false);                 ISelectionSet pSelectionSet = pFeatureSelection.SelectionSet as ISelectionSet;   //PROBLEM HERE                 ICursor pCursor;                 pSelectionSet.Search(null, true, out pCursor);                 IFeatureCursor pFeatureCursor = pCursor as IFeatureCursor;                 IFeature pIntersectFeature = pFeatureCursor.NextFeature();                 IArea pIntersectArea = pIntersectFeature.Shape as IArea;                 IArea pAppArea = pAppFeature.Shape as IArea;                 IArea pEnsArea = pEnsFeature.Shape as IArea;                 int appOverlap = Convert.ToInt32((pIntersectArea.Area / pAppArea.Area) * 100);                 int ensOverlap = Convert.ToInt32((pIntersectArea.Area / pEnsArea.Area) * 100);                 if (appOverlap > 5 || ensOverlap > 5)                     return true;                 else                     return false;             }             catch (Exception ex)             {                 MessageBox.Show(ex.Message);                 //LogError(ex.StackTrace, ex.Message, "DetermineOverlapArea", null);                 return false;             }         } Hi Carlos, I'm glad to hear you're making progress. Since you don't have the code to show why the Clip process didn't run, examine the Results information in ArcMap to find out what happened. Could it be that it's not overwriting "in_memory\APP_ENS_OVERLAP"? Have you set the Geoprocessor to overwrite outputs, either through the Geoprocessing Options dialog or by setting pGeoprocessor.OverwriteOutput = "true" ... View more

Ken, Thanks for sample code. Looking at your code, I got mine to work. Unfortunately, I am still having one issue. The methos below gets called from a loop. The first time the method gets called everything works fine. The second time however, the line below retuns null. GeoProcessorResult result = pGeoprocessor.Execute(pClip, null) as GeoProcessorResult; Any idea why this is happening? Thanks, Carlos         public static bool DetermineOverlapArea3(IFeatureLayer pAppLayer, IFeatureLayer pEnsLayer,                                                  IFeature pAppFeature, IFeature pEnsFeature)         {             try             {                 IQueryFilter queryFilter = new QueryFilterClass();                 IDataset pDataset1 = null;                 IDataset pDataset2 = null;                 IFeatureSelection pFeatureSelection1 = null;                 IFeatureSelection pFeatureSelection2 = null;                 IFeatureClassName pInFeatureClassName1 = new FeatureClassNameClass();                 IFeatureClassName pInFeatureClassName2 = new FeatureClassNameClass();                 IDatasetName pInDatasetName1 = null;                 IDatasetName pInDatasetName2 = null;                 IFeatureClassName pOutFeatureClassName1 = new FeatureClassNameClass();                 IFeatureClassName pOutFeatureClassName2 = new FeatureClassNameClass();                 IDatasetName pOutDatasetName1 = null;                 IDatasetName pOutDatasetName2 = null;                 IWorkspaceFactory pWorkspaceFactory = new InMemoryWorkspaceFactoryClass();                 IFeatureLayer pFeatureLayer = new FeatureLayerClass();                 IFeatureWorkspace pFeatureWorkspace = null;                 IWorkspaceName pWorkspaceName = new WorkspaceNameClass();                 pWorkspaceName = pWorkspaceFactory.Create("", "TEMP", null, 0);                 IName pName = pWorkspaceName as IName;                 IWorkspace pWorkspace = pName.Open() as IWorkspace;                 pFeatureWorkspace = pWorkspace as IFeatureWorkspace;                 if (pAppLayer != null)                 {                     pFeatureSelection1 = pAppLayer as IFeatureSelection;                     queryFilter.WhereClause = "APP_NO = '" + m_AppNo + "'";                     pDataset1 = pAppLayer.FeatureClass as IDataset;                     pFeatureSelection1.SelectFeatures(queryFilter, esriSelectionResultEnum.esriSelectionResultNew, false);                     pInFeatureClassName1 = pDataset1.FullName as IFeatureClassName;                     pInDatasetName1 = pInFeatureClassName1 as IDatasetName;                     pOutDatasetName1 = pOutFeatureClassName1 as IDatasetName;                     pOutDatasetName1.Name = "APPTEMP";                     pOutDatasetName1.WorkspaceName = pWorkspaceName;                     pOutFeatureClassName1.FeatureType = esriFeatureType.esriFTSimple;                     pOutFeatureClassName1.ShapeType = esriGeometryType.esriGeometryAny;                     pOutFeatureClassName1.ShapeFieldName = "Shape";                     IExportOperation pExportOperation = new ExportOperationClass();                     pExportOperation.ExportFeatureClass(pInDatasetName1, null, pFeatureSelection1.SelectionSet, null, pOutFeatureClassName1, 0);                 }                 if (pEnsLayer != null)                 {                     pFeatureSelection2 = pEnsLayer as IFeatureSelection;                     queryFilter.WhereClause = "BASIN_NAME = '" + m_Label + "'";                     pDataset2 = pEnsLayer.FeatureClass as IDataset;                     pFeatureSelection2.SelectFeatures(queryFilter, esriSelectionResultEnum.esriSelectionResultNew, false);                     pInFeatureClassName2 = pDataset2.FullName as IFeatureClassName;                     pInDatasetName2 = pInFeatureClassName2 as IDatasetName;                     pOutDatasetName2 = pOutFeatureClassName2 as IDatasetName;                     pOutDatasetName2.Name = "ENSTEMP";                     pOutDatasetName2.WorkspaceName = pWorkspaceName;                     pOutFeatureClassName2.FeatureType = esriFeatureType.esriFTSimple;                     pOutFeatureClassName2.ShapeType = esriGeometryType.esriGeometryAny;                     pOutFeatureClassName2.ShapeFieldName = "Shape";                     IExportOperation pExportOperation = new ExportOperationClass();                     pExportOperation.ExportFeatureClass(pInDatasetName2, null, pFeatureSelection2.SelectionSet, null, pOutFeatureClassName2, 0);                 }                 IFeatureClass pAppFeatureClass = pFeatureWorkspace.OpenFeatureClass("APPTEMP");                 IFeatureClass pEnsFeatureClass = pFeatureWorkspace.OpenFeatureClass("ENSTEMP");                 //Execute clip.                 Clip pClip = new Clip();                 pClip.in_features = pAppFeatureClass;                 pClip.clip_features = pEnsFeatureClass;                 pClip.out_feature_class = "in_memory\\APP_ENS_OVERLAP";                 Geoprocessor pGeoprocessor = new Geoprocessor();                 GeoProcessorResult result = pGeoprocessor.Execute(pClip, null) as GeoProcessorResult;                 IGPValue pGPValue = result.GetOutput(0);                 string InMemoryFeatureClass = string.Empty;                 InMemoryFeatureClass = pGPValue.GetAsText();                 //Get resulting feature class.                 IGPUtilities pGPUtilities = new GPUtilities();                 IFeatureClass pOverlapEnsFeatureClass = pGPUtilities.OpenFeatureClassFromString(InMemoryFeatureClass);                 //Get the resulting intersection polygon.                 pFeatureLayer.FeatureClass = pOverlapEnsFeatureClass;                 IFeatureSelection pFeatureSelection = pFeatureLayer as IFeatureSelection;                 pFeatureSelection.SelectFeatures(null, esriSelectionResultEnum.esriSelectionResultNew, false);                 ISelectionSet pSelectionSet = pFeatureSelection.SelectionSet as ISelectionSet;                 ICursor pCursor;                 pSelectionSet.Search(null, true, out pCursor);                 IFeatureCursor pFeatureCursor = pCursor as IFeatureCursor;                 IFeature pIntersectFeature = pFeatureCursor.NextFeature();                 IArea pIntersectArea = pIntersectFeature.Shape as IArea;                 IArea pAppArea = pAppFeature.Shape as IArea;                 IArea pEnsArea = pEnsFeature.Shape as IArea;                 int appOverlap = Convert.ToInt32((pIntersectArea.Area / pAppArea.Area) * 100);                 int ensOverlap = Convert.ToInt32((pIntersectArea.Area / pEnsArea.Area) * 100);                 if (appOverlap > 5 || ensOverlap > 5)                     return true;                 else                     return false;             }             catch (Exception ex)             {                 LogError(ex.StackTrace, ex.Message, "DetermineOverlapArea", null);                 return false;             }         } ... View more

Ken, Thanks for the reply. I saw something about that in the documentation but could not get it to work either. Do you have some sample code in any language I can look at that uses "in_memory"? Thanks for your time. Carlos I haven't tried using the IMemoryWorkSpaceFactory, but I have been able to use a geoprocessor process parameter like "in_memory\output" ... View more

Neil, Alexander, Sorry for the late reply. I was out Thursday afternoon and all day Friday. Neil, you are correct, the bottleneck is the Intersect command in the DeterimeOverlapArea method. I'm trying to figure out what I can use in it's place that might be faster. Alexander, the Convert.ToInt32 is very fast so that part of the code is okay although I will try your suggestion. Every little bit of speed increase helps. Carlos ... View more

Aparently, I messed up doing the first test because when I repeated them later trying some of Neil's suggestion, the code took less than a minute. The bottleneck is definitely between GetAppInfo and DetermineOverlapArea. The biggest bottleneck seems to be DetermineOverlapArea. I've been trying alternative code all day and get the same slow results. ... View more

Neil, I tried your suggestions for speeding up method DetermineOverlapArea and it's just as slow as before. I tried passing in the geometries both as polygons as well as geometries and there is no improvement at all. It takes 10 minutes to get through 5 records. A few things to try: First, a method should only take what it really needs as parameters.  In this case, you don't really need 2 features, you need 2 polygons.  So I would modify the method signature to this: public static bool DetermineOverlapArea(IPolygon polygon1, IPolygon polygon2) When you call the method, pass in the feature geometries cast as polygons.  Use ShapeCopy instead of Shape because you don't want your method altering the feature geometries. Try skipping the geomtry simplification.  The general idea here is that an unmodified feature geometry from a feature class will already be simple. Remove the if/else block at the end and replace it with:  return (appOverlap > 5 || ensOverlap > 5); Probably not much time savings there but every bit counts. ... View more