Latest Contributions by Luke_Pinner

Hmmm, that's what the "try:  except TypeError:" handler is supposed to silence, and it does for me on 10.2.2. I remember from GISSE that you're on 10.3.  The bug # I referenced in the code suggests adding `print " "` to the except clause. ... View more

Peter, your variables look fine to me.  The only suggestion I might make is to pass your inputs in to the script using arguments and access them with sys.argv or arcpy.GetParameterAsText. And I'd only recommend that if you're going to be using the code as a commandline or ArcToolbox script tool and you may want to use different inputs/workspaces when running the code. I write code that ranges from simple step-by-step scripts to large libraries that are spread across multiple files in python packages.  Here's how I roughly think about when deciding whether to modularise/refactor code: For straightforward scripts, I will hardcode variables such as you have done. If I want to reuse the script with different inputs, I will pass the inputs as parameters/arguments and access them with sys.argv or arcpy.GetParameterAsText If it's a long and complex script, I might turn some of the steps into functions to enhance readability or if I want to reuse a bit of code within the script if parts of the code could be reused in other scripts, I will turn that bit of code into a function or class and put it in a module that can be imported. I'll group similar bits of code in individual modules, i.e a module for statistics related code, one for certain types of filesystem IO, one for geometry operations, one for interacting with ArcObjects, etc... ... View more

For me, the main reasons to refactor code into functions (and classes, modules, packages...) are readability and reusability. On readability - if I have a long script with a number of steps, each with a number of lines of code, I will usually bust each step out into a function so it's easier to follow the overall logic of the script. On reusability - if I find myself writing the same code over and over again to do the same thing with different inputs, I will turn that code into a function. I don't see anything in your code that requires moving into a function.  It's a very straightforward script, is very readable and there's nothing in it that is reusable. A cautionary note... it's easy to get too caught up in refactoring and go too far. I was recently reviewing another programmers code where everything was a function, and functions called functions which called more functions ad-infinitum and understanding what the script was doing meant jumping all over the place in the file. It was basically unreadable. ... View more

The OP's question is referring to running a tool from ArcToolbox and my answer to your question about running a tool from a Python Addin using the pythonaddins.GPToolDialog won't work here. ... View more

You could use a dict instead of a list     print("Verifying that coordinate systems are the same...")      InSHP = {'outline':outline, 'DA':DA, 'soil':soil}      DEMSR = arcpy.Describe(DEM).spatialReference.PCSCode      for l in InSHP:          print l, InSHP         sr = arcpy.Describe(InSHP ).spatialReference.PCScode          if sr != DEMSR:              InSHP = arcpy.Project_management(InSHP , InSHP [:-4] + "PRJ.shp", DEMSR)              print InSHP     print InSHP['outline'] ... View more

Still seems to be broken at 10.2.2, sigh. Mosaic dataset of single band rasters, source type = thematic. ... View more

It would help if you could describe exactly *what* is not working and provide any python exceptions you are getting (hint: if you have the ArcMap python window open, any exceptions raised by your addin will be visible). ... View more

Assuming it's row[3] that contains the NUL, try: row[3]=v.replace('\x00','') ... View more

Bit hard without the actual error message. Can you add that to your question? ... View more

Sephe, arcpy.da cursors are preferred to the legacy arcpy cursors. Accessing data using cursors ArcGIS 10.1 added a new data access module (arcpy.da). The previously existing cursors (that are still listed under arcpy) are still functional and valid; however, the new arcpy.da cursors include significantly faster performance. In most cases, the help will illustrate the use of the arcpy.da cursors. ... View more

try:version = user.ClientName.split(':')[1] except IndexError:version = '' ... View more

When running your add in,  have the ArcMap python window open (Geoprocessing -  Python menu) so you can see any error messages. ... View more