The variable OID is not assigned a value as far as I can see. So line 40 is selecting nothing. But SelectLayerByAttribute is unnecessary.
If you are writing to SDE data that is versioned then you do need to do the Editor operation. However, you should use the with syntax to get errors reported and automated closure of the session
Also, you over complicating this and you are creating unnecessary selections. Selections inside selections is just another embedded loop and is BAD. Don't do that. Just use a dictionary and load every selected parcel into it all at once. It will do the Account look up 100 times faster than SelectLayerByAttribute. So use the code below.
I based this on your code. Your code assumes that Account in the address points already matches Account in the Parcels and that no two parcels have the same Account. If the Account of the Address that touches a parcel is not the same as the Account on the parcel then the update cursor won't work. If the real match is only spatial then this code approach won't work. Also if two addresses have the same Account and fall on two parcels with the same accounts, the result will just use the last parcel with that account that is read and not necessarily the parcel touched by the address.
For a pure spatial match I would do a Spatial Join with the One To Many option to an in_memory fc, not SelectLayerByLocation. The Spatial Join is much faster and more reliable for spatial matching than any attribute that may or may not be spatially related. The Spatial Join result would have the necessary ObjectID values to use the cursor for the transfer.
import arcpy
from datetime import datetime as d
startTime = d.now()
#set to folder where features are located
arcpy.env.workspace = r"Database Servers\DSD15_SQLEXPRESS.gds\TEST (VERSION:dbo.DEFAULT)" #r"Database Servers\DSD15_SQLEXPRESS.gds\TonyTwoWay (VERSION:dbo.DEFAULT)" #on windows use \ instead of /
arcpy.env.overwriteOutput = True
arcpy.env.qualifiedFieldNames = False
#define variables for cursor
FC = "TEST.DBO.CCAPTEST" #pointlayer
TaxPar = "TaxParcels" #Parcels
poly = "ACCOUNT"#'SiteAddres_1','SiteAddres_1', 'SiteNum_1', 'SiteNumSfx_1','Predir_1','SiteStreet_1', 'StreetType_1', 'Postdir_1', 'SiteCity_1', 'SiteZIP_1', 'OwnerName_1'
Pnt = "Account"#
parcelsCount = int(arcpy.GetCount_management(FC).getOutput(0))
dsc = arcpy.Describe(FC)
selection_set = dsc.FIDSet
if len(selection_set) == 0:
print "There are no features selected"
elif parcelsCount >= 1:
#Select parcel within selected Address Points
arcpy.SelectLayerByLocation_management(TaxPar, "CONTAINS", FC)
# define the field list from the parcels
sourceFieldsList = ["ACCOUNT", poly,"SiteAddres",'SiteNum', 'SiteStreet','SiteNumSfx','Predir','SiteStreet', 'StreetType', 'Postdir', 'SiteCity', 'SiteZIP', 'OwnerName']
# populate the dictionary will all selected polygons
valueDict = {r[0]:(r[1:]) for r in arcpy.da.SearchCursor(TaxPar, sourceFieldsList)}
# define the field list to the points
updateFieldsList = ["Account", Pnt,"SiteAddres", 'SiteNum', 'SiteStreet', 'SiteNumSfx','Predir','SiteStreet', 'StreetType', 'Postdir', 'SiteCity', 'SiteZip', 'OwnerName']
# Start an edit session. Must provide the workspace.
with arcpy.da.Editor(arcpy.env.workspace) as edit:
with arcpy.da.UpdateCursor(FC, updateFieldsList) as updateRows:
for updateRow in updateRows:
keyValue = updateRow[0]
if keyValue in valueDict:
for n in range (1,len(sourceFieldsList)):
updateRow = valueDict[keyValue][n-1]
updateRows.updateRow(updateRow)
arcpy.RefreshActiveView()
