If your log is showing that the alias is updated, it probably is actually updated. If you have an arcpro instance open, those changes won't be seen until you re open the project though.
if it's not the offending line might be:
if not field.required and len(field.name) > 20:
you're checking field.name but you probably mean to be checking field.aliasName
I did just re-write your code to check this and this works if you restart so here's a class object that takes a gdb path, a logpath, and an optional callable for string re-writes:
import arcpy
import os
class AliasUpdater:
def __init__(self, gdb: os.PathLike, logpath: os.PathLike=None, update_rule: callable=None) -> None:
self.gdb = gdb
if not arcpy.Exists(self.gdb):
raise FileNotFoundError(f'{self.gdb} does not exist')
# Set workspace and get all datasets
arcpy.env.workspace = self.gdb
self.fds = arcpy.ListDatasets()
# Initialize log
self.log = []
self.logpath = logpath
# Get All Features and Tables
self.features: list = arcpy.ListFeatureClasses()
self.features.extend(arcpy.ListTables())
for ds in self.fds:
self.features.extend([f"{ds}\\{fc}" for fc in arcpy.ListFeatureClasses(feature_dataset=ds)])
# Accept a callable to update the alias
self.update_rule: callable = update_rule if update_rule else self._alias_rule
def update_all_aliases(self):
# Update Aliases for all features
for feature in self.features:
self._update_feature_alias(feature)
if self.logpath:
self._log()
def _update_feature_alias(self, feature: os.PathLike):
# Print Feature Name and Log
self._print(f'Feature Name: {feature}\n{"="*100}')
for field in arcpy.ListFields(feature):
# Skip if field is required (Add additional rules here if needed)
if field.required: continue
# Update Alias
self._update_field_alias(feature, field)
def _update_field_alias(self, feature: os.PathLike, field: arcpy.Field):
# Run current alias through alias rule
new_alias = self.update_rule(field.aliasName)
# If new alias is the same as the current alias, return
if new_alias == field.aliasName: return
# Update alias
self._print(f'\tUpdating {field.name} alias from {field.aliasName} to {new_alias}')
arcpy.management.AlterField(feature, field.name, new_field_alias=new_alias)
def _alias_rule(self, alias: str) -> str:
""" Change this to do any string processing you want on the alias """
return alias.replace("_", " ").replace('PCT', '%').replace('plus', '+')
def _print(self, message: str):
"""Prints message and appends to log"""
print(message)
self.log.append(message)
def _log(self):
"""Writes log to logpath if provided"""
with open(self.logpath, 'a') as f:
f.write('\n'.join(self.log))
def main():
def alt_rule(alias: str) -> str:
return alias.upper()
gdb = r'<path to gdb>'
logpath = r'<path to log>'
updater = AliasUpdater(gdb, logpath=logpath)
updater.update_all_aliases()
alt_updater = AliasUpdater(gdb, logpath=logpath, update_rule=alt_rule)
alt_updater.update_all_aliases()
if __name__ == '__main__':
main()
