I just tried to publish a map to AGOL and got a lot of errors after "Analyze" because all my labels contain the Shape_length field which it didn't like.

Why not? I had to open all feature classes, add a field, copy the shape_length into the new field, rewrite the labels and only then I could share it. Very annoying and not understandable why!