A couple things:
1. The 'else' here doesn't do anything:
if(IsEmpty($feature["numero_projet_correction"])){
np_1=$feature["numero_projet"]}
else {
$feature["numero_projet_correction"]}
I think your intent in the else clause is to cast $feature["numero_projet_correction"] to np_1
*Fix*
You could change this to:
var np_1 = IIf(!IsEmpty($feature["numero_projet"]), $feature["numero_projet"], $feature["numero_projet_correction"])
2. I think your filter functions may be broken, and therefore not returning any records to 'num_projet' and 'num_projet_corr'. The Filter functions uses a SQL92 expression, with use of the '@' symbol to use variables in the arcade.
The filter expression for 'num_project' is currently:
"numero_projet = '" + np_1 + "'"
But the SQL92 expression for this filter is:
`numero_project = @NP_1`
Likewise for numero_projet_corr:
`numero_projet_corr = @NP_1`
--- Optimizing this calc --- Extra
If you want to improve the efficiency of this calculation, consider nesting the featureSet based calls, which result in more traffic. For your code, you're making 3 calls to the feature:
- FeatureSetByName
- Filter
- Filter
** i don't remember if Count hits the featureSet, but if it does, you'd be making 5.
If you'd like to simplify your code, you could replace this section:
----
var numberlist = FeatureSetByName($map,"Poteau (Lien Survey123)")
var num_proj = Filter(numberlist, "numero_projet = '" + np_1 + "'")
var num_proj_corr = Filter(numberlist, "numero_projet_correction = '" + np_1 + "'")
var counter = Count(num_proj)
var counter_corr = Count(num_proj_corr)
var id = counter+counter_corr+1
return id
----
with this:
---
var id = Count(
Filter(
FeatureSetByName(
$map,
"Poteau (Lien Survey123)"
),
`numero_project = @NP_1 OR numero_project_corr = @NP_1` )
)
---
** Code Block with all corrections: **
var initPoleID = $feature["POLE_NUMBER"]
if (IsEmpty(initPoleNum) || initPoleNum == 0) {
var np_1 = IIf(!IsEmpty($feature["numero_projet"]), $feature["numero_projet"], $feature["numero_projet_correction"])
var numberlist = FeatureSetByName($map, "Poteau (Lien Survey123)")
var poleID = Count(
Filter(
FeatureSetByName(
$map,
"Poteau (Lien Survey123)"
),
`numero_project = @NP_1 OR numero_project_corr = @NP_1` )
)
return poleID + 1
} else {
//Return existing value if null or different of 0
return initPoleNum
}
