FeatureSet.ToJson() produces invalid Json

[ChristianMorin]

We make use of the FeatureSet.ToJson() extensively and while investigation an issue with attribute containing quotes (") I discovered that the ToJson method does not escape quotes or any Json specific characters.

I've also discovered that the attributes all get transformed into strings independently of their types (integer and Boolean should not be converted to strings).

This means that if you take a feature set a perform FeatureSet.FromJson(fs.ToJson()) all your properly typed attributes are now strings.

I there a chance that this could be fixed for the next release (even 3.0 beta)?

Cheers,
Christian Morin.

[JenniferNery]

Thank you for your feedback. I was able to reproduce the bug. We'll try to fix it in future releases.

[ChristianMorin]

Thanks Jennifer for checking it out.

It turns out that there are more issues with the ToJson() method:

- The DisplayFieldName attribute does not get serialized
- The FieldAliases collection does not get serialized

These can also be verified by doing the FeatureSet.FromJson(fs.ToJson())

Cheers,
Christian.

[JenniferNery]

Actually to fix the bug you reported, we have included FeatureSet.Fields property. Setting this property will allow us to include Fields in the serialization and also help us detect the proper serialization per type (i.e. Date or Number field).

[ChristianMorin]

I can see how the Fields property would help to properly serialize the data type. But I'm not sure it would help with the new issue I've reported about the FeatureSet DisplayFieldName property that is not being serialized since this propert is on the FeatureSet itself and not in the features inside the FeatureSet.

I think the DisplayFieldName property was just missed, since properties such as GlobalIdFieldName and ObjectIdFieldName are serialized properly.

Cheers,
Christian.

[RyanCooney]

With the 2.3 release FeatureSets that do not contain geometries don't produce valid JSON if they have ObjectIdFieldName, GlobalIdFieldName, or SpatialReference values set.

FeatureSet fs = new FeatureSet();
fs.ObjectIdFieldName = "ID";
//fs.GlobalIdFieldName = "ID";
//fs.SpatialReference = new SpatialReference(4326);
fs.Features.Add(new ESRI.ArcGIS.Client.Graphic() { Attributes = { { "ID", "1" } } });
Console.WriteLine(fs.ToJson());

Produces this JSON:
{,"objectIdFieldName":"ID""features":[{"attributes":{"ID":"1"}}]}

[RyanCooney]

Also fails if the FeatureSet does not contain any features.

FeatureSet fs = new FeatureSet();
fs.ObjectIdFieldName = "ID";
Console.WriteLine(fs.ToJson());

{,"objectIdFieldName":"ID"}