Latest Contributions by JohannesLindner

You have a few problems in your code: line 10: after this, you need to check if you found a drop table record, else line 11 could fail with "unexpected null") line 18: continue is used in for loops to jump to the next iteration and skip the rest of the for block for the current iteration. What you want to do is return null, for the same reason as in line 10. line 27: Date() constructs a date from the arguments you give it. I suppose you want Today(), which returns the current date. //returns a percentage of safe fill capacity based on drop rate var layerID = $feature.tankID //query the drop rate table for matching tank ID var dropRateTable = FeatureSetByPortalItem(Portal('https://arcgis.com/'), 'drop rate table portal id'); var filterStatement = "tankID = @layerID" // must select First record from filtered records, otherwise cannot call values var tankDropTable = First(filter(dropRateTable, filterStatement)) // no drop rate found? -> return null if(tankDropTable == null) { return null } var tankDropRate = tankDropTable.dropRate // get date of last fill from form var formID = FeatureSetByPortalItem(Portal('https://arcgis.com/'), 'tank fill form portal id', 1, ['*'], false); var tank = filter(formID, filterStatement) if (Count(tank) == 0){ return null } // Order records by objectid; you can set this to some date field, too var ordered_tanks = OrderBy(tank, "CreationDate DESC") var tank = First(ordered_tanks) var fillDate = tank.CreationDate // calculate days since last fill var daysSince = Round(DateDiff(Today(), fillDate, 'days')) // gallons dropped to date var gallonsDropped = tankDropRate * daysSince // percent full of safe fill level var pctFull = Round((($feature.safeFill - gallonsDropped) / $feature.safeFill) * 100) return pctFull   I don't know if that helps with the error you got, but it's worth a try.   Using the FeatureSetBy* functions in visualization and labeling isn't supported (and there are no plans to do so) for performance reasons.   Possible solutions: Join table / database view Join the two tables (only the newest record of the fill table) to the tank fc. You should be able to use those values in the visualization profile.   Store the attributes in the tank fc I'm guessing the drop rate is fixed, so you can store that as attribute of the tanks. The date when the tank was last filled could be either edited manually by your field workers or with an Attribute Rule on the Survey Form. You can then use these attributes in the visualization profile: var gallonsDropped = DateDiff(Today(), $feature.LastFillDate, "days") * $feature.DropRate return Round((($feature.safeFill - gallonsDropped) / $feature.safeFill) * 100)   Store just the PctFull If you don't want / can't store drop rate and last fill date in the tank fc, you have to store the fill state. In that case, you can't calculate it dynamically with Arcade, but have to do it manually or automatically (like Josh said, schedule a python script that calculates the field to run every few minutes / hour / day). ... View more

Easiest way: if($feature.Purpose == "Stream Crossing-B") { // bridge code except last line return DefaultValue(popupString1, "No bridge inspection on record") } else { // culvert code except last line return DefaultValue(popupString1, "No culvert inspection on record") }   Better way: The code for bridges and culverts is the same, only the actual data is different. So you have to abstract the code a little: // Access the inspection table as a FeatureSet var portal = Portal("https://www.arcgis.com") var portal_item = "ae306d66da414b7f83f1c7db4284a632" var layer = IIF($feature.Purpose == "Stream Crossing-B", 2, 1) var fields = ['Inspection_Date', 'Condition_Overall', 'Inspector_Initials'] var inspection_table = FeatureSetByPortalItem(portal, portal_item, layer, fields) // Build the filter statement var GlobalID = $feature.GlobalID var filterStatement = IIF($feature.Purpose == "Stream Crossing-B", "Bridge", "Culvert") + "_GlobalID = @GlobalID" // Related features as a variable var relatedData = Filter(inspection_table, filterStatement) // Sort related features by newest to oldest var relatedDataSorted = OrderBy(relatedData, 'Inspection_Date DESC') // Build the popup string if(Count(relatedDataSorted) == 0) { return 'No culvert inspections on record' } var f = First(relatedDataSorted); return DefaultValue(f.Condition_Overall, 'No Condition Recorded') + " " + Text(f.Inspection_Date, 'MM/DD/YYYY') + " by " + DefaultValue(f.Inspector_Initials, 'No Inspector Recorded') ... View more

Something like this (untested)?   // define list of week day and opening hours var opening_hours = [ ["Sunday", $feature.sunday_open_close, $feature.sunday_open, $feature.sunday_close], ["Monday", "$feature.monday_open_close, $feature.monday_open, $feature.monday_close], // ... ] // build string for each week day var opening_hours_strings = [] for(var i in opening_hours) { var oh = opening_hours[i] var oh_string = oh[0] + " - Closed" if(oh[1] != "closed") { oh_string = Concatenate([oh[0], oh[2], oh[3]], " - ") } Push(opening_hours, oh_string) } // Concatenate the week days with line breaks return Concatenate(opening_hours_strings, TextFormatting.NewLine)   ... View more

Ah. In that case: go to the layer's style settings Choose "New Expression" as symbol field edit and use this expression (it will return true or false): var start_date = Today() var end_date = DateAdd(Today(), 5, "days") var test_date = $feature.DateField return test_date >= start_date && test_date <= end_date  Choose "Distinct Values" as styling option Style the symbols for true and false You can also hide the false features by setting the transparency to 100%.    Before:   After applying the Arcade expression:   After hiding the false features:     Note that this approach will probably be slower than just filtering out the undesired features from the layer (see HuubZwart's answer). ... View more

You're not returning anything from the expression. Try adding this as the last line: return result   ... View more

The tool you're looking for is Select Layer By Location. You can open it from the Geoprocessing Pane (Data Management -> Layers and Table Views) or from the Map Ribbon:   Parameters: Input features: polygons Selecting features: points Relationship: Intersect If nothing is found, try using a small Search Distance.   ... View more