nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Help with updating an old arcgisscripting file to arcpy.

WhitneyNewcomb

Hi everyone.

I was put to the task of comparing some data and found the perfect script already created that did pretty much everything I need. HOWEVER it's was written originally for ArcMap9.3 and used the arcgisscripting python library.

I've just about used the extent of my python knowledge to convert it to arcpy.

I was able to use this script to compare point shapefiles, but now I need it to work on polygons as well. And I keep getting an error on line 69. I believe that it is having a problem with the differences to the describe function between the two libraries.

I'm totally stuck on this and really need this script to work. I feel a little bad just dumping my script here and hoping someone can fix/figure out what's wrong with the script.

((I also realize that within the script I have not updated everything to be the quickest (i.e. arcpy.SearchCursor changed to arcpy.da.SearchCursor) This is because I tried and failed to do so..))

ChangeComp.py.zip

Capture3.PNG

HannahOlpinski_0-1724356239301.png

Encuentra más publicaciones etiquetadas con

Accepted answers

All comments

curtvprice

so you wouldn't need to know the name of the area field.

The token SHAPE@AREA doesn't refer to a field -- the area is accessed from the data in the feature table's shape field -- that means Randy's useful approach would work with shapefiles, which don't have an automatic Shape_Area field calculated.

RandyBurton

Posting code in a code block (use the syntax highlighter by clicking "More" when you create/edit your message) has a number of advantages. Convenience is probably the most important; people don't have to download and extract to see what you are attempting. Using the code block properly will add formatting and line numbering which will aid the discussion. A brief description of the project will help focus the discussion. Sometimes uploading sample of your data (and/or a picture of it) will assist in testing code.

Regarding the AreaFieldName, you could check to see if the attribute exists, as in:

<SPAN class="keyword token">if</SPAN> shapeType <SPAN class="operator token">==</SPAN> <SPAN class="string token">"Polygon"</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">if</SPAN> hasattr<SPAN class="punctuation token">(</SPAN>dscB<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"AreaFieldName"</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; areaField <SPAN class="operator token">=</SPAN> dscB<SPAN class="punctuation token">.</SPAN>AreaFieldName
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; attributesToCompare<SPAN class="punctuation token">.</SPAN>append<SPAN class="punctuation token">(</SPAN>areaField<SPAN class="punctuation token">)</SPAN>‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

With a SearchCursor you can use tokens in place of field names, so you wouldn't need to know the name of the area field. (Check out the field names in the syntax help section.) As an example, you can get the object ID using OID@ and the area using SHAPE@AREA.

fc <SPAN class="operator token">=</SPAN> r<SPAN class="string token">"C:\Path\To\shapefile.shp"</SPAN>
<SPAN class="keyword token">with</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>SearchCursor<SPAN class="punctuation token">(</SPAN>fc<SPAN class="punctuation token">,</SPAN><SPAN class="punctuation token">[</SPAN><SPAN class="string token">"OID@"</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">"SHAPE@AREA"</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN> <SPAN class="keyword token">as</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">print</SPAN> <SPAN class="string token">'{}, {}'</SPAN><SPAN class="punctuation token">.</SPAN>format<SPAN class="punctuation token">(</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">,</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="string token">'''
0, 24556814787.3
1, 28419119732.9
2, 12772853815.8
3, 46299780205.9
'''</SPAN>
‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

WhitneyNewcomb

Hi Randy,

I apologize for my sparse post.

I didn't put my code in a code block because I didn't know where to focus and instead wanted to just post all of it which I felt wouldn't work well with a code block. Is this an incorrect assumption?

Do you have any solutions for the AreaFieldName? I realized that was one of the problems with the script and couldn't find a fix.

WhitneyNewcomb

Thank you Curtis, I greatly appreciate your tip.

This is really my first time actively using a forum and I appreciate any knowledge drops to help me get my help faster.

curtvprice

Whitney, just a tip for the future, please don't make another thread, instead, just cross-reference the thread like this to Analysis‌ - this makes this thread show up in both places. (And change your thread title if the subject of the thread changes this dramatically, since you started the thread you can do this.)

The cross-reference link btw just pointed back here; here's the correct one:

How to determine the changes between two polygon shapefiles of similar data

RandyBurton

The "AreaFieldName" is a property for a Geodatabase Feature Class. You are comparing shape files (.shp) which do not have this property - and thus the error at line 69.

<SPAN class="comment token"># String representing original feature class path</SPAN>
featureClassB <SPAN class="operator token">=</SPAN> <SPAN class="string token">"J:/GIS/GIS_PROJ/parcels/Comparisons/2017_02-03/Data/03_DOIT_SOI.shp"</SPAN>

dscB <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>Describe<SPAN class="punctuation token">(</SPAN>featureClassB<SPAN class="punctuation token">)</SPAN>
shapeType <SPAN class="operator token">=</SPAN> str<SPAN class="punctuation token">(</SPAN>dscB<SPAN class="punctuation token">.</SPAN>ShapeType<SPAN class="punctuation token">)</SPAN>

<SPAN class="keyword token">if</SPAN> shapeType <SPAN class="operator token">==</SPAN> <SPAN class="string token">"Polygon"</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp; areaField <SPAN class="operator token">=</SPAN> dscB<SPAN class="punctuation token">.</SPAN>AreaFieldName&nbsp; <SPAN class="comment token"># line 69</SPAN>
&nbsp;&nbsp;&nbsp; attributesToCompare<SPAN class="punctuation token">.</SPAN>append<SPAN class="punctuation token">(</SPAN>areaField<SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token"># AttributeError: DescribeData: Method AreaFieldName does not exist‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

You may wish to post your code in a code block (see Code Formatting... the basics) to get more comments. Also, as Joshua Bixby‌ suggested, you may want to provide a short description of what you are trying to accomplish.

If I understand your code, you are trying to compare two shape files and write the differences to a third shape file.

curtvprice

Why re-code it all? arcgisscripting is still there -- the old script may yet work at 10.x. I have many scripts that run unmodified in all versions after 9.3 (and Pro).

RebeccaStrauch__GISP

I converted your discussion to a question. Questions tend to get more views and responces. For some other tips on posting, check out https://community.esri.com/community/help-and-feedback/blog/2016/08/15/community-news-and-tips-how-to-ask-questions-and-get-answers?sr=search&searchId=ef0d9807-56f7-49af-b952-4d57535c1995&searchIndex=0‌

i agree with Joshua that sometimes it is easier to start from scratch, but of course that depends on the complexity. (Sorry, I can't offer anything advice since I'm not able to open the attachment for a few days. )

RandyBurton

Does Feature Compare do some of what you want?

WhitneyNewcomb

Thank you for your advice. I've posted the problem to GeoNet/Analysis: https://community.esri.com/thread/204867-help-with-updating-an-old-arcgisscripting-file-to-arcpy

And thank you kindly for your time Joshua.

JoshuaBixby

Instead of trying to migrate older code, sometimes it is easier to propose the problem to GeoNet users and see what solutions they come up with. What does your data look like? What are you trying to do to it?

Únete a la Conversación

Los miembros registrados pueden publicar, seguir actualizaciones y más. ¿Nuevo aquí? Regístrate gratis.

Enlaces Rápidos

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.