nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

FileNameInsert.py

BenLeslie1

I downloaded this arcscript from here: Filename Insert‌

It's an old script from 2006 and when I run it I get the following error:

File "C:\FileNameInsert.py", line 15, in <module>

import win32com.client, sys, string, os

ImportError: No module named win32com.client

How do I modify this script so it works in 2014?

(what I hoping to achieve is to add a filename attribute to my shapefiles so that when I merge them together I can trace back to the originals)

Encontre mais publicações marcadas com

Accepted answers

DanPatterson_Retired

again...not tested...try this

import arcpy

# Remember to change this to wherever your shapefiles are stored

arcpy.env.workspace = r"C:\temp2"

fcs = arcpy.ListFeatureClasses()

for fc in fcs:

print fc

# Create the new field

arcpy.AddField_management (fc, "FILENAME", "text", "", "", "50")

# Apply the filename to all entries

arcpy.CalculateField_management (fc, "FILENAME", '"' + fc + '"')

#print arcpy.GetMessages ()

There seems to be something with the try..except block

All comments

BenLeslie1

Actually I don't know why I mention it I think they are actually very different beasts and just because the flow diagram layout is similar I want to see ModelBuilder with my FME eyes. And whereas FME is super flexible, user friendly and powerful, I have so far found modelbuilder to clunky, inflexible and unclear.

JohannesBierer

It's only a format option in GeoNet, you can define the code as python or other ....

Haven't used FME often, but don't u use there something similar to "model" geoprocessing tasks?

BenLeslie1

Sorry I didn't see you also corrected the script - I thought you were just saying your way of displaying the code in GeoNet was better. It looks like a screenshot of Notepad++ but you can select the text?

I'm pretty new to Arc, I currently find ModelBuilder more confusing than code - I'm used to working with FME a lot so I want it to work like that, I find MB very unintuitive.

JohannesBierer

Haven't seen there was the solution 🙂

It's quite easy, you use the model builder and export to script ....

BenLeslie1

Thanks Dan - I'm a tiny step closer to being a python expert.

DanPatterson_Retired

again...not tested...try this

import arcpy

# Remember to change this to wherever your shapefiles are stored

arcpy.env.workspace = r"C:\temp2"

fcs = arcpy.ListFeatureClasses()

for fc in fcs:

print fc

# Create the new field

arcpy.AddField_management (fc, "FILENAME", "text", "", "", "50")

# Apply the filename to all entries

arcpy.CalculateField_management (fc, "FILENAME", '"' + fc + '"')

#print arcpy.GetMessages ()

There seems to be something with the try..except block

BenLeslie1

Good plan - my Arc machine isn't connected to the internet so usually it's a pain in the neck. I forgot that I had downloaded the code off the internet.

This is the code after my changes........

#import relevant modules, create geoprocessing dispatch object

import arcpy

#gp = win32com.client.Dispatch("esriGeoprocessing.gpDispatch.1")

# Remember to change this to wherever your shapefiles are stored

arcpy.workspace = "C:\temp2"

try:

fcs = arcpy.ListFeatureClasses("*", "all")

fcs.reset()

fc = fcs.Next()

while fc:

# Create the new field

arcpy.AddField_management (fc, "FILENAME", "text", "", "", "50")

# Apply the filename to all entries

arcpy.CalculateField_management (fc, "FILENAME", '"' + fc + '"')

fc = fcs.Next()

except:

print arcpy.GetMessages ()

DanPatterson_Retired

These two lines don't work in arcpy

fcs.reset()

rc = fcs.Next()

you might be advised to copy the script to your thread rather than relying on people downloading it themselves. The translation from 9.x to 10.x isn't simply a matter of replacing gp with arcpy, there are other issues

BenLeslie1

Thanks - that kind of makes sence but the script isn't doing anything. It runs without error but doesn't add the new field.

Did you download the script? Can I ask some questions?

I removed line 17:

gp = win32com.client.Dispatch...............

was I correct to do this?

I don't understand the 'try:' section....it says:

try:

fcs = arcpy.ListFeatureClasses("*", "all")

fcs.reset()

rc = fcs.Next()

Why does it define fcs and then reset it on the next line? What is it doing?

I'll be happy if you can recommend a place where I can read up on these terms.

Regards

Ben

JohannesBierer

import arcpy

Then replace gp. through arcpy.

Participe da Conversa

Membros conectados podem postar, seguir atualizações e mais. Novo aqui? Registre uma conta gratuita.

Links Rápidos

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.