nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Using STR function in Arcpy Statement

Brian_McLeer

I have created an SDE database in which I have copied feature classes from my production database from State Plane into WGS 84 for web mapping applications. The final step is to create views, and I am trying to automate the process as I have hundreds of feature classes.

Below, I am trying to make a list of all the feature classes and use the name of the feature class. The middle parameter starts with a prefix of v_ then grabs the feature class name (ie: v_watermeters). The third variable is the SQL statement used to create the view definition, where it grabs all the fields (SELECT * FROM ) then I want to use the feature class name (ie: SELECT * FROM watermeters).

I am having trouble with the third variable and concatenating the string values to make valid code.

We are currently on ArcGIS 10.3.1 and SQL Server 2012.

<SPAN class="keyword token">import</SPAN> arcpy
<SPAN class="keyword token">import</SPAN> os
arcpy<SPAN class="punctuation token">.</SPAN>env<SPAN class="punctuation token">.</SPAN>workspace <SPAN class="operator token">=</SPAN> <SPAN class="string token">"Database Connections\\Server Database sde.sde"</SPAN>
featureclasses <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>ListFeatureClasses<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="keyword token">for</SPAN> fc <SPAN class="keyword token">in</SPAN> featureclasses<SPAN class="punctuation token">:</SPAN>
 arcpy<SPAN class="punctuation token">.</SPAN>arcpy<SPAN class="punctuation token">.</SPAN>CreateDatabaseView_management<SPAN class="punctuation token">(</SPAN>
 fc<SPAN class="punctuation token">,</SPAN> os<SPAN class="punctuation token">.</SPAN>path<SPAN class="punctuation token">.</SPAN>join<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Database Connections\\Server Database sde.sde"</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">"v_"</SPAN><SPAN class="operator token">+</SPAN>str<SPAN class="punctuation token">(</SPAN>featureclasses<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"select * from "</SPAN><SPAN class="operator token">+</SPAN>featureclasses<SPAN class="punctuation token">)</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Encontre mais publicações marcadas com

Accepted answers

FrédéricPRALLY

Hi,

Try following code :

<SPAN class="keyword token">import</SPAN> arcpy
<SPAN class="keyword token">import</SPAN> os
arcpy<SPAN class="punctuation token">.</SPAN>env<SPAN class="punctuation token">.</SPAN>workspace <SPAN class="operator token">=</SPAN> <SPAN class="string token">"Database Connections\\Server Database sde.sde"</SPAN>
featureclasses <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>ListFeatureClasses<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="keyword token">for</SPAN> fc <SPAN class="keyword token">in</SPAN> featureclasses<SPAN class="punctuation token">:</SPAN>
 arcpy<SPAN class="punctuation token">.</SPAN>arcpy<SPAN class="punctuation token">.</SPAN>CreateDatabaseView_management<SPAN class="punctuation token">(</SPAN>
 <SPAN class="string token">"Database Connections\\Server Database sde.sde"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"v_"</SPAN> <SPAN class="operator token">+</SPAN> str<SPAN class="punctuation token">(</SPAN>fc<SPAN class="punctuation token">.</SPAN>split<SPAN class="punctuation token">(</SPAN><SPAN class="string token">'.'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">[</SPAN><SPAN class="number token">2</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"select * from "</SPAN> <SPAN class="operator token">+</SPAN> fc<SPAN class="punctuation token">)</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

All comments

Brian_McLeer

Thank you, that one worked after removing the double 'arcpy'.

bixb0012

I think fc.split('.')[-1] will work with more platforms.

JoeBorgione

I'm not the guy looking for a solution, but I'm sure he'll give it a spin....

FrédéricPRALLY

Hi,

Try following code :

<SPAN class="keyword token">import</SPAN> arcpy
<SPAN class="keyword token">import</SPAN> os
arcpy<SPAN class="punctuation token">.</SPAN>env<SPAN class="punctuation token">.</SPAN>workspace <SPAN class="operator token">=</SPAN> <SPAN class="string token">"Database Connections\\Server Database sde.sde"</SPAN>
featureclasses <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>ListFeatureClasses<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="keyword token">for</SPAN> fc <SPAN class="keyword token">in</SPAN> featureclasses<SPAN class="punctuation token">:</SPAN>
 arcpy<SPAN class="punctuation token">.</SPAN>arcpy<SPAN class="punctuation token">.</SPAN>CreateDatabaseView_management<SPAN class="punctuation token">(</SPAN>
 <SPAN class="string token">"Database Connections\\Server Database sde.sde"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"v_"</SPAN> <SPAN class="operator token">+</SPAN> str<SPAN class="punctuation token">(</SPAN>fc<SPAN class="punctuation token">.</SPAN>split<SPAN class="punctuation token">(</SPAN><SPAN class="string token">'.'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">[</SPAN><SPAN class="number token">2</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"select * from "</SPAN> <SPAN class="operator token">+</SPAN> fc<SPAN class="punctuation token">)</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

JoeBorgione

I'm not familiar with the CreateDataBaseView_management() function, but error 837 catches my attention. Again, just my personal preference, but I would create a varable to hold the database name parameter and insert it rather than using the os.path.join() method where you do. I just like laying things out...

DarrenWiens2

Check your parameters against the help.

Create Database View—Help | ArcGIS for Desktop

The tool takes 3 parameters.

1.) database

2.) view name

3.) view definition

Also, am I seeing double or do I see "arcpy.arcpy"? That is a red flag.

Brian_McLeer

I updated line 6 and 7 with your code but seems to still report an error:

Traceback (most recent call last):
File "C:\path\to\python\file.py", line 8, in <module>
arcpy.arcpy.CreateDatabaseView_management(fc, os.path.join("Database Connections\\Server DB sde.sde",'v_{}'.format(fc), 'select * from {}'.format(fc)))
File "C:\Program Files (x86)\ArcGIS\Desktop10.3\ArcPy\arcpy\management.py", line 4069, in CreateDatabaseView
raise e
ExecuteError: Failed to execute. Parameters are not valid.
ERROR 000837: The workspace is not the correct workspace type.
ERROR 000735: View Definition: Value is required
Failed to execute (CreateDatabaseView).

<SPAN class="keyword token">import</SPAN> arcpy
<SPAN class="keyword token">import</SPAN> os
arcpy<SPAN class="punctuation token">.</SPAN>env<SPAN class="punctuation token">.</SPAN>workspace <SPAN class="operator token">=</SPAN> <SPAN class="string token">"Database Connections\\Server DB sde.sde"</SPAN>
featureclasses <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>ListFeatureClasses<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>
 
<SPAN class="keyword token">for</SPAN> fc <SPAN class="keyword token">in</SPAN> featureclasses<SPAN class="punctuation token">:</SPAN>
 arcpy<SPAN class="punctuation token">.</SPAN>arcpy<SPAN class="punctuation token">.</SPAN>CreateDatabaseView_management<SPAN class="punctuation token">(</SPAN>fc<SPAN class="punctuation token">,</SPAN> os<SPAN class="punctuation token">.</SPAN>path<SPAN class="punctuation token">.</SPAN>join<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Database Connections\\Server DB sde.sde"</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">'v_{}'</SPAN><SPAN class="punctuation token">.</SPAN>format<SPAN class="punctuation token">(</SPAN>fc<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'select * from {}'</SPAN><SPAN class="punctuation token">.</SPAN>format<SPAN class="punctuation token">(</SPAN>fc<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN>‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

DanPatterson_Retired

<SPAN class="comment token"># ---- what you have</SPAN>
featureclasses <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'a'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'b'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'c'</SPAN><SPAN class="punctuation token">]</SPAN>

<SPAN class="string token">'v_'</SPAN> <SPAN class="operator token">+</SPAN> str<SPAN class="punctuation token">(</SPAN>featureclasses<SPAN class="punctuation token">)</SPAN>

<SPAN class="string token">"v_['a', 'b', 'c']"</SPAN>

<SPAN class="comment token"># ---- what you want, one at a time</SPAN>

fc <SPAN class="operator token">=</SPAN> featureclasses<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN>

<SPAN class="string token">'v_'</SPAN> <SPAN class="operator token">+</SPAN> str<SPAN class="punctuation token">(</SPAN>fc<SPAN class="punctuation token">)</SPAN>

<SPAN class="string token">'v_a'</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

JoeBorgione

In line 8, you refer twice to 'featureclasses' which is the name of the list you are iterating through. I'm not sure why you are doing that. It seems to me you would want the value of fc instead, the current item of the list.

Personally, I prefer to use the format() function when I can to concatenate characters and variable values.

for fc in featureclasses:
 arcpy.arcpy.CreateDatabaseView_management(
 fc, os.path.join("Database Connections\\Server Database sde.sde",'v_{}'.format(fc), 'select * from {}'.format(fc)<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

DarrenWiens2

Consider the following, and note that the individual item is 'fc' and the list, which never changes, is 'featureclasses':

featureclasses <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'a'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'b'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'c'</SPAN><SPAN class="punctuation token">]</SPAN>

<SPAN class="keyword token">for</SPAN> fc <SPAN class="keyword token">in</SPAN> featureclasses<SPAN class="punctuation token">:</SPAN>
    <SPAN class="keyword token">print</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="string token">'start'</SPAN><SPAN class="punctuation token">)</SPAN>
    <SPAN class="keyword token">print</SPAN><SPAN class="punctuation token">(</SPAN>fc<SPAN class="punctuation token">,</SPAN> featureclasses<SPAN class="punctuation token">)</SPAN>
    <SPAN class="keyword token">print</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="string token">'end'</SPAN><SPAN class="punctuation token">)</SPAN>

start
a <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'a'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'b'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'c'</SPAN><SPAN class="punctuation token">]</SPAN>
end
start
b <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'a'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'b'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'c'</SPAN><SPAN class="punctuation token">]</SPAN>
end
start
c <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'a'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'b'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'c'</SPAN><SPAN class="punctuation token">]</SPAN>
end<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Participe da Conversa

Membros conectados podem postar, seguir atualizações e mais. Novo aqui? Registre uma conta gratuita.

Links Rápidos

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.