nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Comparing a Search Cursor list to number of PDFs Created.

MichelleCouden1

I need some help on my program. I have the parameters set to ask user to pick an mxd and the folder where those data driven PDFs are located. I started with Search Cursor to create a list from the Sheet_ID field of an mxd. To get total number of pages of that mxd. Now I need to write in for the program to compare the list created from the Sheet numbers to the number of PDFs created and tell me if there is a difference in the total count. For Example: If there are 1 out of 11 sheets for the mxd, then there should be 11 PDFs created and so on. MY code is below:

#Purpose: Compares SheeID field to the toal PDFs created from Data Driven Pages Program

Import arcpy, os, string, sys

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = string.split(arcpy.GetParameterAsText(0), ";")
dir = arcpy.GetParameterAsText(1)

#Use Search Cursor to go through Attribuite Table to get Sheet number info
rows = arcpy.SearchCursor(mxdList, "Sheet_ID")

#Use list from Sheet_ID field to match the number of PDFs created to get difference

Encontre mais publicações marcadas com

Accepted answers

MichelleCouden1

Answered!!

All comments

Anonymous User

I think you are on the right track here, but you are not using the search cursor correctly. A search cursor can only be ran on a feature class. You are using a list of mxd's. Here is a way to check a through the attribute table of your feature class that contains the Sheet_ID field. I set up another parameter called fc_path where you can have the user point to the feature class that will have the Sheet_ID field. It will then search through each mxd from the input list for a layer that has a data source that matches the fc (in case the layers have different names in the mxd).

#Purpose: Compares SheeID field to the toal PDFs created from Data Driven Pages Program

import arcpy, os, sys

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = string.split(arcpy.GetParameterAsText(0), ";")
dir = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)

for mapDoc in mxdList:
    arcpy.mapping.MapDocument(mapDoc)
    for lyr in m.ListLayers(mxd):
        if lyr.supports('DATASOURCE'):
            if lyr.dataSource == fc_path:
                max_list = []
                rows = arcpy.SearchCursor(fc_path, "Sheet_ID")
                for row in rows:
                    max_list.append(row.Sheet_ID)
                pdf_count = max(max_list)
                arcpy.AddMessage('Sheet count:  %s'%pdf_count)
            else:
                arcpy.AddError('No layers in %s match data source'%mapDoc)

I am a little confused about comparing the number of pages from the Sheet_ID field from a feature class. Are you going to have the user select PDF's manually to check? If this is the case you will have to find a way to match up the mxd's to the pdf's to make sure the sheet count is corresponding to the correct pdf. This would be easy if the pdf's are named after the mxd's. You will also need to read the page count from each pdf which can be done like this:

pdfDoc = arcpy.mapping.PDFDocumentOpen(path)
print pdfDoc.pageCount

MichelleCouden1

I'm getting an "Object: Error in getting parameter as text" error. Could it be I need to drop the dir = because of the fc_path =? I did add the pdfDoc because you guessed right. I am having the user pick the mxd and the folder with all the pdfs in it. For Example the mxd is named Abilene_Base_Map and the pdf is named Abilene_Base_Map1 ,Abilene_Base_Map2 and so on.
Please check my code to make sure I got it right. Thanks!!

import arcpy, os, string, sys

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = string.split(arcpy.GetParameterAsText(0), ";")
dir = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)
pdfDoc = arcpy.mapping.PDFDocumentOpen(path)

#Use Search Cursor to go through Attribuite Table to get Sheet number info
for mapDoc in mxdList:
    arcpy.mapping.MapDocument(mapDoc)
    for lyr in m.ListLayers(mxd):
        if lyr.supports('DATASOURCE'):
            if lyr.dataSource == fc_path:
                max_list = []
                rows = arcpy.SearchCursor (mxdList, "Sheet_ID")
                for row in rows:
                    max_list.append(row.Sheet_ID)
                pdf_count = max(max_list)
                arcpy.AddMessage('Sheet count: %s'%pdf_count)
            else:
                arcpy.AddError('No Layers in %s match data source'%mapDoc)
print pdfDoc.pageCount

Anonymous User

I am a little confused about your PDF files. You say they are named Abilene_Base_Map1 , Abilene_Base_Map2 etc. Are these separate map books or are they individual 1 page pdf's that will be combined into one map book?

MichelleCouden1

The pdfs are created from the one mxd. For example: Abilene has 11 sheets (data driven pages) so when that tool makes the PDFs it makes 11 PDFS. One for each sheet or Data driven page. I am having a little trouble with your code that you sen earlier. It is saying m. is not defined. You have it typed for lyr in m.ListLayers(mxd): Can you tell me what m. is so I can fix it?

import arcpy, os, string, sys

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = string.split(arcpy.GetParameterAsText(0), ";")
dir = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)

#Use Search Cursor to go through Attribuite Table to get Sheet number info
for mapDoc in mxdList:
    arcpy.mapping.MapDocument(mapDoc)
    for lyr in mxdList.ListLayers(mxd):
        if lyr.supports('DATASOURCE'):
            if lyr.dataSource == fc_path:
                max_list = []
                rows = arcpy.SearchCursor (mxdList, "Sheet_ID")
                for row in rows:
                    max_list.append(row.Sheet_ID)
                pdf_count = max(max_list)
                arcpy.AddMessage('Sheet count: %s'%pdf_count)
            else:
                arcpy.AddError('No Layers in %s match data source'%mapDoc)
pdfDoc = arcpy.mapping.PDFDocumentOpen(path)
print pdfDoc.pageCount

Anonymous User

The pdfs are created from the one mxd. For example: Abilene has 11 sheets (data driven pages) so when that tool makes the PDFs it makes 11 PDFS. One for each sheet or Data driven page.

Using Data Driven Pages should be creating only one PDF that is 11 pages for that MXD. You need to set the 'multiple_files' to the 'SINGLE_FILE' option. That way you get all the sheets into one pdf.

http://help.arcgis.com/en/arcgisdesktop/10.0/help/index.html#//00s300000030000000

As for the m, I forgot to add the import statement. As a shortcut I always import arcpy.mapping as m so I only have to type m instead of the full arcpy.mapping namespace. You should try re-exporting your mxd's using the multiple page option so that you will have only one pdf with all the sheets, then you can do a page count on each pdf. I added a part at the end to make a text file inside the pdf folder that will report any that do not match up. But as I said, I would recommend re-exporting your DDP into multi page documents.

#Purpose: Compares SheeID field to the toal PDFs created from Data Driven Pages Program

import arcpy, os, sys
from os import path as p
from arcpy import mapping as m

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = arcpy.GetParameterAsText(0).split(';')
pdf_path = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)

report = {}
for mapDoc in mxdList:
    arcpy.mapping.MapDocument(mapDoc)
    for lyr in m.ListLayers(mxd):
        if lyr.supports('DATASOURCE'):
            if lyr.dataSource == fc_path:
                max_list = []
                rows = arcpy.SearchCursor(fc_path, "Sheet_ID")
                for row in rows:
                    max_list.append(row.Sheet_ID)
                pdf_count = max(max_list)
                arcpy.AddMessage('Sheet count:  %s'%pdf_count)
            else:
                arcpy.AddError('No layers in %s match data source'%mapDoc)
                
    # List all PDF's in the pdf_path folder
    arcpy.env.workspace = ws = pdf_path
    for pdf_doc in arcpy.ListFiles('*.pdf'):
        if ''.join([a for a in pdf_doc.split('.')[0] if a.isalpha()]) == mapDoc.replace('_',''):
            pdf = p.join(ws, pdf_doc)
            pdf_object = arcpy.mapping.PDFDocumentOpen(pdf)
            page_count = pdf_object.pageCount
            if page_count == pdf_count:
                arcpy.AddMessage('%s Sheet Count matches number of pages in %s' %(mapDoc,pdf_doc))
            else:
                report[mapDoc] = pdf_doc

# Report maps that do not match up
if len(report > 0):
    f = open(p.join(ws,'Page_Report.txt'))
    for k,v in report.iteritems():
        f.write('%s Sheet Count does not match number of pages in %s\n\n' %(k,v))
    f.close()
    arcpy.AddMessage('Created report for map documents and PDF\'s')
else:
    arcpy.AddMessage('All PDF\'s have the correct amount of pages')

Anonymous User

If your goal is to have all the PDF's into individual pages (for example if you want 11 indvidual PDF's for one map book) you could try this code:

#Purpose: Compares SheeID field to the toal PDFs created from Data Driven Pages Program

import arcpy, os, sys
from os import path as p
from arcpy import mapping as m

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = arcpy.GetParameterAsText(0).split(';')
pdf_path = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)

report = {}
page_list = []
for mapDoc in mxdList:
    arcpy.mapping.MapDocument(mapDoc)
    for lyr in m.ListLayers(mxd):
        if lyr.supports('DATASOURCE'):
            if lyr.dataSource == fc_path:
                max_list = []
                rows = arcpy.SearchCursor(fc_path, "Sheet_ID")
                for row in rows:
                    max_list.append(row.Sheet_ID)
                sheet_count = max(max_list)
                arcpy.AddMessage('Sheet count:  {0}'.format(sheet_count))
            else:
                arcpy.AddError('No layers in %s match data source'%mapDoc)
                
    # List all PDF's in the pdf_path folder
    arcpy.env.workspace = ws = pdf_path
    for pdf_doc in arcpy.ListFiles('%s*.pdf' %mapDoc):
        page_list.append(''.join([i for i in pdf_doc.split('.')[0] if i.isdigit()]))
    page_count = max(page_list)
    if page_count == sheet_count:
        arcpy.AddMessage('%s Sheet Count matches number of pages in %s' %(mapDoc,pdf_doc))
    else:
        report[mapDoc] = pdf_doc

# Report maps that do not match up
if len(report > 0):
    f = open(p.join(ws,'Page_Report.txt'))
    for k,v in report.iteritems():
        f.write('%s Sheet Count does not match number of pages in %s\n\n' %(k,v))
    f.close()
    arcpy.AddMessage('Created report for map documents and PDF\'s')
else:
    arcpy.AddMessage('All PDF\'s have the correct amount of pages')

MichelleCouden1

We actually have two scripts for the data driven pages one that does one PDF with all 11 pages inside, then we have the other which does 11 different PDFs. I work for the State they have very wierd requests at times. You have to cover your A##, and be ready for any and all wierd requests. Thanks for the correction. I'll work with the code and let you know.

MichelleCouden1

I'm getting a mxd is not defined. I'm wondering if it is how I have the parameters set up. I have the user putting in mxd then feature class then pdf folder. Should I make it the same order as the code. mxd, pdf, fc.

import arcpy, os, sys
from os import path as p
from arcpy import mapping as m

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = arcpy.GetParameterAsText(0).split(';')
pdf_path = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)

report = {}
page_list = []

#Use Search Cursor to go through Attribuite Table to get Sheet number info
for mapDoc in mxdList:
arcpy.mapping.MapDocument(mapDoc)
for lyr in m.ListLayers(mxd): (It stops right here with mxd error.

Anonymous User

I apologize I was very sloppy with my code I posted. It was untested and was full of errors. I just did a quick test and this should work:

#Purpose: Compares SheeID field to the toal PDFs created from Data Driven Pages Program

import arcpy, os, sys
from os import path as p
from arcpy import mapping as m

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = arcpy.GetParameterAsText(0).split(';')
pdf_path = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)


report = {}
page_list = []
for mapDoc in mxdList:
    arcpy.AddMessage(mapDoc)
    mxd = arcpy.mapping.MapDocument(mapDoc)
    for lyr in m.ListLayers(mxd):
        if lyr.supports('DATASOURCE'):
            if lyr.dataSource == fc_path:
                max_list = []
                rows = arcpy.SearchCursor(lyr)
                for row in rows:
                    max_list.append(row.Sheet_ID)
                sheet_count = max(max_list)
                arcpy.AddMessage('Sheet count:  %s'%sheet_count)
            else:
                arcpy.AddError('No layers in %s match data source'%mapDoc)
                
    # List all PDF's in the pdf_path folder
    arcpy.env.workspace = ws = pdf_path
    for pdf_doc in arcpy.ListFiles('*.pdf'):
        page_list.append(int(''.join([i for i in pdf_doc.split('.')[0] if i.isdigit()])))
    page_count = max(page_list)
    if page_count == sheet_count:
        arcpy.AddMessage('%s Sheet Count matches number of pages in %s' %(mapDoc,pdf_doc))
    else:
        report[mapDoc] = pdf_doc

# Report maps that do not match up
if len(report) > 0:
    f = open(p.join(ws,'Page_Report.txt'))
    for k,v in report.iteritems():
        f.write('%s Sheet Count does not match number of pages in %s\n\n' %(k,v))
    f.close()
    arcpy.AddMessage('Created report for map documents and PDF\'s')
else:
    arcpy.AddMessage('All PDF\'s have the correct amount of pages')

MichelleCouden1

Problem! Can't have it read the layer inside the mxd because every grid layer is named differently. We have to have the user chose the feature class where it will find the Sheet_Id field to compare. Please check the code to see if I changed it correctly? Thanks!

import arcpy, os, sys
from os import path as p
from arcpy import mapping as m

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = arcpy.GetParameterAsText(0).split(';')
pdf_path = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)

report = {}
page_list = []

#Use Search Cursor to go through Attribuite Table to get Sheet number info
for mapDoc in mxdList:
    mxd = arcpy.mapping.MapDocument(mapDoc)
    for lyr in m.ListLayers(mxd):
        if lyr.dataSource == fc_path:     (So here I would delete the if lyr.supports("Datasource) so that it doesn't try to
                                                                                find the layer correct?)
                max_list = []
                rows = arcpy.SearchCursor(mxdList, "Sheet_ID")
                for row in rows:
                    max_list.append(row.Sheet_ID)
                sheet_count = max(max_list)
                arcpy.AddMessage('Sheet count: {0}'.format(sheet_count))
            else:
                arcpy.AddError('No Layers in %s match data source'%mapDoc)
pdfDoc = arcpy.mapping.PDFDocumentOpen(path)
print pdfDoc.pageCount

Anonymous User

import arcpy, os, sys
from os import path as p
from arcpy import mapping as m

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = arcpy.GetParameterAsText(0).split(';')
pdf_path = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)

report = {}
page_list = []

#Use Search Cursor to go through Attribuite Table to get Sheet number info
for mapDoc in mxdList:
    mxd = arcpy.mapping.MapDocument(mapDoc)
    for lyr in m.ListLayers(mxd):
        if lyr.dataSource == fc_path:     (So here I would delete the if lyr.supports("Datasource) so that it doesn't try to
                                                                                find the layer correct?)
                max_list  = []
                rows = arcpy.SearchCursor(mxdList, "Sheet_ID")
                for row in rows:
                    max_list.append(row.Sheet_ID)
                sheet_count = max(max_list)
                arcpy.AddMessage('Sheet count: {0}'.format(sheet_count))
            else:
                arcpy.AddError('No Layers in %s match data source'%mapDoc)
pdfDoc = arcpy.mapping.PDFDocumentOpen(path)

print pdfDoc.pageCount

Do all the layers in the mxd use the same grid? I had it set up if all the grid layers use the same feature class, and it works in mine regardless of what the layer is called in the mxd. If they all use different data sources it will need to be modified.

MichelleCouden1

Yeah, I checked all grids are named differently so I need the user to pick the feature class to run the search cursor. I am new to PYthon so Thank You very much for your help. I wanted to see if I could help with the changes. I've made some changes in the code, see if I'm right or I'm way off.

import arcpy, os, sys
from os import path as p

#Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = arcpy.GetParameterAsText(0).split(';')
pdf_path = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)

report = {}
page_list = []

#Use Search Cursor to go through Attribuite Table to get Sheet number info
for mapDoc in mxdList:
    mxd = arcpy.mapping.MapDocument(mapDoc)
for fcClass in fc_path:
    fc = arcpy.ListFeatureClasses(fcClass)
            max_list = []
            rows = arcpy.SearchCursor(mxdList, "Sheet_ID")
            for row in rows:
                max_list.append(row.Sheet_ID)
                sheet_count = max(max_list)
                arcpy.AddMessage('Sheet count: {0}'.format(sheet_count))
            else:
                arcpy.AddError('No Layers in %s match data source'%mapDoc)
pdfDoc = arcpy.mapping.PDFDocumentOpen(path)
print pdfDoc.pageCount

Anonymous User

I think you are closer now. But using the pdfDoc.pageCount is not necessary since your PDF's are only one page each. That will only return 1 for each PDF. I did a test map book and exported each page out to single pages and was able to get the below code to work.

#Purpose: Compares SheeID field to the toal PDFs created from Data Driven Pages Program

import arcpy, os, sys
from os import path as p
from arcpy import mapping as m

# Make parameters for people to choose mxd and folder of PDFs to compare
mxdList = arcpy.GetParameterAsText(0).split(';')
pdf_path = arcpy.GetParameterAsText(1)
fc_path = arcpy.GetParameterAsText(2)

report = {}
for mapDoc in mxdList:
    arcpy.AddMessage(mapDoc)
    mxd = arcpy.mapping.MapDocument(mapDoc)
    for lyr in m.ListLayers(mxd):
        if lyr.supports('DATASOURCE'):
            if lyr.dataSource == fc_path:
                max_list = []
                rows = arcpy.SearchCursor(lyr)
                for row in rows:
                    max_list.append(row.Sheet_ID)
                sheet_count = max(max_list)
                arcpy.AddMessage('Sheet count:  %s'%sheet_count)
                print 'Sheet count:  %s'%sheet_count
            else:
                arcpy.AddError('No layers in %s match data source'%mapDoc)
                
    page_list = []     
    # List all PDF's in the pdf_path folder
    arcpy.env.workspace = ws = pdf_path
    for pdf_doc in arcpy.ListFiles('*.pdf'):
        pname = ''.join([a for a in pdf_doc.split('.')[0] if a.isalpha()])
        mname = p.basename(mapDoc.replace('_','')).split('.')[0]
        if pname == mname:
            page_list.append(int(''.join([i for i in pdf_doc.split('.')[0] if i.isdigit()])))
    page_count = max(page_list)
    arcpy.AddMessage('Page Count:  %s'%page_count)
    print 'Page Count:  %s'%page_count
    if page_count == sheet_count:
        arcpy.AddMessage('%s Sheet Count matches number of pages in %s' %(mapDoc,pdf_doc))
        print '%s Sheet Count matches number of pages in %s' %(mapDoc,pdf_doc)
    else:
        report[mapDoc] = pdf_doc

# Report maps that do not match up
if len(report) > 0:
    f = open(p.join(ws,'Page_Report.txt'),'w')
    for k,v in report.iteritems():
        f.write('"%s" Sheet Count does not match number of pages in "%s"\n\n' %(k,v))
    f.close()
    arcpy.AddMessage('Created report for map documents and PDF\'s')
    print 'Created report for map documents and PDF\'s'
else:
    arcpy.AddMessage('All PDF\'s have the correct amount of pages')
    print 'All PDF\'s have the correct amount of pages'

Since your PDF's are named like Abilene_Base_Map1, Abilene_Base_Map2, etc you will just want to extract the number that is on the PDF. I then put those numbers in a list and use the max() function to find the maximum value (the last page of the PDF) and if that matches the max page number from the Sheet_ID field then it will tell you that there is the correct amount of pages. If not, it will create a text file in the PDF folder that tells you which mxd and map book do not match up. The fc_path parameter is for the user to select the feature class that has the grid.

The text file had this output:

"C:\Users\GIS\Desktop\DDP\mxd\other_map.mxd" Sheet Count does not match number of pages in "other_map3.pdf"

MichelleCouden1

I think I am the one causing this error. Could it be how I have the parameters setup? Look at attached. It goes 12 times searching the mxd and says it can't find data source. I'm puzzled because I am putting in the mxd, then putting in the PDF folder, and then putting in the feature class that has the field Sheet_ID. I think its me and my parameter setup.

error.docx

Anonymous User

Hmmm I am not sure. What are the input parameters you are using? It looks like it only worked on one of them. If all these maps use the same grid feature class it should work even if the layers are named differently in the map because it checks by data source and not layer name. But if they all use a different grid feature class this will be tricky.

MichelleCouden1

The code should be fine. I have it where my parameters (listed in order) are set for the user to select one mxd (which is the one that does have the fc in it), then select the folder that holds all the pdfs that were created, and then last select the grid layout(feature class\Shapefile) for that mxd (that has the field Sheet_ID). Its wierd! It goes through some of the steps gives a sheet count right from the attribute table "Sheet count: Sheet 9 out of 11 Base Sheets" and then goes through a few more and then gives a page count: 11. I'll continue to look it over.

MichelleCouden1

So maybe that's it. I have to make my parameters for multiple mxds and all of their featureclass\shapefiles (multiple fc's). Now like I said before all maps grids have different names. But if we put in each feature class, it should work. Can't we make the code look through one feature class?

Anonymous User

Yes, that is possible. Or one thing that may be easier, if you are able to make the grid layer the same name in all mxd's I would just do that. Otherwise you could set the parameter to accept multi values and check if any of the layers in each mxd have a data source inside the list of grid feature classes.

MichelleCouden1

Can't change the name of the grid files because they are at different locations around the State of Texas. For Example: Houston has one that covers all its counties and then that tells us how many sheets (Data Driven Pages) are needed for that reference scale. If that makes sense. If the program though searches for the datasource, can I not have the program search the one featureclass\shapefile for the field Sheet_ID. Because, sheet_ID is in the feature class\shapefile. I'll try to figure out how to change that.
Also, will the program run on one mxd?

NigelGriffiths_0-1723505525442.png

MichelleCouden1

You know setting the parameters to multiple mxds and then checking for layers that the grid name that would probably be better. Because all the names for the grids are named as such: ABL_Base_Grid.shp, AMA_Base_MBGrid.shp, AUS_AnnualMBGrid.shp. The only thing that changes is the abbreviation of the district it is in the State of Texas. So it could search for **grid and then read the Sheet_Id field.

Anonymous User

I think it would be easier if you could do it on only one mxd. Then you could just search for all those layers one at a time inside the mxd.

SMauri_1-1618821523741.png

ai-images-that-go-hard-v0-aekteigei0vb1-3783611468.jpg

MichelleCouden1

Yep, that is what I think. Please, take a look at the code to see if I changed stuff correctly. I figured out to use ListLayers. See how close I am.

import arcpy, os, sys
from os import path as p
from arcpy import mapping as m

#Make parameters for people to choose mxd and folder of PDFs to compare

mxdList = string.split(arcpy.GetParameterAsText(0), ";")
pdf_path = arcpy.GetParameterAsText(1)

report = {}

#Use Search Cursor to go through Attribuite Table to get Sheet number info

for mapDoc in mxdList:
    arcpy.AddMessage(mapDoc)
    mxd = arcpy.mapping.MapDocument(mapDoc)
    df = arcpy.mapping.ListLayers(mxd, "*,Traff Proj")[0]
    for lyr in m.ListLayers(mxd, "*, Grid"):
        if lyr.description == "*, Grid":
            max_list = []
            rows = arcpy.SearchCursor(lyr)
            for row in rows:
                max_list.append(row.Sheet_ID)
                sheet_count = max(max_list)
                arcpy.AddMessage('Sheet count: %s'%sheet_count)
                print 'Sheet count: %s'%sheet_count
            else:
                arcpy.AddError('No Layers in %s match data source'%mapDoc)

    page_list = []

Anonymous User

Yep, that is what I think. Please, take a look at the code to see if I changed stuff correctly. I figured out to use ListLayers. See how close I am.

import arcpy, os, sys
from os import path as p
from arcpy import mapping as m

#Make parameters for people to choose mxd and folder of PDFs to compare

mxdList = string.split(arcpy.GetParameterAsText(0), ";")
pdf_path = arcpy.GetParameterAsText(1)

report = {}

#Use Search Cursor to go through Attribuite Table to get Sheet number info

for mapDoc in mxdList:
    arcpy.AddMessage(mapDoc)
    mxd = arcpy.mapping.MapDocument(mapDoc)
    df = arcpy.mapping.ListLayers(mxd, "*,Traff Proj")[0]
    for lyr in m.ListLayers(mxd, "*, Grid"):
        if lyr.description == "*, Grid":
            max_list = []
            rows = arcpy.SearchCursor(lyr)
            for row in rows:
                max_list.append(row.Sheet_ID)
                sheet_count = max(max_list)
                arcpy.AddMessage('Sheet count: %s'%sheet_count)
                print 'Sheet count: %s'%sheet_count
            else:
                arcpy.AddError('No Layers in %s match data source'%mapDoc)
                
    page_list = []

It looks like you are a little closer, I have highlighted problems I see in red. For the future, when you post your code you should use the code tags so it will preserve your indentation which is important in Python (the hashtag symbol, or start with code inside [ ] and end with /code inside [ ] ). On this line:

df = arcpy.mapping.ListLayers(mxd, "*,Traff Proj")[0]

This may not be a problem in your case, but when you use the list layers with [0] afterwards, this will only grab the first value in the list. I see that you are not using this "df" variable, what is it's purpose? In most code samples from the help docs, df will typically denote the data frame. Was this supposed to be ListDataFrames instead of ListLayers?

At the end you are creating an empty list called page_list, but doing nothing with it. I would add something like this at the end:

page_list = []
arcpy.env.workspace = ws = pdf_path
for pdf_doc in arcpy.ListFiles('*.pdf'):
    page_list.append(int(''.join([i for i in pdf_doc.split('.')[0] if i.isdigit()])))
page_count = max(page_list)
arcpy.AddMessage('PDF page count: %s' page_count)
if page_count == sheet_count:
    arcpy.AddMessage('%s Sheet Count matches number of pages in %s' %(mapDoc,pdf_doc))
else:
    arcpy.AddMessage('%s Sheet Count does not match number of pages in %s' %(mapDoc,pdf_doc))

In my example I used the report = {} to create an empty dictionary to store the values that did not match up to write out to a text file. If you do not want to include this part in your script tool you could take this out. I think you're almost there now as long as your wild card usage is correct.

KatrinaOppermann_0-1723513258461.png

MichelleCouden1

The only reason I used df for data Frame was because of the sample I got from ListLayers on the resource desk. I would prefer not to use df because in this case it would be easier for it to just search for the layer. Am I right on the query for name of the layer. For Example: I put an asterik in front of the name to let it know that Grid is not the complete name but it does have Grid in the name.
Before I finish completely, I just want to give you huge Thanks for helping me on this project. You are the first person that has shown me patience. I truly truly appreciate that. This could never been done without your help. This is by far the longest Python code I've ever written.

Anonymous User

No problem, I am no expert but do not mind helping when I can. I think you could take the df variable out, it is an optional parameter for the list layers so may not be necessary for your case. One thing that I usually do when testing a script tool is test it as a stand alone script, then once it works I will convert it to script tool. Of course, since you have a multi value parameter you may have to modify some things slightly for it to work as a script tool.

Have you added the last part from my last post yet? Go ahead and give that a try. If you are still getting errors let me know what they say. You may also want to add some more print statements to let you know what is going on in the script.

MichelleCouden1

It doesn't like my code for sheet count. I've attached to error again for you. It finishes counting the PDFs but it is puzzled on how to give me a sheet count. Error is Sheet_count not defined. So wouldn't I need to write, sheet_count = arcpy.mapping.ListLayers.

Error.docx

Anonymous User

It doesn't like my code for sheet count. I've attached to error again for you. It finishes counting the PDFs but it is puzzled on how to give me a sheet count. Error is Sheet_count not defined. So wouldn't I need to write, sheet_count = arcpy.mapping.ListLayers.

Not sure if this is what was causing a problem, but it looks like the indentation was off judging by your prior example. I did not catch that the first time. Another thing that may be throwing an error is the the "sheet_count" variable has no max value because an empty list was created in the first place from the search cursor. This could be due to it not picking up any layers from your ListLayers().

import arcpy, os, sys
from os import path as p
from arcpy import mapping as m

#Make parameters for people to choose mxd and folder of PDFs to compare

mxdList = string.split(arcpy.GetParameterAsText(0), ";")
pdf_path = arcpy.GetParameterAsText(1)

report = {}

#Use Search Cursor to go through Attribuite Table to get Sheet number info

for mapDoc in mxdList:
    arcpy.AddMessage(mapDoc)
    mxd = arcpy.mapping.MapDocument(mapDoc)
    df = arcpy.mapping.ListLayers(mxd, "*,Traff Proj")[0]
    for lyr in m.ListLayers(mxd, "*, Grid"):
        if lyr.description == "*, Grid":
            max_list = []
            rows = arcpy.SearchCursor(lyr)
            for row in rows:
                max_list.append(row.Sheet_ID)

        else:
            arcpy.AddError('No Layers in %s match data source'%mapDoc)

        sheet_count = max(max_list)
        arcpy.AddMessage('Sheet count: %s'%sheet_count)
        print 'Sheet count: %s'%sheet_count
                
        page_list = []
        arcpy.env.workspace = ws = pdf_path
        for pdf_doc in arcpy.ListFiles('*.pdf'):
            page_list.append(int(''.join([i for i in pdf_doc.split('.')[0] if i.isdigit()])))
        page_count = max(page_list)
        arcpy.AddMessage('PDF page count: %s' page_count)
        if page_count == sheet_count:
            arcpy.AddMessage('%s Sheet Count matches number of pages in %s' %(mapDoc,pdf_doc))
        else:
            arcpy.AddMessage('%s Sheet Count does not match number of pages in %s' %(mapDoc,pdf_doc))

I am not sure about the PDF situation though now. I cannot really see the PDF's you are working with, nor the data and mxd's. Writing this tool may be more trouble than it is worth. If the whole reason you are doing this check in the first place is because you have to have a "single file PDF map book", ie all the DDP pages in one PDF and you have to have another situation where all the pages are in separate PDF's, I think it would be much easier to just write a script to export all DDP pages into a single file PDF and then split that into single pages. You could simply set up an iterator on each PDF and create a one page PDF for each page in the master map book. In doing that you could be sure that no matter what, you will have a page for each Sheet_ID.

MichelleCouden1

I figured out the name not defined. Needed to make sheet_count = 0. It is giving me the correct PDF count in the folder. But it's not counting the sheets right. The one statement I got was "Sheet count does not match number of pages in Amarillo_Base_Map9.pdf" There are no pdfs inside the mxd. It should be getting the sheet count from the Sheet_ID field inside the mxd. The error code should be telling me "Sheet Count in mxd does not match PDF count created" Code is below:

import arcpy, os, sys, string
from os import path as p
from arcpy import mapping as m

#Make parameters for people to choose mxd and folder of PDFs to compare

mxdList = string.split(arcpy.GetParameterAsText(0), ";")
pdf_path = arcpy.GetParameterAsText(1)

#Use Search Cursor to go through Attribuite Table to get Sheet number info

sheet_count = 0
for mapDoc in mxdList:
    arcpy.AddMessage(mapDoc)
    mxd = arcpy.mapping.MapDocument(mapDoc)
    for lyr in m.ListLayers(mxd, "*, Grid"):
        if lyr.description == "*, Grid":
            max_list = []
            rows = arcpy.SearchCursor(lyr)
            for row in rows:
                max_list.append(row.Sheet_ID)
            sheet_count = max(max_list)
            arcpy.AddMessage('Sheet count: %s'%sheet_count)
            print 'Sheet count: %s'%sheet_count
        else:
            arcpy.AddError('No Layers in %s match data source'%mapDoc)
                
    page_list = []
    
    # List all PDF's in the pdf_path folder
    
    arcpy.env.workspace = ws = pdf_path
    for pdf_doc in arcpy.ListFiles('*.pdf'):
        page_list.append(int(''.join([i for i in pdf_doc.split('.')[0] if i.isdigit()])))
    page_count = max(page_list)
    arcpy.AddMessage('PDF Page Count: %s' %page_count)
    if page_count == sheet_count:
        arcpy.AddMessage('%s Sheet Count matches number of pages in %s' %(mapDoc,pdf_doc))
    else:
        arcpy.AddMessage('%s Sheet Count does not match number of pages in %s' %(mapDoc,pdf_doc))

MichelleCouden1

I am actually doing process of elimination. It is the first part of the code that is not doing what we want it to do. I saved just the top part as another script. And I'm having it work the mxd and count the sheets and print the total. So far, its not doing either. It works, just doesn't print out a total number of sheets from that Grid layer.

MichelleCouden1

Hey Caleb, need some help with sheet count!

Participe da Conversa

Membros conectados podem postar, seguir atualizações e mais. Novo aqui? Registre uma conta gratuita.

Links Rápidos

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.