How to improve speed in my arcpy script

SuryaNarayana

Hi every one,

I want to update the symbology of selected feature from a feature layer. For this I have created a table of feature layer and joined these two. Then updating the attribute value in the table to update the symbology of the respect feature in feature layer. I wrote the below python script. By using this script the feature selection is taking more time. Can any one suggest me, how to improve speed in my script.

MarkTool.py.zip

LukeWebb

When you write this code:

				    <SPAN class="keyword token">for</SPAN> selFeature <SPAN class="keyword token">in</SPAN> lyr<SPAN class="punctuation token">.</SPAN>getSelectionSet<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>
					<SPAN class="keyword token">with</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>UpdateCursor<SPAN class="punctuation token">(</SPAN>tbl<SPAN class="punctuation token">,</SPAN> updateFieldsList<SPAN class="punctuation token">)</SPAN> <SPAN class="keyword token">as</SPAN> updateCursor<SPAN class="punctuation token">:</SPAN>
					    <SPAN class="keyword token">for</SPAN> updateRow <SPAN class="keyword token">in</SPAN> updateCursor<SPAN class="punctuation token">:</SPAN>
						<SPAN class="keyword token">if</SPAN> updateRow<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">==</SPAN> selFeature<SPAN class="punctuation token">:</SPAN>
						    updateRow<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">=</SPAN> <SPAN class="string token">"YES"</SPAN>
						    updateCursor<SPAN class="punctuation token">.</SPAN>updateRow<SPAN class="punctuation token">(</SPAN>updateRow<SPAN class="punctuation token">)</SPAN>
						    <SPAN class="keyword token">del</SPAN> updateCursor‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

If you have more than 1 feature selected, the Cursor is running on all of the data and updating it.   It will then update all of the data each time for every selected feature. You probable need something more like:

if   len(lyr.getSelectionSet()) > 0:

       update cursor stuff

You have this in 2 places in your script, so it may be running your script many times more than is needed.

Edit: 

Revised after re-reading the code more thoroughly!, you probably need something more along the lines of this, to stop the cursor going through all of your datasets:

                     <SPAN class="keyword token">for</SPAN> selFeature <SPAN class="keyword token">in</SPAN> lyr<SPAN class="punctuation token">.</SPAN>getSelectionSet<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>
                        <SPAN class="keyword token">with</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>UpdateCursor<SPAN class="punctuation token">(</SPAN>tbl<SPAN class="punctuation token">,</SPAN> updateFieldsList<SPAN class="punctuation token">,</SPAN> where_clause<SPAN class="operator token">=</SPAN><SPAN class="string token">"FID = '%s'"</SPAN> <SPAN class="operator token">%</SPAN> selFeature<SPAN class="punctuation token">)</SPAN> <SPAN class="keyword token">as</SPAN> updateCursor<SPAN class="punctuation token">:</SPAN>
                            <SPAN class="keyword token">for</SPAN> updateRow <SPAN class="keyword token">in</SPAN> updateCursor<SPAN class="punctuation token">:</SPAN>
                            <SPAN class="keyword token">if</SPAN> updateRow<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">==</SPAN> selFeature<SPAN class="punctuation token">:</SPAN>
                                updateRow<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">=</SPAN> <SPAN class="string token">"YES"</SPAN>
                                updateCursor<SPAN class="punctuation token">.</SPAN>updateRow<SPAN class="punctuation token">(</SPAN>updateRow<SPAN class="punctuation token">)</SPAN>
                                <SPAN class="keyword token">del</SPAN> updateCursor‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>