about customViewForGraphic method

Question

I am trying to custom a callout,here is my code:

- (UIView*) customViewForGraphic:   (AGSGraphic *)  graphic
      screenPoint:  (CGPoint)  screen
      mapPoint:  (AGSPoint *)  mapPoint{
 NSMutableDictionary *graphicAttr = [graphic attributes];
 
 GraphicDetailViewController *gdv = [[GraphicDetailViewController alloc] initWithAttr:graphicAttr];
 gdv.tableView.frame = CGRectMake(screen.x, screen.y, 300, 200);
 gdv.tableView.delegate = gdv;
 return gdv.tableView;
}

when I compile and analyze,there is a object leak warning:"Object leaked: object allocated and stored into 'gdv' is not referenced later in this execution path and has a retain count of +1".so I use "autorelease" for gdv object,but when i flip the table in callout,the program crashed.the error is :"-[GraphicDetailViewController tableView:cellForRowAtIndexPath:]: message sent to deallocated instance 0x102d8f00"

how can i resolve this?thanks

NimeshJarecha · Answer

You must create a retain property for the GraphicDetailViewController so it'll be around when you try to view it in the callout.

Regards,
Nimesh

Nicholas-Furness · Answer

- (UIView*) customViewForGraphic:   (AGSGraphic *)  graphic
      screenPoint:  (CGPoint)  screen
      mapPoint:  (AGSPoint *)  mapPoint{
 NSMutableDictionary *graphicAttr = [graphic attributes];

GraphicDetailViewController *gdv = [[GraphicDetailViewController alloc] initWithAttr:graphicAttr];
 gdv.tableView.frame = CGRectMake(screen.x, screen.y, 300, 200);
 gdv.tableView.delegate = gdv;
 return gdv.tableView;
}

There is at least one problem and possibly two with your code, depending on the implementation of GraphicDetailViewController.* You are referencing the GDV as the delegate of the tableView object (so you will add a reference count).
* If the GraphicDataViewController's dealloc method releases the tableView object, then you will have a pointer to an object that was released when the GDV was released (this may be what's happening with your "deallocated instance" error).
*

So, perhaps add a property to your class to store the current GraphicsDataViewController. You would set the property to the GraphicsDataViewController created in customViewForGraphic and release it when the callout showing the GraphicsDataViewController is closed. That way the delegate reference on the returned tableView remains valid for the lifetime of the tableView.

PaulLohr · Answer

Try releasing gdv after it is returned to the method header? Not sure if this will work. Or maybe in the dealloc method?

[gdv release];

JenniferAcunto_5-1754579905406.png

AdrianWelsh_0-1754580060643.png

JenniferAcunto_8-1754580239275.png

JenniferAcunto_7-1754580239274.png