Python 3 Script Not Executing without Error in ArcGIS Pro 3.1.2 but runs Error Free in ArcMap 10.8.1

Zedwards_SIPI

Hello Folks,

I am not a programmer but am getting more and more familiar with ArcPy with ArcGIS Pro these days. I have purchased a digital book that has proven quite useful too. That being said, I am receiving the following error when executing a toolbox script (.py): 

Again, it works fine when run from ArcMap or ArcCatalog and even does what it's supposed to do in Pro but throws the error below .I have also updated my project packages but do get errors when trying to do certain updates or install Spyder from there. Any ideas are much appreciated.

Start Time: Monday, May 29, 2023 3:30:17 PM

NM_wind

ShapeFile

1328

Nothing to Delete

Test

FeatureClass

0

EMPTY VECTOR DATASET DELETED

Traceback (most recent call last):
  File "C:\Users\zach.edwards\OneDrive - Western Data Systems\Documents\AllTerraCentral\Python\ListFCFeaturesRecursivelyCountNameReportDeletezero_PRO.py", line 33, in <module>
    if int(arcpy.GetCount_management(layerName).getOutput(0)) == 0:
  File "C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\management.py", line 23607, in GetCount
    raise e
  File "C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\management.py", line 23604, in GetCount
    retval = convertArcObjectToPythonObject(gp.GetCount_management(*gp_fixargs((in_rows,), True)))
  File "C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\geoprocessing\_base.py", line 512, in <lambda>
    return lambda *args: val(*gp_fixargs(args, True))
arcgisscripting.ExecuteError: Failed to execute. Parameters are not valid.ERROR 000840: The value is not a Table View.ERROR 000840: The value is not a Raster Layer.
Failed to execute (GetCount) 

The actual .py is pasted here below...

import arcpy

import os

 

workspace = arcpy.GetParameterAsText(0)

outFile = open(r"C:\temp\VectorDataList.txt", "a")

shapefiles = []

 

walk = arcpy.da.Walk(workspace, topdown=True, datatype="FeatureClass")

 

for dirpath, dirnames, filenames in walk:

for filename in filenames:

shapefiles.append(os.path.join(dirpath, filename))

for shapefile in shapefiles:

layerName = arcpy.Describe(shapefile).baseName

layerPath = arcpy.Describe(shapefile).path

layerDType = arcpy.Describe(shapefile).dataType

arcpy.AddMessage(layerName)

arcpy.AddMessage(layerDType)

arcpy.MakeFeatureLayer_management (shapefile, layerName)

arcpy.AddMessage(arcpy.GetCount_management(layerName).getOutput(0))

if int(arcpy.GetCount_management(layerName).getOutput(0)) == 0:

arcpy.Delete_management(shapefile)

arcpy.AddWarning("EMPTY VECTOR DATASET DELETED")

else:

arcpy.AddWarning("Nothing to Delete")

outFile.write("\n" "Filename: ")

outFile.write(layerName)

outFile.write("\n""Path: ")

outFile.write(dirpath)

outFile.write("\n" "DataType: ")

outFile.write(layerDType)

outFile.write("\n" "Feature Count: ")

if int(arcpy.GetCount_management(layerName).getOutput(0)) == 0:

outFile.write(arcpy.GetCount_management(layerName).getOutput(0))

outFile.write("\n" "EMPTY VECTOR DATASET DELETED")

else:

outFile.write(arcpy.GetCount_management(layerName).getOutput(0))

outFile.write("\n")

outFile.close()

 

VectorDataList.txt

Anonymous User

Adding to Dan's advice, print the path out of that file that it is stopping on.

I tried your code on a folder and the arcpy.da.Walk did not honor the FeatureClass datatype and included RasterBand files too, which caused it to fail. You can add some logic to your code to skip these unaccounted file types that sneak through so you can check them out manually but still work through the Featureclasses and shapefiles:

import arcpy
import os

workspace = arcpy.GetParameterAsText(0)
if workspace is None or workspace == '':
    workspace = r'default path to parent folder for running in IDE'


def outfile_writer(layerName, layerPath, lyr_view, msg):
    '''
    helper function for writing the output to file
    '''
    outFile.write(f"\nFilename: {layerName} "
                  f"\nPath: {layerPath} "
                  f"\nFeature Count: {arcpy.management.GetCount(lyr_view).getOutput(0)}"
                  f"\n{msg}\n")

shapefiles = []

for dirpath, dirnames, filenames in arcpy.da.Walk(workspace, topdown=True, datatype="FeatureClass"):
    for filename in filenames:
        shapefiles.append(os.path.join(dirpath, filename))

with open(r"path to \VectorDataList.txt", "a") as outFile:
    for shapefile in shapefiles:
        desc = arcpy.Describe(shapefile)
        layerName = desc.baseName
        layerPath = desc.path
        layerDType = desc.dataType

        arcpy.AddMessage(layerName)
        arcpy.AddMessage(layerDType)
        arcpy.AddMessage(layerPath)

        if layerDType in ['FeatureClass', 'ShapeFile']:
            lyr_view = arcpy.MakeFeatureLayer_management (shapefile, f'{layerName}_lyr')
            try:
                arcpy.AddMessage(arcpy.management.GetCount(lyr_view).getOutput(0))
                if int(arcpy.management.GetCount(lyr_view).getOutput(0)) == 0:
                    arcpy.AddMessage("EMPTY VECTOR DATASET DELETED")
                    outfile_writer(layerName, layerPath, lyr_view, 'EMPTY VECTOR DATASET DELETED')
                    arcpy.management.Delete(shapefile)
                else:
                    arcpy.AddMessage("Nothing to Delete")
                    outfile_writer(layerName, layerPath, lyr_view, 'DATASET NOT DELETED')

            except Exception as ex:
                arcpy.AddMessage(f"Could not open {layerName} at {layerPath}")
                outFile.write(f"\nCOULD NOT DELETE! {layerName} at {layerDType}")

        else:
            outFile.write(f"\nSKIPPIED! arcpy.da.Walk datatype filter failed: {layerName} is {layerDType}\n")
            arcpy.AddMessage(f"\nSKIPPIED! arcpy.da.Walk datatype filter failed: {layerName} is {layerDType}")