nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

ArcMap10.1 Loop through a unique list to create new layers for each unique name.

StewartChritton

I have only taken one GIS class that used python so this is messy!

I was able to get the unique list from the attributes table under the column 'Layer'. Next I need the program to use each unique name from that list, select by attributes and create a new layer file for each unique name. I have the count in there because there are 33 different unique names in that list. I know there is a better way to do this, I just don't remember how.

I realize my code is far from perfect so if you have other questions or tips please don't hesitate to ask.

import arcpy, sys, os, traceback

fc = r"C:\Users\Drew\Desktop\Montpelier\PythonTest\PythonGDB.gdb\dshline_Project"
field = ["Layer"]
valueList = []

#Use search cursor to aquire a list of unique values
    with arcpy.da.SearchCursor(fc, field) as cursor:
        for row in cursor:
            valueList.append(row[0])

    uniqueSet = set(valueList)
    uniqueList = list(uniqueSet)
    uniqueList.sort()

    del cursor

    count = 0
    name = uniqueList[count]
    outputname = r"C:\Users\Drew\Desktop\Montpelier\PythonTest\PythonGDB.gdb\"" + name
    if count < 34:
        arcpy.MakeFeatureLayer_management (r"C:\Users\Drew\Desktop\Montpelier\PythonTest\PythonGDB.gdb\dshline_Project", "layer")
        arcpy.SelectLayerByAttribute_management("layer","NEW_SELECTION", """Layer" = """ + name)

##        arcpy.SelectLayerByAttribute_management("dshline_Project","NEW_SELECTION",""""Layer" = 'ANNOT'""")

        arcpy.CopyFeatures_management(fc,outputname,"#","0","0","0")
        count += 1
    else:
        print "Done"

Please Help!

Vind meer berichten getagd met

Accepted answers

JakeSkinner

Try the following for the Select function:

arcpy.SelectLayerByAttribute_management("layer", "NEW_SELECTION", "Layer = '" + name + "'")

All comments

JakeSkinner

Try the following:

import arcpy, sys, os, traceback
from arcpy import env
env.workspace = r"C:\Users\Drew\Desktop\Montpelier\PythonTest\PythonGDB.gdb"
env.overwriteOutput = 1

fc = "dshline_Project"
field = ["Layer"]
valueList = []

#Use search cursor to aquire a list of unique values
with arcpy.da.SearchCursor(fc, field) as cursor:
    for row in cursor:
    valueList.append(row[0])

uniqueSet = set(valueList)
uniqueList = list(uniqueSet)
uniqueList.sort()

del cursor

count = 0
name = uniqueList[count]

if count < 34:
    outputname = env.workspace + os.sep + name
    arcpy.MakeFeatureLayer_management (fc, "layer")
    arcpy.SelectLayerByAttribute_management("layer", "NEW_SELECTION", "Layer = " + name)
    arcpy.CopyFeatures_management("layer", outputname)
    count += 1
    name = uniqueList[count]
else:
    print "Done"

StewartChritton

Thank you for your quick response.

I am still getting an error with the SelectLayerByAttribute:

ERROR 000358: Invalid expression
Failed to execute (SelectLayerByAttribute).

I feel like it has to be the following bolded part: arcpy.SelectLayerByAttribute_management("layer", "NEW_SELECTION", "Layer = " + name)

JakeSkinner

Try the following for the Select function:

arcpy.SelectLayerByAttribute_management("layer", "NEW_SELECTION", "Layer = '" + name + "'")

StewartChritton

Partial success!! It created the first file in the list successfully but didn't continue on to do the rest. Something wrong with the way i set up the loop perhaps?

Also just noticed that it doesn't print done in the end...

StewartChritton

I just changed the loop to a while loop.

    lencount = len(uniqueList)

    while count < lencount:

Now it is working but I get an error at the end:

Traceback info:
File "C:\Users\Drew\Desktop\Montpelier\PythonTest\ep2.py", line 41, in <module>
    name = uniqueList[count]

Error Info:
list index out of range

ArcPy ERRORS:

I think it keeps trying to go after the loop should close but it already accomplished what I needed so i guess that's fine!

Thanks a bunch for you fast replies!

JakeSkinner

Glad this is working. Can you mark this forum as answered? It will further help users in the community.

StewartChritton

Of course, I cannot find the button to mark it... one last bit of help please?

T__WayneWhitley

Yes, sloppy it is, and although it finishes maybe you still want to know why it's behaving that way?

It's because you make it through the loop on the last member of the list, then increment your index variable (i) and try to set your variable by looking up the value by index - the result is it does not exist because you have in fact exceeded the range, hence the 'out of range' error. The index of a list is zero-based, e.g., your list index with 33 members must advance in the loop from i = 0 to i = 32....in other words, 0 to 32 (including the 0) is 33.

I suppose the easiest fix is to modify how you enter the loop:

while count <= lencount - 1:
     # the rest of your code
     # so that 33 - 1 = 32, the upper index 0-based limit

Wayne

StewartChritton

Thanks! That makes perfect sense.

T__WayneWhitley

lol, I am sorry, I am mistaken...
Actually, you only need one 'name = uniqueList[count]' line and you can put that just after your loop begins, as such:

count = 0
while count < lencount:
     name = uniqueList[count]
     arcpy.SelectLayerByAttribute_management("layer", "NEW_SELECTION", "Layer = '" + name + "'")
     # etc., etc.
     count += 1

print 'done!'

...or, maybe simpler:

for count in range(lencount):
     name = uniqueList[count]
     arcpy.SelectLayerByAttribute_management("layer", "NEW_SELECTION", "Layer = '" + name + "'")
     # etc., etc.

print 'done!'

Sorry about that (and yes, 'while count <= lencount - 1' would work too).

Wayne

PS - Incidentally, you may end with a 'done!' statement outside of your loop, as shown.

StewartChritton

Thanks again, this time I actually put it in and tested it and everything ran smoothly.

Appreciate it.

T__WayneWhitley

I thank you Stewart, but I'm following up late, guess just for a little 'quality assurance' as this was something I have struggled with before too - you should credit Jake.

Have fun with Python!

Wayne

StewartChritton

Thought I could check both because you both contributed, didn't realize only one could receive credit haha.

Good on you for pointing that out and thanks again for that last bit of help.

Doe mee aan het gesprek

Aangemelde leden kunnen berichten plaatsen, updates volgen en meer. Nieuw hier? Registreer een gratis account.

Snelle Links

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.