nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Arcade en pop-ups, problemen met de functie Replace bij tekenreeksen van 1 teken

KateCarlson

Hoi — ik heb een eenvoudig Arcade-script geschreven om tekst in een veld te vervangen voor de pop-upweergave, maar ben tegen iets vreemds aangelopen.

Het script vervangt voor elk hydro-object in de laag de afgekorte naam van het type aantasting door de volledige naam.

var impParam = $feature["IMP_PARAM"];

impParam = Replace(impParam, 'FishesBio', 'Visbioassessments');
impParam = Replace(impParam, 'Hg-F', 'Kwik in visweefsel');
impParam = Replace(impParam, 'E.coli', 'Escherichia coli');
impParam = Replace(impParam, 'InvertBio', 'Bioassessments van aquatische macro-invertebraten');
impParam = Replace(impParam, 'TSS', 'Totale hoeveelheid zwevende stoffen');
impParam = Replace(impParam, 'T', 'Troebelheid');

return impParam;

Sommige objecten hebben meerdere vermelde aantastingen, bijvoorbeeld:

Het werkt prima, behalve dat de functie Replace tekenreeksen van 1 teken niet vervangt, zoals de 'T' door 'Troebelheid'. AGOL kan hier helemaal niet mee overweg en loopt vast, waardoor ik de pagina opnieuw moet laden. Weet iemand waarom ik een tekenreeks van 1 teken niet kan vervangen, of heeft iemand suggesties om het script te verbeteren?

Alvast hartelijk bedankt!

Kate

Vind meer berichten getagd met

Accepted answers

All comments

StephenM

I think the issue is that the replacement for 'T' has a 'T' in it, so it creates a sort of endless loop that freezes the page. The 'T' in other values like 'TSS' or 'Total Suspended solids' (depending on the order of the replace statements) will also be replaced, so that's something else to consider. Since Arcade expressions are case sensitive the lower case t's aren't affected.

You could do something like this:

var impParam <SPAN class="operator token">=</SPAN> $feature<SPAN class="punctuation token">[</SPAN><SPAN class="string token">"IMP_PARAM"</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">;</SPAN>

impParam <SPAN class="operator token">=</SPAN> <SPAN class="token function">Replace</SPAN><SPAN class="punctuation token">(</SPAN>impParam<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'T'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'turbidity'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
impParam <SPAN class="operator token">=</SPAN> <SPAN class="token function">Replace</SPAN><SPAN class="punctuation token">(</SPAN>impParam<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'FishesBio'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'Fishes bioassessments'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
impParam <SPAN class="operator token">=</SPAN> <SPAN class="token function">Replace</SPAN><SPAN class="punctuation token">(</SPAN>impParam<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'Hg-F'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'Mercury in fish tissue'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
impParam <SPAN class="operator token">=</SPAN> <SPAN class="token function">Replace</SPAN><SPAN class="punctuation token">(</SPAN>impParam<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'E.coli'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'Escherichia coli'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
impParam <SPAN class="operator token">=</SPAN> <SPAN class="token function">Replace</SPAN><SPAN class="punctuation token">(</SPAN>impParam<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'InvertBio'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'Aquatic macroinvertebrate bioassessments'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
impParam <SPAN class="operator token">=</SPAN> <SPAN class="token function">Replace</SPAN><SPAN class="punctuation token">(</SPAN>impParam<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'turbiditySS'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'Total Suspended solids'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
impParam <SPAN class="operator token">=</SPAN> <SPAN class="token function">Replace</SPAN><SPAN class="punctuation token">(</SPAN>impParam<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'turbidity'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'Turbidity'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

<SPAN class="keyword token">return</SPAN> impParam<SPAN class="punctuation token">;</SPAN>‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

KateCarlson

That's it!! Thank you, Stephen, for taking the time to explain along with an example solution.

Kate

XanderBakker

Although the solution provided by Stephen works in your specific case, you should be aware that Replace is not the correct function to solve this. Replace will find and replace any coincidence of the string that you are looking for which potentially may cause unexpected behavior. You actually have a list of values separated by a semicolon. What would be better (although it is more complex) is to test if any of the values in the list exactly matches the list of values that you have. See the example below:

<SPAN class="comment token">// var impParam = $feature["IMP_PARAM"];</SPAN>
<SPAN class="keyword token">var</SPAN> impParam <SPAN class="operator token">=</SPAN> <SPAN class="string token">"Test; E.coli; TSS; T; InvertBio; turbiditySS; turbidity; FishesBio; Hg-F"</SPAN><SPAN class="punctuation token">;</SPAN>

<SPAN class="keyword token">var</SPAN> dict <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">{</SPAN>
    <SPAN class="string token">'T'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'turbidity'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'FishesBio'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Fishes bioassessments'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'Hg-F'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Mercury in fish tissue'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'E.coli'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Escherichia coli'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'InvertBio'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Aquatic macroinvertebrate bioassessments'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'turbiditySS'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Total Suspended solids'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'turbidity'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Turbidity'</SPAN>
<SPAN class="punctuation token">}</SPAN>

<SPAN class="keyword token">var</SPAN> lst_in <SPAN class="operator token">=</SPAN> <SPAN class="token function">Split</SPAN><SPAN class="punctuation token">(</SPAN>impParam<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">';'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="keyword token">var</SPAN> lst_out <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="keyword token">for</SPAN> <SPAN class="punctuation token">(</SPAN><SPAN class="keyword token">var</SPAN> i <SPAN class="keyword token">in</SPAN> lst_in<SPAN class="punctuation token">)</SPAN> <SPAN class="punctuation token">{</SPAN>
    <SPAN class="keyword token">var</SPAN> item_in <SPAN class="operator token">=</SPAN> <SPAN class="token function">Trim</SPAN><SPAN class="punctuation token">(</SPAN>lst_in<SPAN class="punctuation token">[</SPAN>i<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
    <SPAN class="keyword token">var</SPAN> item_out <SPAN class="operator token">=</SPAN> item_in<SPAN class="punctuation token">;</SPAN>
    <SPAN class="keyword token">for</SPAN> <SPAN class="punctuation token">(</SPAN><SPAN class="keyword token">var</SPAN> search_txt <SPAN class="keyword token">in</SPAN> dict<SPAN class="punctuation token">)</SPAN> <SPAN class="punctuation token">{</SPAN>
        <SPAN class="keyword token">var</SPAN> replace_txt <SPAN class="operator token">=</SPAN> dict<SPAN class="punctuation token">[</SPAN>search_txt<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">;</SPAN>
        <SPAN class="keyword token">if</SPAN> <SPAN class="punctuation token">(</SPAN>item_in <SPAN class="operator token">==</SPAN> search_txt<SPAN class="punctuation token">)</SPAN> <SPAN class="punctuation token">{</SPAN>
            item_out <SPAN class="operator token">=</SPAN> replace_txt<SPAN class="punctuation token">;</SPAN>
        <SPAN class="punctuation token">}</SPAN>    
    <SPAN class="punctuation token">}</SPAN>
    lst_out<SPAN class="punctuation token">[</SPAN>i<SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">=</SPAN> item_out<SPAN class="punctuation token">;</SPAN>
<SPAN class="punctuation token">}</SPAN>

<SPAN class="keyword token">var</SPAN> result <SPAN class="operator token">=</SPAN> <SPAN class="token function">Concatenate</SPAN><SPAN class="punctuation token">(</SPAN>lst_out<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"; "</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="keyword token">return</SPAN> result<SPAN class="punctuation token">;</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

In this case I create a dictionary with search and replace values (lines 4 - 12). The code creates a list on line 14 and starts to loop through the items of the list and will validate any value in the dictionary and replace it by the desired one.

At the end (line 28) the items of new list are concatenated to create the output string.

KateCarlson

Xander-

Thanks for responding with a 'best practice' solution. You are right, the Replace function is working for my needs but I would rather use the more sophisticated method to ensure this is done right.

I copied and pasted your example script and it does work, but, it returns/replaces everything listed in the var impParam, even Test. Perhaps as a test, this is what it was supposed to do? Any recommendations for returning only the values for each record, such as 'Eschreichai coli; Turbidity' in the first record.

Thanks much-

Kate

Anonymous User

Xander - thanks for the great solution (and many others I've seen!).

I made a slight modification to use the HasKey dictionary method:

<SPAN class="keyword token">var</SPAN> impParam <SPAN class="operator token">=</SPAN> <SPAN class="string token">"Test; E.coli; TSS; T; InvertBio; turbiditySS; turbidity; FishesBio; Hg-F"</SPAN><SPAN class="punctuation token">;</SPAN>

<SPAN class="keyword token">var</SPAN> dict <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">{</SPAN>
    <SPAN class="string token">'T'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'turbidity'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'FishesBio'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Fishes bioassessments'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'Hg-F'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Mercury in fish tissue'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'E.coli'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Escherichia coli'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'InvertBio'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Aquatic macroinvertebrate bioassessments'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'turbiditySS'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Total Suspended solids'</SPAN><SPAN class="punctuation token">,</SPAN>
    <SPAN class="string token">'turbidity'</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="string token">'Turbidity'</SPAN>
<SPAN class="punctuation token">}</SPAN>

<SPAN class="keyword token">var</SPAN> lst_in <SPAN class="operator token">=</SPAN> <SPAN class="token function">Split</SPAN><SPAN class="punctuation token">(</SPAN>impParam<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">';'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="keyword token">var</SPAN> lst_out <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="keyword token">for</SPAN> <SPAN class="punctuation token">(</SPAN><SPAN class="keyword token">var</SPAN> i <SPAN class="keyword token">in</SPAN> lst_in<SPAN class="punctuation token">)</SPAN> <SPAN class="punctuation token">{</SPAN>
    <SPAN class="keyword token">var</SPAN> item_in <SPAN class="operator token">=</SPAN> <SPAN class="token function">Trim</SPAN><SPAN class="punctuation token">(</SPAN>lst_in<SPAN class="punctuation token">[</SPAN>i<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
    <SPAN class="keyword token">var</SPAN> item_out <SPAN class="operator token">=</SPAN> item_in<SPAN class="punctuation token">;</SPAN>
    
    <SPAN class="keyword token">if</SPAN> <SPAN class="punctuation token">(</SPAN> <SPAN class="token function">HasKey</SPAN><SPAN class="punctuation token">(</SPAN>dict<SPAN class="punctuation token">,</SPAN> item_in<SPAN class="punctuation token">)</SPAN> <SPAN class="punctuation token">)</SPAN> <SPAN class="punctuation token">{</SPAN>
        item_out <SPAN class="operator token">=</SPAN> dict<SPAN class="punctuation token">[</SPAN>item_in<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">;</SPAN>    
    <SPAN class="punctuation token">}</SPAN> <SPAN class="comment token">// else - item_out still equals item_in</SPAN>
    
    lst_out<SPAN class="punctuation token">[</SPAN>i<SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">=</SPAN> item_out<SPAN class="punctuation token">;</SPAN>
<SPAN class="punctuation token">}</SPAN>

<SPAN class="keyword token">var</SPAN> result <SPAN class="operator token">=</SPAN> <SPAN class="token function">Concatenate</SPAN><SPAN class="punctuation token">(</SPAN>lst_out<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"; "</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="keyword token">return</SPAN> result<SPAN class="punctuation token">;</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Doe mee aan het gesprek

Aangemelde leden kunnen berichten plaatsen, updates volgen en meer. Nieuw hier? Registreer een gratis account.

Snelle Links

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.