questions on mountaineering weather app sample

troyfoster

@AndrewBladon made an excellent little sample app and turned it into an Esri blog post, https://www.esri.com/arcgis-blog/products/sdk-qt/developers/creating-app-to-identify-climbing-locations-using-weather-api/

With source code up on github, https://github.com/AndrewBladon/QtWeatherApp/tree/main

1. That lead to me looking at the documentation for identifyGraphicsOverlayAsync ( https://developers.arcgis.com/qt/cpp/api-reference/esri-arcgisruntime-geoview.html#identifyGraphicsOverlayAsync ) , The documentation does not seem to have any warnings to developers that they need to manage the memory in the QFuture functor.  Should it have the little "See also Returned QObjects Parenting." link to remind developers like the old identifyGraphicsOverlaysCompleted does?
2. How could this app be improved with:
   1. unit tests on the setters and getters logic
   2. integration tests to see how the interaction with the classes in the app with a running Esri map
   3. code coverage to see how much of the code is exercised by tests
   4. a continuous integration setup? 
      1. Mainly because in my day job we have our map app working and have "seen the light" on the usefulness of those processes.  But we have done it our way and I would like to see someone else's pattern for these processes.

LucasDanzinger

Hey Troy-

 

Thanks for the feedback. I've logged an enhancement for us to improve the doc.

 

Regarding the other points of improving the app, those are all great ideas. I'll pass those onto Andy as a possible future blog ideas.

 

-Lucas