I have a function that calls another (static) function which returns a list of features: private Feature GetNextFeature ( FeatureLayer featLayer , MapPoint point ) { await QueuedTask . Run ( ( ) = > { var featList = Utils . GetFeaturesThatIntersectPoint ( point , featLayer ) ; // Do some more with the feature list . . . . } ) ; } public static List Feature > GetFeaturesThatIntersectPoint ( MapPoint point , FeatureLayer featLayer ) { List Feature > featList = new List Feature > ( ) ; // Create spatial query filter SpatialQueryFilter spatialFilter = new SpatialQueryFilter ( ) { FilterGeometry = point , SpatialRelationship = SpatialRelationship . Intersects , } ; // Query the feature layer using ( RowCursor rowCursor = featLayer . Search ( spatialFilter ) ) { while ( rowCursor . MoveNext ( ) ) { Row row = rowCursor . Current ; featList . Add ( ( Feature ) row ) ; } } return featList ; } In the method "GetFeaturesThatIntersectPoint", the feature list is correct. However, in the calling function "GetNextFeature", the features in the list are not the same any more. What am I doing wrong? As a workaround, I don't return a list of features, but a list of oids (of the features). This list is correct.

nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Incorrect list of features in calling function

BarbaraSchneider2

I have a function that calls another (static) function which returns a list of features:

<SPAN class="keyword token">private</SPAN> Feature <SPAN class="token function">GetNextFeature</SPAN><SPAN class="punctuation token">(</SPAN>FeatureLayer featLayer<SPAN class="punctuation token">,</SPAN> MapPoint point<SPAN class="punctuation token">)</SPAN>
<SPAN class="punctuation token">{</SPAN>
    <SPAN class="keyword token">await</SPAN> QueuedTask<SPAN class="punctuation token">.</SPAN><SPAN class="token function">Run</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN> <SPAN class="operator token">=</SPAN><SPAN class="operator token">></SPAN>
    <SPAN class="punctuation token">{</SPAN>
        <SPAN class="keyword token">var</SPAN> featList <SPAN class="operator token">=</SPAN> Utils<SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetFeaturesThatIntersectPoint</SPAN><SPAN class="punctuation token">(</SPAN>point<SPAN class="punctuation token">,</SPAN> featLayer<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>‍

        <SPAN class="comment token">// Do some more with the feature list</SPAN>
        <SPAN class="punctuation token">.</SPAN><SPAN class="punctuation token">.</SPAN><SPAN class="punctuation token">.</SPAN><SPAN class="punctuation token">.</SPAN>
    <SPAN class="punctuation token">}</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>‍‍‍‍‍‍‍
<SPAN class="punctuation token">}</SPAN>‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

<SPAN class="keyword token">public</SPAN> <SPAN class="keyword token">static</SPAN> List<SPAN class="operator token"><</SPAN>Feature<SPAN class="operator token">></SPAN> <SPAN class="token function">GetFeaturesThatIntersectPoint</SPAN><SPAN class="punctuation token">(</SPAN>MapPoint point<SPAN class="punctuation token">,</SPAN> FeatureLayer featLayer<SPAN class="punctuation token">)</SPAN>
<SPAN class="punctuation token">{</SPAN>
    List<SPAN class="operator token"><</SPAN>Feature<SPAN class="operator token">></SPAN> featList <SPAN class="operator token">=</SPAN> <SPAN class="keyword token">new</SPAN> <SPAN class="token class-name">List</SPAN><SPAN class="operator token"><</SPAN>Feature<SPAN class="operator token">></SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

    <SPAN class="comment token">// Create spatial query filter</SPAN>
    SpatialQueryFilter spatialFilter <SPAN class="operator token">=</SPAN> <SPAN class="keyword token">new</SPAN> <SPAN class="token class-name">SpatialQueryFilter</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>
    <SPAN class="punctuation token">{</SPAN>                
        FilterGeometry <SPAN class="operator token">=</SPAN> point<SPAN class="punctuation token">,</SPAN>
        SpatialRelationship <SPAN class="operator token">=</SPAN> SpatialRelationship<SPAN class="punctuation token">.</SPAN>Intersects<SPAN class="punctuation token">,</SPAN>
    <SPAN class="punctuation token">}</SPAN><SPAN class="punctuation token">;</SPAN>
    <SPAN class="comment token">// Query the feature layer</SPAN>
    <SPAN class="keyword token">using</SPAN> <SPAN class="punctuation token">(</SPAN>RowCursor rowCursor <SPAN class="operator token">=</SPAN> featLayer<SPAN class="punctuation token">.</SPAN><SPAN class="token function">Search</SPAN><SPAN class="punctuation token">(</SPAN>spatialFilter<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN>
    <SPAN class="punctuation token">{</SPAN>
        <SPAN class="keyword token">while</SPAN> <SPAN class="punctuation token">(</SPAN>rowCursor<SPAN class="punctuation token">.</SPAN><SPAN class="token function">MoveNext</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN>
        <SPAN class="punctuation token">{</SPAN>
            Row row <SPAN class="operator token">=</SPAN> rowCursor<SPAN class="punctuation token">.</SPAN>Current<SPAN class="punctuation token">;</SPAN>
            featList<SPAN class="punctuation token">.</SPAN><SPAN class="token function">Add</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">(</SPAN>Feature<SPAN class="punctuation token">)</SPAN>row<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
        <SPAN class="punctuation token">}</SPAN>
    <SPAN class="punctuation token">}</SPAN>
    <SPAN class="keyword token">return</SPAN> featList<SPAN class="punctuation token">;</SPAN>
<SPAN class="punctuation token">}</SPAN>‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

In the method "GetFeaturesThatIntersectPoint", the feature list is correct. However, in the calling function "GetNextFeature", the features in the list are not the same any more. What am I doing wrong?

As a workaround, I don't return a list of features, but a list of oids (of the features). This list is correct.

タグ付けされた投稿をもっと見る

Accepted answers

RichRuh

Hi Barbara,

By default, the FeatureClass.Search() method uses what is called a recycling cursor. Recycling cursors will reuse the same Feature object every time MoveNext is called. Obviously that isn't what you want here.

Change this line:

using (RowCursor rowCursor = featLayer.Search(spatialFilter))<SPAN class="line-numbers-rows"><SPAN>‍</SPAN></SPAN>

To this line:

<SPAN class="keyword token">using</SPAN> <SPAN class="punctuation token">(</SPAN>RowCursor rowCursor <SPAN class="operator token">=</SPAN> featLayer<SPAN class="punctuation token">.</SPAN><SPAN class="token function">Search</SPAN><SPAN class="punctuation token">(</SPAN>spatialFilter<SPAN class="punctuation token">,</SPAN> <SPAN class="keyword token">false</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN></SPAN>

I hope this helps,

--Rich

All comments

David_Lindsey

Hey Rich, I'm super late to this party but was hitting a similar snag as Barbara here. I deal with quite a few layers in Pro that are created from selections of a feature class. Searching the Feature Class allows me to define useRecyclingCursor true/false. However, a Feature Class search will iterate the entire feature class table. I'd like to just perform a search on the feature layer (created from a table selection). The search option with feature layers is limited and won't allow me to set a recycling cursor. This is causing the output to repeat and not be unique values. Barbara's workaround may work, but that is not a desirable workflow. Is there no convenient, native way to search a Feature Layer similarly to how a Feature Class is searched?

Interestingly enough, I'm allowed to use the useRecyclingCursor during a Select().Search() instead. I've used featureLayer.Select().Search(null, useReyclingCursor: false) with more desireable outcomes, but it will also select all of the features within Pro. I immediately have to utilize featureLayer.ClearSelection() to undo that afterwards. My choices for feature layer search just seem...surprisingly clunky. Any better ideas are welcomed!

RichRuh

Yes, that should work. Sorry, I didn't notice you were searching from the layer rather than the feature class.

--Rich

BarbaraSchneider2

I could also search the feature class instead of the layer and add the layer's definition query to the SpatialQueryFilter:

SpatialQueryFilter spQueryFilter <SPAN class="operator token">=</SPAN> <SPAN class="keyword token">new</SPAN> <SPAN class="token class-name">SpatialQueryFilter</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>
<SPAN class="punctuation token">{</SPAN>
    WhereClause <SPAN class="operator token">=</SPAN> featLayer<SPAN class="punctuation token">.</SPAN>DefinitionQuery<SPAN class="punctuation token">,</SPAN>
    FilterGeometry <SPAN class="operator token">=</SPAN> point<SPAN class="punctuation token">,</SPAN>
    SpatialRelationship <SPAN class="operator token">=</SPAN> SpatialRelationship<SPAN class="punctuation token">.</SPAN>Intersects<SPAN class="punctuation token">,</SPAN>
<SPAN class="punctuation token">}</SPAN><SPAN class="punctuation token">;</SPAN>‍‍‍‍‍‍
<SPAN class="keyword token">using</SPAN> <SPAN class="punctuation token">(</SPAN>RowCursor rowCursor <SPAN class="operator token">=</SPAN> featLayer<SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetFeatureClass</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">.</SPAN><SPAN class="token function">Search</SPAN><SPAN class="punctuation token">(</SPAN>spQueryFilter<SPAN class="punctuation token">,</SPAN><SPAN class="keyword token">false</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN>‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

BarbaraSchneider2

Hi Rich,

this makes sense, thank you. However, the Search method on the feature layer doesn't have a parameter for the recycling option, only the Search method on the feature class. I have to search the feature layer because I take into consideration its definition query.

Is there a way to search the feature layer with the recycling option set to false? I guess I just have to use the workaround I've described above.

Barbara

RichRuh

Hi Barbara,

Change this line:

using (RowCursor rowCursor = featLayer.Search(spatialFilter))<SPAN class="line-numbers-rows"><SPAN>‍</SPAN></SPAN>

To this line:

<SPAN class="keyword token">using</SPAN> <SPAN class="punctuation token">(</SPAN>RowCursor rowCursor <SPAN class="operator token">=</SPAN> featLayer<SPAN class="punctuation token">.</SPAN><SPAN class="token function">Search</SPAN><SPAN class="punctuation token">(</SPAN>spatialFilter<SPAN class="punctuation token">,</SPAN> <SPAN class="keyword token">false</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN></SPAN>

I hope this helps,

--Rich

会話に参加する

サインインしたメンバーは投稿、更新のフォローなどができます。初めてですか？無料アカウントを登録してください。

クイックリンク

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.