nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

About Editor_EditCompleted ...

MarcoRosa

Hi to all,
i'm using the editor tool and Editor_EditCompleted event: after selection this event it's fired 2 times , the first time e.Action value is "Select" , the second time the value is "Cancel".
It's correct this behaviour ?

Thank u very much
GP

タグ付けされた投稿をもっと見る

Accepted answers

All comments

MarcoRosa

Thank u for suggest , i let u know 🙂
have nice weekend
Bye G

JenniferNery

A possible workaround is to subscribe to FeatureLayer.PropertyChanged event. SelectedGraphics or SelectionCount are two properties that will be raised when graphic.Selected property changes. The sender of this event is the FeatureLayer that contained the graphic that was deleted by Editor.Select.

Unfortunately, I don't have information on the next release. v2.2 is still in beta state and we'd like to encourage our users to participate in the beta community. The bug fix for this was put in post-beta.

MarcoRosa

Hi Jennifer , thank u for all .. i hope your team will fix this bug. I tried to use editor.Select.Execute("Keyboard") ... Good , for the edit_completed event the behaviour is the same than previous method.

Anyway ... When your dev. team think to released the next final release of silverlight api ?

Thank u , see u

ciaso Giorgio

JenniferNery

Ah! The difference is that your FeatureLayer.Mode is SelectionOnly, which means selection can cause features to be added to and/or removed from your layer. In this case, once you remove the graphic from your selection, it is no longer associated to your layer - this is why edit.Layer is null. I will check with our Dev Lead if this is something we need to update.

Thanks for sharing this to us. If I may comment on your code, KeyDown event will fire continuously, which means editor.Select.Execute("Remove") will be called a bunch of times until you let go of Ctrl key. If you choose to use Keyboard. Remove your KeyDown eventhandler and on StartSelection_Click, use editor.Select.Execute("Keyboard") instead.

EDIT: Thank you for reporting this bug: EditCompleted event should still report the affected layer. We'll try to get it fixed in future releases.

MarcoRosa

forgot attach

MainPage.xaml.zip

MarcoRosa

Hi Jennifer , i saw your code ... there's a little differences between mine and your code.
I don't use Graphics layer , but only feature layers on which simulate the objects selection.
My case is like this esri sample:

http://help.arcgis.com/en/webapi/silverlight/samples/start.htm#FeatureLayerSelection

I verified inside this code the behaviour of edit_completed events and happens the same thing.
edit.Layer in the Remove session is null , u can verify that using the pages i've attached to u.
This is a strange behaviour , bacause if u have more than one feature layer on map u cannot know from which layer u are removing objects.

Please Try the code attached to u and let me know.
Thanks as usual ciao Giorgio

JenniferNery

What version of the API are you using? I have tested the attached sample with v2.1 Final. Kindly try the sample.

To describe the sample project:
It uses Editor.Add and Editor.Select. When Add completes, I assign the graphic some attribute so I can display it's information when Select completes. This should demonstrate that I am able to get both the graphic and layer from Editor.EditCompleted event.

I could not reproduce the issue when edit.Layer is null. Please send me steps to reproduce the issue using this sample. Thanks!

SelectionTest.zip

MarcoRosa

HI Jennifer,
tried your suggest:

when i try to remove from selection il loop i have the same behaviour :
i'm passing from selection = true to selection = false ... then edit.Graphic.Selected in this moment is true.
In the same moment edit.Layer is null.

Thank u again ....

private void Editor_EditCompleted(object sender, Editor.EditEventArgs e)
{
System.Diagnostics.Debug.WriteLine(e.Action);
foreach (var edit in e.Edits)
{
if (edit.Graphic.Selected)
System.Diagnostics.Debug.WriteLine("{0}-{1}", edit.Graphic.Attributes["ObjectID"], edit.Layer.ID);
}
}

If it is false, it must be caused by New Selection or Remove from Selection.
If you placed the following in Editor.EditCompleted event handler:

JenniferNery

Kindly look at Remove from Selection button in this sample:http://help.arcgis.com/en/webapi/silverlight/samples/start.htm#EditToolsExplicitSave

This is how you set up the Button It inherits its container's DataContext="{StaticResource MyEditor}"

 <Button x:Name="RemoveSelectButton" Margin="2"                             
                            Command="{Binding Select}"
                            CommandParameter="Remove" >

If you use the code above, you will not need to execute the command in code-behind.

The code-behind equivalent, should you choose to not use the code above is:

if(editor.Select.CanExecute("Remove")) editor.Select.Execute("Remove");

I can see where the confusion is now. The command used by new selection, add to selection and remove from selection is the same - Select. This is the same EditAction. When you iterate through the graphics, you can check for edit.Graphic.Selected property. If it is false, it must be caused by New Selection or Remove from Selection.
If you placed the following in Editor.EditCompleted event handler:

private void Editor_EditCompleted(object sender, Editor.EditEventArgs e)
{
 System.Diagnostics.Debug.WriteLine(e.Action);
 foreach (var edit in e.Edits)
 {
  if (edit.Graphic.Selected)
   System.Diagnostics.Debug.WriteLine("{0}-{1}", edit.Graphic.Attributes["ObjectID"], edit.Layer.ID);
 }
}

MarcoRosa

Hi Jennifer,
iìve tried your code: maybe i wasn't able to explain u my request.
Let me try to explain u better:

What i want to do is NOT the delete selected polygon , simple the deselect the polygon selected.
I try to write u the steps :

1) Put 2 feature layers ( L1 and L2 ) on map. (i have set the editor by code).
2) Press a button to start selection session:

       private void Button_Click(object sender, RoutedEventArgs e)
        {
                _editor = new Editor();
                _editor.Map = MyMap;
                _editor.SelectionMode = DrawMode.Point;
                _editor.Select.Execute("New");
                _editor.ContinuousMode = true;
                _editor.EditCompleted += new EventHandler<Editor.EditEventArgs>(Editor_EditCompleted);
        }

3) by clicking on the map i can select features on both layers L1 & L2 and obtain information about layers i'm working through the Editor_EditCompleted.

In the Editor_EditCompleted event i can understand on which layer i'm working because the properties e.Edits it's never null , and all it's ok.

4) Now i want to add selected polygons to current selection: i do that with keyboards in this way:
Press shif , click on map and new selected features are added

        void MainPage_KeyDown(object sender, KeyEventArgs e)
        {
            if (_editor == null) return;
            if (e.Key == Key.Ctrl)
                _editor.Select.Execute("Remove");
            else if (e.Key == Key.Shift)
                _editor.Select.Execute("Add");
            else if (e.Key == Key.Escape)
                _editor.CancelActive.Execute(null);
        }

.... and all it's ok

5) Now ( this is the trouble case ) i would like to deselect some objects from existing selection.
..Press ctrl and click on map.
The features are correctly deselected , but now the question is:

If i check the e.edits value in Editor_EditCompleted, i have this value null.
This means that i'm not be able to understand on which layer the selected object are deselected.

Let me know if i was clear in my explanation

Ciao Giorgio

when i click on map i can salect a poligon on each layer. I would like to understand on which layer im' working against not when i select a poligon but when i deselecte objects from one of 2 layer.
Infact, the e.edits return a Layer not null when i add the selection , null when i remove the selection.

JenniferNery

In code-behind it is:

if(_editor.DeleteSelected.CanExecute(null))
     _editor.DeleteSelected.Execute(null);

MarcoRosa

ok , with behind code this means to use

_editor.Select.Execute("DeleteSelected");

insead of

_editor.Select.Execute("Remove");

? Thanks

JenniferNery

You need to iterate through the edits and look at edit.Graphic and edit.Layer.

private void MyEditor_EditCompleted(object sender, Editor.EditEventArgs e)
{
 if (e.Action == Editor.EditAction.DeleteSelected)
 {
  foreach (var edit in e.Edits)
  {
   //deleted graphic is edit.Graphic 
   //TODO: use edit.Layer
  }
 }
}

MarcoRosa

Hi jennifer , understand the topic for the selection ... but i've the second problem to solve.

I try to explain u:

I have 2 feature layers on map. (i have set the editor by code .... add and remove tools).
when i click on map i can salect a poligon on each layer. I would like to understand on which layer im' working against not when i select a poligon but when i remove the selected objects from one of 2 layer.
Infact, the e.edits return a Layer not null when i add the selection , null when i remove the selection.

I'm trying a work around to solve this now , if u have any suggest for me .. thank u
Giorgio

AndyWright

Ok, thanks Jennifer. I'll start replying to you directly through the bug reports forum.

JenniferNery

I actually don't have access to that e-mail but it was posted again as comment in the bug reports section so I was able to reply to it there.

AndyWright

Jennifer,

I'm not sure if you got my e-mail reply to you yesterday or not, so I'll post it here as well. Here's your e-mail ...

Kindly check your DrawToolsViewModel.cs SetTool() method. This method whenever called subscribes to Editor.EditCompleted. This is the reason you get Select and Cancel action for every graphic that was added.

What you can do is use a read-only DrawEditor property with _drawEditor initially set to null. This will ensure that you set Editor properties and subscribe to EditCompleted events once. Instead of using _drawEditor to activate Select/Cancel/EditVertices, use DrawEditor instead.

private Editor DrawEditor
{
get
{
if (_drawEditor == null)
{
_drawEditor = new Editor();
_drawEditor.LayerIDs = new List { DrawToolsGraphicsLayer.ID };
_drawEditor.GeometryServiceUrl = "http://sampleserver3.arcgisonline.com/ArcGIS/rest/services/Geometry/GeometryServer";
_drawEditor.ContinuousMode = true;
_drawEditor.EditCompleted += new EventHandler(_drawEditor_EditCompleted);
}
return _drawEditor;
}
}

And here's my reply:

The EditCompleted event only ever gets subscribed to once. I have all of that stuff enclosed in an if statement. The LayerIDs property is only null the first time through. Once that gets set I can call SetTool thousands of times and the code within this if construct will never run.

if (_drawEditor.LayerIDs == null)
            {
                _drawEditor.LayerIDs = new List<string> { DrawToolsGraphicsLayer.ID };
                _drawEditor.GeometryServiceUrl = "http://sampleserver3.arcgisonline.com/ArcGIS/rest/services/Geometry/GeometryServer";
                _drawEditor.ContinuousMode = true;
                _drawEditor.SelectionMode = DrawMode.Point;
                _drawEditor.EditCompleted += new EventHandler<Editor.EditEventArgs>(_drawEditor_EditCompleted);
            }

I tried your suggestion anyway and it didn�??t fix the problem. If you create three points on the map, put a breakpoint in the _drawEditor_EditCompleted method, then use the select tool to individually select each point you�??ll see that the Select action gets fired multiple times.

MarcoRosa

thks jennifer , i'll try and let y know
Giorgio

JenniferNery

Kindly check your DrawToolsViewModel.cs SetTool() method. This method whenever called subscribes to Editor.EditCompleted. This is the reason you get Select and Cancel action for every graphic that was added.

What you can do is use a read-only DrawEditor property with _drawEditor initially set to null. This will ensure that you set Editor properties and subscribe to EditCompleted events once. Instead of using _drawEditor to activate Select/Cancel/EditVertices, use DrawEditor instead.

private Editor DrawEditor
{
 get
 {
  if (_drawEditor == null)
  {
   _drawEditor = new Editor();
   _drawEditor.LayerIDs = new List<string> { DrawToolsGraphicsLayer.ID };
   _drawEditor.GeometryServiceUrl = "http://sampleserver3.arcgisonline.com/ArcGIS/rest/services/Geometry/GeometryServer";
   _drawEditor.ContinuousMode = true;
   _drawEditor.EditCompleted += new EventHandler<Editor.EditEventArgs>(_drawEditor_EditCompleted);
  }
  return _drawEditor;
 }
}

JenniferNery

Oh okay I see it now. Thanks!

AndyWright

Jennifer,

Here's a link that will get you to the bugs that have been submitted for the 2.2 API. Mine is BUG-000011.

https://betacommunity.esri.com/project/feedback/track/list.html?cap=16C1D9C4623345308F10F0687AC949E6&f={225DDC30-A35E-466A-9F6C-E0A368D88F4A}&vfid=1763CC5CF2204C4B88E841A777343E5F&pr=0&bnmsg=&bnmsgu=true

I do have ContinuousMode set to true, but I never see the cancel action come through the pipeline. It is always multiple select actions for me.

JenniferNery

Giorgio,

When Editor.ContinuousMode=True it is expected to get edit.Action=Cancel because the current command is activated again. For example you select features from layer 1,2,3. EditCompleted event will report edit.Action=Select with selections from 1,2,3 first and then followed by edit.Action=Cancel.

So if you update the code-behind in post# 6 with the following, you will notice that after selection in all layers are made, a Cancel is reported.

private void Editor_EditCompleted(object sender, ESRI.ArcGIS.Client.Editor.EditEventArgs e)
{
 System.Diagnostics.Debug.WriteLine(e.Action);
 foreach (var edit in e.Edits)
  System.Diagnostics.Debug.WriteLine("id '{0}', layer '{1}'", edit.Graphic.Attributes["objectid"], edit.Layer.ID);
}

You access the layer similar way when DeleteSelected is executed.

FeatureLayer layer = edit.Layer as FeatureLayer;

Try the following XAML-code to add DeleteSelected:

<StackPanel DataContext="{StaticResource MyEditor}"  VerticalAlignment="Top" HorizontalAlignment="Center" Orientation="Horizontal">
 <Button Content="Select" Command="{Binding Select}" />
 <Button Content="Delete" Command="{Binding DeleteSelected}" />
</StackPanel>

Andy,

I have access to API v2.2 Beta Community as well but I do not find your code posted in there. Can you provide a link?

In your code, do you have Editor.ContinuousMode=True as well and is what I described above what you're seeing too?

I understand your project can be quite large, but we only need XAML and cs files. It would be ideal if you can give us only the code that will reproduce the issue.

Thanks!

AndyWright

Jennifer,

I've done everything you said, my zip file is 1.3MB in size, and I still can't upload it to your site. There are too many files in the project to copy-paste stuff up here. Can I send it to you in an e-mail?

I've also reported this as a bug to the Silverlight Beta team and uploaded a copy of my project there. Maybe you can get it from them. It's BUG-000011. I know that I also had ContinuousMode set to True in my project, so gporta is obviously on to something there.

Let me know what you think Jennifer. Thanks ...

Andy

MarcoRosa

Hi jennifer, iìve tried your code. here the results:

1) i've verified thah your code fire only one time the event on select

2) i've a little difference in my code, i've set the the ContinuousMode="True". I've verified that parameter is the reason for the event to fires 2 times. U can try this.

So , this at point 2) is also good for me, with a work around e've solved my problem, the only think i have to solve now is the following:

i have 2 feature layers on map. i have also set the editor by code .... add and remove tools.
when i click on map i can salect a poligon on each layer. I would like to understand on which layer im' working against not when i select a poligon but when i remove the selected objects from one of 2 layer.
Infact, the e.edits return a Layer not null when i add the selection , null when i remove the selection.

Hope to be my explanation good.
Thanks again

GP

JenniferNery

Hi Andy. I'd be glad to look at your code. Please try to strip it down so you may copy-paste or attach only the important parts (i.e. Editor, Layer definition -in XAML/code-behind). Have you tried the code-snippet in post# 5? Would you be able to tell me what other settings I need to add to my FeatureLayer or Editor to be able to reproduce the issue? Also, try to clean the solution if you want to attach it in a zipped file (I think just the code files is sufficient). Thank you for trying out our beta. I would really like to get this resolved if we can figure out what's wrong.

AndyWright

I'm using the 2.2 beta version of the API and I'm seeing very similar behavior, except the Select action value fires 1, 2, or 3 times. The Cancel action never fires. I haven't picked up on the pattern yet, so it seems to be somewhat arbitrary to me. What is even more interesting is that I draw three graphics on the map - a square, a circle, and a diamond. On the select event I check to see what the symbol is on the selected graphic and every once in a while it will be one step behind. For example, I select the circle first and it reports circle, then I select the square and it reports square, then I select the diamond and it reports square, then I select the circle and it reports diamond. Very weird. This happens consistently though.

I'm not quite sure what is going on, but it makes it next to impossible to do anything useful with the selected graphic since you're never quite sure which one it is going to be. I even tried tying into the PropertyChanged event on my graphics layer and reacting to a change in the SelectedGraphics property. The same thing happens there.

Jennifer, I'm still not able to upload a zip file less than 2 MB for some reason. Can I e-mail you the zip file containing my DOTNET project? I think it's very important for you or someone on your side to see this behavior as you haven't been able to replicate it yet.

JenniferNery

Hi.

I have the following test. Please try it out and let me know how I could reproduce the issue you are experiencing.
XAML-code:

    xmlns:esri="http://schemas.esri.com/arcgis/client/2009">

 <Grid x:Name="LayoutRoot" Background="White" >
  <Grid.Resources>
   <esri:Editor x:Key="MyEditor" EditCompleted="Editor_EditCompleted" Map="{Binding ElementName=MyMap}"/>
  </Grid.Resources>
  <esri:Map x:Name="MyMap" Extent="-63043237.1870117,-29260415.7409668,36029344.3774414,36661048.8306274">
   <esri:FeatureLayer ID="Point" Url="http://sampleserver3.arcgisonline.com/ArcGIS/rest/services/HomelandSecurity/operations/FeatureServer/0" />
   <esri:FeatureLayer ID="Line" Url="http://sampleserver3.arcgisonline.com/ArcGIS/rest/services/HomelandSecurity/operations/FeatureServer/1"/>
   <esri:FeatureLayer ID="Area" Url="http://sampleserver3.arcgisonline.com/ArcGIS/rest/services/HomelandSecurity/operations/FeatureServer/2"/>
  </esri:Map>
  <Button DataContext="{StaticResource MyEditor}" Content="Select" Command="{Binding Select}" VerticalAlignment="Top" HorizontalAlignment="Center"/>
 </Grid>

Here, all I'm doing is printing to my Output Window the e.Action. Running this test against v2.1 Final. I only see Select printed in my Output Window.
Code-behind:

private void Editor_EditCompleted(object sender, ESRI.ArcGIS.Client.Editor.EditEventArgs e)
{
 System.Diagnostics.Debug.WriteLine(e.Action);
}

MarcoRosa

Hi jennifer , sorry per very late in my response, i've tried the same code witj api 2.0 and api 2.1.
Looks like correct behaviour with the old api version 2.0 In this case i've the editcompleted_event fired once when i select an object on feature layer, with the 2.1 api the same code fires twice the editcompleted event ... first time with e.Action = select second time e.Action = Cancel

It's correct that ?
thanks again GP

JenniferNery

I cannot replicate the issue with v2.1 and up.
When I make a selection on multiple layers using Editor.Select. Editor.EditCompleted event is fired once for EditAction.Select, regardless if my selection includes features from both layers. I confirmed this using the following code:

private void Editor_EditCompleted(object sender, Editor.EditEventArgs e)
{
 if (e.Action == Editor.EditAction.Select)
  foreach (var edit in e.Edits)
   System.Diagnostics.Debug.WriteLine(edit.Layer.ID);
}

And it my Output window, I see both layer IDs. I also placed a breakpoint on EditCompleted to see if I'll hit it for an EditAction.Cancel, but I didn't.

What version of the API are you using? You are noticing that EditAction.Cancel is fired after Editor.EditAction.Select when you have more than one layer?

MarcoRosa

Hi Jennifer , i verified that event Editor_EditCompleted is fired only one time if u have just one layer on
LayerIDs properties but not if u have 2 for example:

If u have 2 feature layers like following ( my ) case :

<esri:Editor x:Key="MyEditor" Map="{Binding ElementName=MyMap}" LayerIDs="Zone,Comuni"
SelectionMode="Point" ContinuousMode="True" EditCompleted="Editor_EditCompleted" />

In particular the events it's fired 2 times for first layer , one time for second (not in the same order).
I have used to test this a esri sample , no methods editor.CancelActive.Execute(null) in source code.

Now if have 3 layers ( LayerIDs="Zone,Zone2,Comuni" ) i observer that the event it's fired 3 times for one of 3 layers , 2 times for the second e 1 time for the last. (not always in the same order).

I dont' understand why it's appens

Thank's GP

会話に参加する

サインインしたメンバーは投稿、更新のフォローなどができます。初めてですか？無料アカウントを登録してください。

クイックリンク

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.