I have a script that is looping through many txt files and adding them to a feature class. I want to tally the total number of records added. I am trying to use a RecordCounter Variable to count the records....It DOES work to some degree...it count the first txt file that is being processed but if I process 7 files it only gives me the number from the first txt file. Any thoughts? # .... SNIP else : # SEEING THERE ARE NO DUPS PROCEED WITH PROCESSING print "They are no dups so processing is continuing" #Read through each line of the csv, but skip the first row because it is the header #The count variable skips of the first row count = 0 RecordCounter = 0 for ln in open ( textFile , 'r' ) . readlines ( ) : if count > 0 : #Each line in the csv is a string, so turn it into a list so you can reference each column lineSplit = ln . split ( "," ) #Use index positions to get the right column from the csv #Make sure the data is the correct type (i.e. X and Y need to be numbers, not strings) CollarSeri = long ( lineSplit [ 0 ] ) Year = str ( lineSplit [ 1 ] ) Julianday = str ( lineSplit [ 2 ] ) #Insert the values from csv into feature class #The order of the fields here, matches the order of the fields in line 4 cursor . insertRow ( [ CollarSeri , Year , Julianday , Hour , Minute , Activity , Temperature , Latitude , Longitude , HDOP , NumSats , FixTime , Date , _2D_3D , BearID , getTime3 , getDateTime , FileName , shapeVal ] ) RecordCounter = RecordCounter + 1 count += 1 del cursor print RecordCounter # .... SNIP

nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Count Rows being processed with INSERT Cursor

jaykapalczynski

I have a script that is looping through many txt files and adding them to a feature class. I want to tally the total number of records added.

I am trying to use a RecordCounter Variable to count the records....It DOES work to some degree...it count the first txt file that is being processed but if I process 7 files it only gives me the number from the first txt file.

Any thoughts?

<SPAN class="comment token"># .... SNIP</SPAN>

<SPAN class="keyword token">else</SPAN><SPAN class="punctuation token">:</SPAN> <SPAN class="comment token"># SEEING THERE ARE NO DUPS PROCEED WITH PROCESSING</SPAN>
&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">print</SPAN> <SPAN class="string token">"They are no dups so processing is continuing"</SPAN>
&nbsp;&nbsp;&nbsp; <SPAN class="comment token">#Read through each line of the csv, but skip the first row because it is the header</SPAN>
&nbsp;&nbsp;&nbsp; <SPAN class="comment token">#The count variable skips of the first row</SPAN>
&nbsp;&nbsp;&nbsp; count <SPAN class="operator token">=</SPAN> <SPAN class="number token">0</SPAN>
&nbsp;&nbsp;&nbsp; RecordCounter <SPAN class="operator token">=</SPAN> <SPAN class="number token">0</SPAN>
&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">for</SPAN> ln <SPAN class="keyword token">in</SPAN> open <SPAN class="punctuation token">(</SPAN>textFile<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'r'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">.</SPAN>readlines<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>&nbsp; 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">if</SPAN> count <SPAN class="operator token">></SPAN> <SPAN class="number token">0</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token">#Each line in the csv is a string, so turn it into a list so you can reference each column</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; lineSplit <SPAN class="operator token">=</SPAN> ln<SPAN class="punctuation token">.</SPAN>split<SPAN class="punctuation token">(</SPAN><SPAN class="string token">","</SPAN><SPAN class="punctuation token">)</SPAN>

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token">#Use index positions to get the right column from the csv</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token">#Make sure the data is the correct type (i.e. X and Y need to be numbers, not strings)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; CollarSeri <SPAN class="operator token">=</SPAN> long<SPAN class="punctuation token">(</SPAN>lineSplit<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Year <SPAN class="operator token">=</SPAN> str<SPAN class="punctuation token">(</SPAN>lineSplit<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Julianday <SPAN class="operator token">=</SPAN> str<SPAN class="punctuation token">(</SPAN>lineSplit<SPAN class="punctuation token">[</SPAN><SPAN class="number token">2</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token">#Insert the values from csv into feature class</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token">#The order of the fields here, matches the order of the fields in line 4</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; cursor<SPAN class="punctuation token">.</SPAN>insertRow <SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">[</SPAN>CollarSeri<SPAN class="punctuation token">,</SPAN> Year<SPAN class="punctuation token">,</SPAN> Julianday<SPAN class="punctuation token">,</SPAN> Hour<SPAN class="punctuation token">,</SPAN> Minute<SPAN class="punctuation token">,</SPAN> Activity<SPAN class="punctuation token">,</SPAN> Temperature<SPAN class="punctuation token">,</SPAN> Latitude<SPAN class="punctuation token">,</SPAN> Longitude<SPAN class="punctuation token">,</SPAN> HDOP<SPAN class="punctuation token">,</SPAN> NumSats<SPAN class="punctuation token">,</SPAN> FixTime<SPAN class="punctuation token">,</SPAN> Date<SPAN class="punctuation token">,</SPAN> _2D_3D<SPAN class="punctuation token">,</SPAN> BearID<SPAN class="punctuation token">,</SPAN> getTime3<SPAN class="punctuation token">,</SPAN> getDateTime<SPAN class="punctuation token">,</SPAN> FileName<SPAN class="punctuation token">,</SPAN> shapeVal<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; RecordCounter <SPAN class="operator token">=</SPAN> RecordCounter <SPAN class="operator token">+</SPAN> <SPAN class="number token">1</SPAN>

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; count <SPAN class="operator token">+=</SPAN> <SPAN class="number token">1</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">del</SPAN> cursor
&nbsp;&nbsp;&nbsp;&nbsp; 
&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">print</SPAN> RecordCounter‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

<SPAN class="comment token"># .... SNIP‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

タグ付けされた投稿をもっと見る

Accepted answers

bixb0012

I suggest reading How to get line count cheaply in Python? if you haven't already. It provides high-performing options for counting file length as well as simple, more Pythonic ways of doing so.

All comments

ClintonDow1

Just a small nit to pick, but the actual question being asked isn't answered by his response and could be misleading to novice programmers. It asks how to count rows being processed with an insert cursor, not how to count the number of rows in a text file. These may not be equivalent if the rows are inserted conditionally.

DanPatterson_Retired

Joshua's answer was the correct one as you confirm... I have changed the correct answer to reflect this for future readers.

ClintonDow1

Since you are ultimately using an insert cursor, it may be simpler to have several functions: One function to read the lines out of the text file into a list and another function to loop through that list to insert to the feature class. Then as an intermediate step you can use Python's len() keyword to easily get the length of the list.

jaykapalczynski

your example shows how I am exactly doing it.....thanks

bixb0012

I suggest reading How to get line count cheaply in Python? if you haven't already. It provides high-performing options for counting file length as well as simple, more Pythonic ways of doing so.

blake.terhune

You can start the enumeration at 1 so you don't have to add one when you return i.

Pyhton enumerate()

python - How to enumerate a range of numbers starting at 1 - Stack Overflow

<SPAN class="keyword token">for</SPAN> i<SPAN class="punctuation token">,</SPAN> l <SPAN class="keyword token">in</SPAN> enumerate<SPAN class="punctuation token">(</SPAN>f<SPAN class="punctuation token">,</SPAN> <SPAN class="number token">1</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN></SPAN>

jaykapalczynski

I did it in another area...all set

<SPAN class="keyword token">def</SPAN> <SPAN class="token function">file_len</SPAN><SPAN class="punctuation token">(</SPAN>fname<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">with</SPAN> open<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"C:/Users/NewFiles/"</SPAN> <SPAN class="operator token">+</SPAN> fname<SPAN class="punctuation token">)</SPAN> <SPAN class="keyword token">as</SPAN> f<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">for</SPAN> i<SPAN class="punctuation token">,</SPAN> l <SPAN class="keyword token">in</SPAN> enumerate<SPAN class="punctuation token">(</SPAN>f<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">pass</SPAN>
&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">return</SPAN> i <SPAN class="operator token">+</SPAN> <SPAN class="number token">1</SPAN>

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">for</SPAN> file <SPAN class="keyword token">in</SPAN> os<SPAN class="punctuation token">.</SPAN>listdir<SPAN class="punctuation token">(</SPAN>dir_src<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token">#Get the number of records being processed calling function file_len below</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; testfile <SPAN class="operator token">=</SPAN> str<SPAN class="punctuation token">(</SPAN>file<SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; teststr <SPAN class="operator token">=</SPAN> file_len<SPAN class="punctuation token">(</SPAN>file<SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token"># Count how many Files are being processed.</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; FileCounter <SPAN class="operator token">=</SPAN> FileCounter <SPAN class="operator token">+</SPAN> <SPAN class="number token">1</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token"># Count the Records being processed each time</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; TotalRecords <SPAN class="operator token">=</SPAN> TotalRecords <SPAN class="operator token">+</SPAN> teststr

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token"># Remove the number of files from the total Records.&nbsp; This is because the program is counting the Header in the txt file.</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token"># if there are 7 files then we need to subtract 7 headers or the number in FileCounter variable.</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; TotalRecords1 <SPAN class="operator token">=</SPAN> TotalRecords <SPAN class="operator token">-</SPAN> FileCounter‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

会話に参加する

サインインしたメンバーは投稿、更新のフォローなどができます。初めてですか？無料アカウントを登録してください。

クイックリンク

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.