Dashboard Expression Performance Improvement Needed

Caitlin_Todd_LCOR

Hi all, 

I'm hoping this would be an easy Yes or No answer. Is there a way to rewrite this expression so performance speed could be improved? Currently it does run correctly, but takes 7-10min to finish. End result will be a count of failing inspections within high priority features in an Indicator widget in ArcGIS Dashboard.

 

Thanks!

Caitlin

// set portal variable and feature set of failing ramp inspections
var portals = portal('Some org url');
var mRamp = FeatureSetByPortalItem(portals, 'some item id',8,['PassFail','CalibrationDate','latitude','longitude','GlobalID'], true);
var sql =  `PassFail = 'Fail'`;
Var FailRamps = Filter(mRamp,sql);

//set feature sets of prox priorities
var Parks = FeatureSetByPortalItem(portals, 'some item id',4,['name','approx_acres','GlobalID','latitude','longitude'],true);
var GovFacility = FeatureSetByPortalItem(portals, 'some item id',8,['GlobalID','MAPTAXLOT','STATCLDES','AscendAcres'],true);
var PublicFacility = FeatureSetByPortalItem(portals, 'some item id',7,['GlobalID','MAPTAXLOT','STATCLDES','AscendAcres'],true);
var CareFacility = FeatureSetByPortalItem(portals, 'some item id',9,['GlobalID','MAPTAXLOT','STATCLDES','AscendAcres'],true);
var SchoolFacility = FeatureSetByPortalItem(portals, 'some item id',6,['GlobalID','MAPTAXLOT','STATCLDES','AscendAcres'],true);
var ZoningLayer = FeatureSetByPortalItem(portals, 'some item id',20,['ZONE_NAME','GlobalID'],true);

//add FailRamp feature to captured ramps counter when it is within 0.125 miles of a priority facility
var capturedRamps = 0;
for(var f in GovFacility){
  var govbuff = BufferGeodetic(f, 0.125, 'miles');
  If(Count(Intersects(FailRamps,govbuff))>0) {
    capturedRamps ++;
  }
}

for(var f in CareFacility){
  var carebuff = BufferGeodetic(f, 0.125, 'miles');
  If(Count(Intersects(FailRamps,carebuff))>0) {
    capturedRamps ++;
  }
}

for(var f in PublicFacility){
  var pubbuff = BufferGeodetic(f, 0.125, 'miles');
  If(Count(Intersects(FailRamps,pubbuff))>0) {
    capturedRamps++;
  }
}

for(var f in SchoolFacility){
  var schlbuff = BufferGeodetic(f, 0.125, 'miles');
  If(Count(Intersects(FailRamps,schlbuff))>0) {
    capturedRamps ++;
  }
}

for(var f in Parks){
  var parkbuff = BufferGeodetic(f, 0.125, 'miles');
  If(Count(Intersects(FailRamps,parkbuff))>0) {
    capturedRamps ++;
  }
}

for(var f in Zoninglayer){
  If(Count(Intersects(FailRamps,f))>0) {
    capturedRamps ++;
  }
}

return capturedRamps

 

JohannesLindner

Right, this was another question where Josh's very helpful blog post can help (for performance, not for your new problem).

 

To return a Featureset, you first have to define it (what fields and geometry type does it have?), and then you have to fill it.

Something like this should do the trick (Note the use of Memorize() for all loaded Featuresets, this should hopefully help with performance a lot.):

 

// function to load a Featureset into RAM
function Memorize(fs) {
    var temp_dict = {
        fields: Schema(fs)['fields'],
        geometryType: Schema(fs).geometryType,
        features: []
    }
    for (var f in fs) {
        var attrs = {}
        for (var attr in f) {
            attrs[attr] = Iif(TypeOf(f[attr]) == 'Date', Number(f[attr]), f[attr])
        }
        Push(
            temp_dict['features'],
            {attributes: attrs, geometry: Geometry(f)}
        )
    }
    return FeatureSet(Text(temp_dict))
}


// load your Featuresets
var portals = ...
var mRamp = Memorize(FeaturesetByPortalItem(...))
var sql = "PassFail = 'Fail'"
var FailRamps = Filter(mRamp, sql)

var PriorityFeaturesets = [
    Memorize(FeaturesetByPortalItem(...)),
    // ...
]

var zoningLayer = Memorize(FeaturesetByPortalItem(...))


// define the output featureset
var out_fs = {
    geometryType: "",
    fields: [
        {name: "GID", type: "esriFieldTypeString"},
    ],
    features: []
}

// fill the featureset with all ramps that are near priority features or wihtin the zoning layer
for(var ramp in FailRamps) {
    var zone = First(Intersects(zoningLayer, ramp))
    if(zone != null) {
        Push(out_fs.features, {attributes: {GID: ramp.GlobalID}})
        continue
    }
    var rampBuffer = Buffer(ramp, 0.125, "miles")
    for(var i in priorityFeaturesets) {
        var priorityFeature = First(Intersects(priorityFeatures[i], ramp_buffer))
        if(priorityFeature != null) {
            Push(out_fs.features, {attributes: {GID: ramp.GlobalID}})
            break
        }
    }
}

// return the output Featureset
return Featureset(Text(out_fs))

 

 

The way I wrote it, it should not count ramps that are near to multiple priority features multiple times. To be sure, you could just throw a Distinct() around the returned fs:

return Distinct(Featureset(Text(out_fs)), ["GID"])