nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

CancelEdit in OnRowChangeEvent not working

MKa

I am in the process of upgrading my users to the newest version of ArcGIS Pro 2.4.3 and testing my code. It appears that CancelEdit is not performing as expecting in the OnRowChangeEvent? It seems to work in OnRowDeleteEvent but not in OnRowChange?

<SPAN class="keyword token">else</SPAN> <SPAN class="keyword token">if</SPAN> <SPAN class="punctuation token">(</SPAN>ConditionTrue<SPAN class="punctuation token">)</SPAN> <SPAN class="comment token">//rollback</SPAN>
                        <SPAN class="punctuation token">{</SPAN>
                            <SPAN class="comment token">//CANCEL the Redraw Change</SPAN>
                            args<SPAN class="punctuation token">.</SPAN><SPAN class="token function">CancelEdit</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN> <SPAN class="operator token">=</SPAN><SPAN class="operator token">></SPAN> <SPAN class="token function">ChangeError</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Changes Not Allowed!"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"Parent Shape Cannot be changed"</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
                        <SPAN class="punctuation token">}</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

I also put in simply args.CancelEdit() and that failed too

Encuentra más publicaciones etiquetadas con

Accepted answers

Anonymous User

I would keep using the Inspector pattern outside of the row events as its just too convenient to use over the 'geodatabase' api within edit operations.

All comments

Anonymous User

Hi M,

I'll try and replicate the issue, how are you measuring the performance degradation?

MKa

It seems that I can get this to work using the Rows. But I have noticed now that anytime I use Insperctor in the Row events at all, it begins to seriously slow down ArcGIS Pro. If you simply load an Inspector in the Row event, after a couple of times the system will start to degrade. Is there something that is not getting "Cleaned Up" or "Disposed" of in the Row event when you want to load an inspector from the Row that was sent in?

Anonymous User

I would keep using the Inspector pattern outside of the row events as its just too convenient to use over the 'geodatabase' api within edit operations.

MKa

I was able to use the Row to detect if a CancelEdit had to be performed. Thank you for your help in this. Should I look into moving all of my inspector code to use Row instead? I build most of my program on the Inspector model, but maybe I should switch back to Row like we use to do with ArcObjects?

Anonymous User

I cant think of a workaround using the inspector. You would have to look into the core.data (geodatabase) api to get the same information.

MKa

can you think of any other work around where I can load the Inspector. I use the inspector in the row change to do a number of things and don't want to really change all my code if I don't have to? I load the inspector for this Row into an object that then has functions to ask and query information about the specific layer and related layers to the Row that is being edited and updated.

Anonymous User

Thanks! its easily reproducible in 2.4 with the inspector.load example.

The good news is its not reproducible in 2.5 or 2.6 because of the way the editor now works with feature services and the undo stack.

As a workaround if you dont need the inspector to do anything fancy with the returned row, you can alternately read/write values using the row index as shown below:

    <SPAN class="keyword token">private</SPAN> <SPAN class="keyword token">void</SPAN> <SPAN class="token function">onRowEvent</SPAN><SPAN class="punctuation token">(</SPAN>RowChangedEventArgs obj<SPAN class="punctuation token">)</SPAN>
    <SPAN class="punctuation token">{</SPAN>
      <SPAN class="comment token">//var testLyr = MapView.Active.Map.FindLayers("FireHydrants").First() as FeatureLayer;</SPAN>
      <SPAN class="comment token">//var insp = new Inspector();</SPAN>
      <SPAN class="comment token">//insp.Load(testLyr, obj.Row.GetObjectID());</SPAN>

      <SPAN class="comment token">//get a row value</SPAN>
      <SPAN class="keyword token">var</SPAN> op <SPAN class="operator token">=</SPAN> obj<SPAN class="punctuation token">.</SPAN>Row<SPAN class="punctuation token">[</SPAN><SPAN class="string token">"Operable"</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">;</SPAN>
      <SPAN class="comment token">//set the row value</SPAN>
      obj<SPAN class="punctuation token">.</SPAN>Row<SPAN class="punctuation token">[</SPAN><SPAN class="string token">"Corroded"</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">=</SPAN> <SPAN class="number token">1</SPAN><SPAN class="punctuation token">;</SPAN>

      <SPAN class="comment token">//cancel the edit</SPAN>
      obj<SPAN class="punctuation token">.</SPAN><SPAN class="token function">CancelEdit</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
    <SPAN class="punctuation token">}</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Im submitting an issue as a potential fix for 2.4 if a future patch is planned.

MKa

I have narrowed down why this is happening, but might need some guidance. It appears that in the RowChange event this is happening because I load an inspector in the event to check a value of the selected row. If that value is true i cancel the edit. This DOES NOT work in the row change event. In the delete event, I have to check a value as well using an inspector and this DOES work. When I load an inspector in the onDelete it works like it should in 2.4.3, but in onChange if I use the inspector.load for that arg and objectid, the canceledit does not work

This does not work in the onChange event (it doesn't rollback)

<SPAN class="comment token">//This doesn't rollback the change because of the inspr.load, i have stepped through both </SPAN>
<SPAN class="comment token">//with and without this line.  This worked in the old version</SPAN>


<SPAN class="keyword token">protected</SPAN> <SPAN class="keyword token">async</SPAN> <SPAN class="keyword token">static</SPAN> <SPAN class="keyword token">void</SPAN> <SPAN class="token function">OnRowChangeEvent</SPAN><SPAN class="punctuation token">(</SPAN>RowChangedEventArgs args<SPAN class="punctuation token">)</SPAN>
        <SPAN class="punctuation token">{</SPAN>
            Inspector inspr <SPAN class="operator token">=</SPAN> <SPAN class="keyword token">new</SPAN> <SPAN class="token class-name">Inspector</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

            <SPAN class="keyword token">long</SPAN> _updateOID <SPAN class="operator token">=</SPAN> args<SPAN class="punctuation token">.</SPAN>Row<SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetObjectID</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

            <SPAN class="comment token">//Get the layer of the selected item</SPAN>
            FeatureClass newFC <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">(</SPAN>FeatureClass<SPAN class="punctuation token">)</SPAN>args<SPAN class="punctuation token">.</SPAN>Row<SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetTable</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
            <SPAN class="keyword token">string</SPAN> updateItemName <SPAN class="operator token">=</SPAN> newFC<SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetDefinition</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetAliasName</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
            FeatureLayer firstFeatureLayer <SPAN class="operator token">=</SPAN> FeatureServiceManagement<SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetFeatureLayer</SPAN><SPAN class="punctuation token">(</SPAN>updateItemName<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

            <SPAN class="comment token">//Load the inspector                </SPAN>
            <SPAN class="keyword token">await</SPAN> inspr<SPAN class="punctuation token">.</SPAN><SPAN class="token function">LoadAsync</SPAN><SPAN class="punctuation token">(</SPAN>firstFeatureLayer<SPAN class="punctuation token">,</SPAN> _updateOID<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

            args<SPAN class="punctuation token">.</SPAN><SPAN class="token function">CancelEdit</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="punctuation token">}</SPAN>
<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

This DOES work in the onDelete event (it doesn't delete, it rolls back)

<SPAN class="keyword token">protected</SPAN> <SPAN class="keyword token">async</SPAN> <SPAN class="keyword token">static</SPAN> <SPAN class="keyword token">void</SPAN> <SPAN class="token function">OnRowDeleteEvent</SPAN><SPAN class="punctuation token">(</SPAN>RowChangedEventArgs args<SPAN class="punctuation token">)</SPAN>
        <SPAN class="punctuation token">{</SPAN>
            Inspector inspr <SPAN class="operator token">=</SPAN> <SPAN class="keyword token">new</SPAN> <SPAN class="token class-name">Inspector</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

            <SPAN class="keyword token">long</SPAN> _updateOID <SPAN class="operator token">=</SPAN> args<SPAN class="punctuation token">.</SPAN>Row<SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetObjectID</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

            <SPAN class="comment token">//Get the layer of the selected item</SPAN>
            FeatureClass newFC <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">(</SPAN>FeatureClass<SPAN class="punctuation token">)</SPAN>args<SPAN class="punctuation token">.</SPAN>Row<SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetTable</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
            <SPAN class="keyword token">string</SPAN> updateItemName <SPAN class="operator token">=</SPAN> newFC<SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetDefinition</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetAliasName</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
            FeatureLayer firstFeatureLayer <SPAN class="operator token">=</SPAN> FeatureServiceManagement<SPAN class="punctuation token">.</SPAN><SPAN class="token function">GetFeatureLayer</SPAN><SPAN class="punctuation token">(</SPAN>updateItemName<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

            <SPAN class="comment token">//Load the inspector                </SPAN>
            <SPAN class="keyword token">await</SPAN> inspr<SPAN class="punctuation token">.</SPAN><SPAN class="token function">LoadAsync</SPAN><SPAN class="punctuation token">(</SPAN>firstFeatureLayer<SPAN class="punctuation token">,</SPAN> _updateOID<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

            args<SPAN class="punctuation token">.</SPAN><SPAN class="token function">CancelEdit</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="punctuation token">}</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

MKa

I am on server 10.5.1.

you got your code to undo the vertex edit in the on change event?

Anonymous User

Seems to be working for me on Pro 2.4.3 against a feature service on 10.6 windows portal. All three change events are ok, they can be cancelled.

Whats your server environment?

Anonymous User

Thanks, looking into it.

MKa

The datasource if a featureservice and it currently works in 2.2.3 that is in our Production environment. I am moving to 2.4.3

Anonymous User

Hi M,

Whats the datasource for the edits you want to cancel?

And confirming that the code worked at 2.2.3?

Thanks

Sean

MKa

I can seem to figure out why this doesn't work in my code. I am unable to upgrade until I allow users to either cancel their changes or stop them from performing certain changes. I upgraded my arcgis pro sdk from 2.2.3

Únete a la Conversación

Los miembros registrados pueden publicar, seguir actualizaciones y más. ¿Nuevo aquí? Regístrate gratis.

Enlaces Rápidos

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.