nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Python script- changing layer's name

MalgorzataMendela

Hello, I do not know why the following python script does not work and cause a change of the layer's name (from 'States' to 'Stany'). After running the script I have received the message:" script returned exit code 0". Any suggestions? Thank you.

import arcpy.mapping

mxd = arcpy.mapping.MapDocument("F:/DSW/Using_ArcGIS_Desktop/MexicoPopulationDensity.mxd")

for df in arcpy.mapping.ListDataFrames(mxd):

if (df.name == 'States'):

layers = arcpy.mapping.ListLayers(mxd,'Stany',df)

Find more posts tagged with

Accepted answers

All comments

MalgorzataMendela

Thank you very much for your help

AnthonyFarndon

Like a lot of things, there are many ways to achieve what you want.

layers = arcpy.mapping.ListLayers(mxd,'states',df)

will return a list of all layers named states, so you could loop through it to change the name

for lyr in layers:

lyr.name = "stany"

However if there is only one layer likely to be called states in the mxd, a shorthand way of achieving this is

lyr = arcpy.mapping.ListLayers(mxd,'states',df)[0]

lyr.name = "stany"

Doing an if == is useful if you are wanting to loop through many layers of differing names. eg

layers = arcpy.mapping.ListLayers(mxd,'',df)

for lyr in layers:

if lyr.name == "states":

lyr.name = "stany"

elif lyr.name == "Lakes":

lyr.name = "Lakey"

or to do more complex 'stuff' with name matches than the ListLayers wildcard parameter allows, such as ignoring case.

if lyr.name.lower() == "states":

Finally, if you are doing this with the mxd open, add in the following to see the changes on screen

arcpy.RefreshTOC()

And save the mxd if required

mxd.save()

MalgorzataMendela

Thank you Anthony for your message.
I have changed my code into the following;

import arcpy.mapping

mxd = arcpy.mapping.MapDocument("CURRENT")

df=arcpy.mapping.ListDataFrames(mxd,"Mexico")[0]

layers = arcpy.mapping.ListLayers(mxd,'states',df)
but there is nothing about changing the name of a feature class from 'states' to 'stany', so the result is still the same...
Don't I need to use for..if clause in order to change the name of a feature class?

AnthonyFarndon

As Joshua says, your df name is wrong.

I would use something like

df = arcpy.mapping.ListDataFrames(mxd, "")[0] or df = arcpy.mapping.ListDataFrames(mxd, "Mexico")[0]

and then no need for if df,name == , just use

layers = arcpy.mapping.ListLayers(mxd,'states',df)

bixb0012

Your data frame name is "Mexico," you are never going to find your 'states' layer if it is nested within your df.name == 'states' statement.

MalgorzataMendela

Yes, I have read this link, but I could not find there the answer to my problem. This is the layout view:

MalgorzataMendela

Yes, I have read this link, but I could not find there the answer to my problem.

MalgorzataMendela

This is the whole python code:

import arcpy.mapping

mxd = arcpy.mapping.MapDocument("F:/DSW/Using_ArcGIS_Desktop/MexicoPopulation.mxd")

print mxd.title

layers = arcpy.mapping.ListLayers(mxd)

for lyr in layers:

print lyr.name

for df in arcpy.mapping.ListDataFrames(mxd):

if (df.name == 'states'):

layers = arcpy.mapping.ListLayers(mxd,'Stany',df)

else:

print('not found')

mxd.saveACopy

I do not use CURRENT keyword, because I do not run a script from ArcGIS Python window, but from the PythonWin. Instead of that I put the correct pathfile of the *.mxd file and all *shp. files, which are included in this project.

The layer name is states. And now after loding the script once again, I have received the correct answer.
Unfortunately, the problem with changing the name of the layer states to Stany still remains...
Have you got any other ideas?

DanPatterson_Retired

is mxd defined as "Current" somewhere? that seems to be the piece that is missing for me... Did you read the link I sent you? The project has to be named as on disk or if you are working interactively, then with the Current keyword. Also, you are in source view in the table of contents, ... go to the data view (to the left of your current selection) to ensure that the layer is named "states" and not "States"

MalgorzataMendela

My python code looks like this now:

for df in arcpy.mapping.ListDataFrames(mxd):

if (df.name == 'states'):

layers = arcpy.mapping.ListLayers(mxd,'Stany',df)

else:

print('not found')

mxd.saveACopy

I have received the message 'not found', but the layer is the project folder.

I suppose that the problem is associated with refreshing.
As I have changed the name of shp file -> from States to states and use python to print the name of the layers, I have received the same result as BEFORE the change. So instead of:

Cities
states
Lakes

Mexico Bnd

Central America Bnd

USA Bnd, I have got:

Cities

Lakes

Mexico Bnd

States

Central America Bnd

USA Bnd

Could you please give me advice how to solve this problem?

DanPatterson_Retired

ok, add an else portion to the if ... python is exiting without doing anything

if ...

do stuff

else:

print('not found')

MalgorzataMendela

Unfortunately, it doesn't help.

DanPatterson_Retired

maybe you need to mxd.save() before the changes persist

MapDocument—Help | ArcGIS for Desktop

Join the Conversation

Signed in members can post, follow updates, and more. New here? Register a free account.

Quick Links

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.