Greetings! I would like to pose a question about two snippets of Python code that basically take in a list of events, each of which contain a latitude, longitude and depth like so eventslist = [[ lat1, lng1, depth1], [lat2,lng2, depth2] ... [latN, lngN, depthN]] and input these as points into two separate Geodatabase Featureclasses. I have verified that both these code snippets work but I would like to ask, which snippet in your opinion is the more efficient/correct one in regards to where to start/end the edit operation (edit.startOperation()) and creation/deletion of the insert cursors. Also if you think another solution is even more preferable then please don't hesitate to suggest, thanks in advance! SNIPPET 1 #Start an edit session to insert new events. Need to have edit session because of using two insert cursors at the same time. edit = arcpy . da . Editor ( env . workspace ) edit . startEditing ( False , False ) #Iterate over the list of new events, each event contains lat, lng and depth for event in newevents : edit . startOperation ( ) cursor = arcpy . da . InsertCursor ( inFc , [ "SHAPE@" , "lat" , "lng" , "depth" ] ) cursor2 = arcpy . da . InsertCursor ( archiveFc , [ "SHAPE@" , "lat" , "lng" , "depth" ] ) lat , lng , Z = ( event [ 0 ] , event [ 1 ] , event [ 2 ] ) location = arcpy . Point ( lng , lat , Z ) #Create the 3-D point object pointGeom = arcpy . PointGeometry ( location ) #Create the shape geometry as pointGeometry row = [ pointGeom , lat , lng , depth ] row2 = [ pointGeom , lat , lng , depth ] cursor . insertRow ( row ) #Insert the new events into longterm class using insert cursor cursor2 . insertRow ( row2 ) #Insert the new events into archive class using insert cursor2 del row , row2 del cursor , cursor2 edit . stopOperation ( ) edit . stopEditing ( True ) SNIPPET 2 #Start an edit session to insert new events. Need to have edit session because of using two insert cursors at the same time. edit = arcpy . da . Editor ( env . workspace ) edit . startEditing ( False , False ) edit . startOperation ( ) cursor = arcpy . da . InsertCursor ( inFc , [ "SHAPE@" , "lat" , "lng" , "depth" ] ) cursor2 = arcpy . da . InsertCursor ( archiveFc , [ "SHAPE@" , "lat" , "lng" , "depth" ] ) #Iterate over the list of new events, each event is a list that contains lat, lng and depth for event in newevents : lat , lng , Z = ( event [ 0 ] , event [ 1 ] , event [ 2 ] ) location = arcpy . Point ( lng , lat , Z ) #Create the 3-D point object pointGeom = arcpy . PointGeometry ( location ) #Create the shape geometry as pointGeometry row = [ pointGeom , lat , lng , depth ] row2 = [ pointGeom , lat , lng , depth ] cursor . insertRow ( row ) #Insert the new events into longterm class using insert cursor cursor2 . insertRow ( row2 ) #Insert the new events into archive class using insert cursor2 del row , row2 edit . stopOperation ( ) del cursor , cursor2 edit . stopEditing ( True )

nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Which is the better way of using edit session and insert cursors?

vedur

Greetings!

I would like to pose a question about two snippets of Python code that basically take in a list of events, each of which contain a latitude, longitude and depth like so eventslist = [[ lat1, lng1, depth1], [lat2,lng2, depth2] ... [latN, lngN, depthN]] and input these as points into two separate Geodatabase Featureclasses. I have verified that both these code snippets work but I would like to ask, which snippet in your opinion is the more efficient/correct one in regards to where to start/end the edit operation (edit.startOperation()) and creation/deletion of the insert cursors.

Also if you think another solution is even more preferable then please don't hesitate to suggest, thanks in advance!

SNIPPET 1

<SPAN class="comment token">#Start an edit session to insert new events. Need to have edit session because of using two insert cursors at the same time. </SPAN>
edit <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>Editor<SPAN class="punctuation token">(</SPAN>env<SPAN class="punctuation token">.</SPAN>workspace<SPAN class="punctuation token">)</SPAN>
edit<SPAN class="punctuation token">.</SPAN>startEditing<SPAN class="punctuation token">(</SPAN><SPAN class="token boolean">False</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="token boolean">False</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token">#Iterate over the list of new events, each event contains lat, lng and depth</SPAN>
&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">for</SPAN> event <SPAN class="keyword token">in</SPAN> newevents<SPAN class="punctuation token">:</SPAN>&nbsp; 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; edit<SPAN class="punctuation token">.</SPAN>startOperation<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; cursor <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>InsertCursor<SPAN class="punctuation token">(</SPAN>inFc<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">"SHAPE@"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"lat"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"lng"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"depth"</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN> 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; cursor2 <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>InsertCursor<SPAN class="punctuation token">(</SPAN>archiveFc<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">"SHAPE@"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"lat"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"lng"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"depth"</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; lat<SPAN class="punctuation token">,</SPAN>lng<SPAN class="punctuation token">,</SPAN>Z <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">(</SPAN>event<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">,</SPAN> event<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">,</SPAN> event<SPAN class="punctuation token">[</SPAN><SPAN class="number token">2</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; location <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>Point<SPAN class="punctuation token">(</SPAN>lng<SPAN class="punctuation token">,</SPAN> lat<SPAN class="punctuation token">,</SPAN> Z<SPAN class="punctuation token">)</SPAN> <SPAN class="comment token">#Create the 3-D point object</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; pointGeom <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>PointGeometry<SPAN class="punctuation token">(</SPAN>location<SPAN class="punctuation token">)</SPAN> <SPAN class="comment token">#Create the shape geometry as pointGeometry</SPAN>

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; row <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN>pointGeom<SPAN class="punctuation token">,</SPAN> lat<SPAN class="punctuation token">,</SPAN> lng<SPAN class="punctuation token">,</SPAN> depth<SPAN class="punctuation token">]</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; row2 <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN>pointGeom<SPAN class="punctuation token">,</SPAN> lat<SPAN class="punctuation token">,</SPAN> lng<SPAN class="punctuation token">,</SPAN> depth<SPAN class="punctuation token">]</SPAN>

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; cursor<SPAN class="punctuation token">.</SPAN>insertRow<SPAN class="punctuation token">(</SPAN>row<SPAN class="punctuation token">)</SPAN> <SPAN class="comment token">#Insert the new events into longterm class using insert cursor </SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; cursor2<SPAN class="punctuation token">.</SPAN>insertRow<SPAN class="punctuation token">(</SPAN>row2<SPAN class="punctuation token">)</SPAN> <SPAN class="comment token">#Insert the new events into archive class using insert cursor2</SPAN>

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">del</SPAN> row<SPAN class="punctuation token">,</SPAN> row2 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">del</SPAN> cursor<SPAN class="punctuation token">,</SPAN> cursor2
&nbsp;&nbsp; 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; edit<SPAN class="punctuation token">.</SPAN>stopOperation<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>
 
edit<SPAN class="punctuation token">.</SPAN>stopEditing<SPAN class="punctuation token">(</SPAN><SPAN class="token boolean">True</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

SNIPPET 2

<SPAN class="comment token">#Start an edit session to insert new events. Need to have edit session because of using two insert cursors at the same time. </SPAN>
edit <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>Editor<SPAN class="punctuation token">(</SPAN>env<SPAN class="punctuation token">.</SPAN>workspace<SPAN class="punctuation token">)</SPAN>
edit<SPAN class="punctuation token">.</SPAN>startEditing<SPAN class="punctuation token">(</SPAN><SPAN class="token boolean">False</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="token boolean">False</SPAN><SPAN class="punctuation token">)</SPAN>
edit<SPAN class="punctuation token">.</SPAN>startOperation<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>

cursor <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>InsertCursor<SPAN class="punctuation token">(</SPAN>inFc<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">"SHAPE@"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"lat"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"lng"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"depth"</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
cursor2 <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>InsertCursor<SPAN class="punctuation token">(</SPAN>archiveFc<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">"SHAPE@"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"lat"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"lng"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"depth"</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token">#Iterate over the list of new events, each event is a list that contains lat, lng and depth</SPAN>
<SPAN class="keyword token">for</SPAN> event <SPAN class="keyword token">in</SPAN> newevents<SPAN class="punctuation token">:</SPAN>
&nbsp; 
&nbsp;&nbsp;&nbsp; lat<SPAN class="punctuation token">,</SPAN>lng<SPAN class="punctuation token">,</SPAN>Z <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">(</SPAN>event<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">,</SPAN> event<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">,</SPAN> event<SPAN class="punctuation token">[</SPAN><SPAN class="number token">2</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp; location <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>Point<SPAN class="punctuation token">(</SPAN>lng<SPAN class="punctuation token">,</SPAN> lat<SPAN class="punctuation token">,</SPAN> Z<SPAN class="punctuation token">)</SPAN> <SPAN class="comment token">#Create the 3-D point object</SPAN>
&nbsp;&nbsp;&nbsp; pointGeom <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>PointGeometry<SPAN class="punctuation token">(</SPAN>location<SPAN class="punctuation token">)</SPAN> <SPAN class="comment token">#Create the shape geometry as pointGeometry</SPAN>

&nbsp;&nbsp;&nbsp; row <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN>pointGeom<SPAN class="punctuation token">,</SPAN> lat<SPAN class="punctuation token">,</SPAN> lng<SPAN class="punctuation token">,</SPAN> depth<SPAN class="punctuation token">]</SPAN>
&nbsp;&nbsp;&nbsp; row2 <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN>pointGeom<SPAN class="punctuation token">,</SPAN> lat<SPAN class="punctuation token">,</SPAN> lng<SPAN class="punctuation token">,</SPAN> depth<SPAN class="punctuation token">]</SPAN>

&nbsp;&nbsp;&nbsp; cursor<SPAN class="punctuation token">.</SPAN>insertRow<SPAN class="punctuation token">(</SPAN>row<SPAN class="punctuation token">)</SPAN> <SPAN class="comment token">#Insert the new events into longterm class using insert cursor</SPAN>
&nbsp;&nbsp;&nbsp; cursor2<SPAN class="punctuation token">.</SPAN>insertRow<SPAN class="punctuation token">(</SPAN>row2<SPAN class="punctuation token">)</SPAN> <SPAN class="comment token">#Insert the new events into archive class using insert cursor2</SPAN>

&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">del</SPAN> row<SPAN class="punctuation token">,</SPAN> row2

edit<SPAN class="punctuation token">.</SPAN>stopOperation<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="keyword token">del</SPAN> cursor<SPAN class="punctuation token">,</SPAN> cursor2&nbsp; 

edit<SPAN class="punctuation token">.</SPAN>stopEditing<SPAN class="punctuation token">(</SPAN><SPAN class="token boolean">True</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Find more posts tagged with

Accepted answers

JoshuaBixby

I would say the answer lies somewhere between your two code snippets. The first code snippet is very risk adverse, i.e., it is taking each event as an atomic edit operation. Although this obviously works, and it will minimize how much of a rollback there is if any errors occur, it also incurs the cost of commits with every single event, i.e., it will be slow.

The second code snippet is possibly risky depending upon the number of events to process because all of the updates will be held before committing. At some point, the rollbacks needed for a large number of records will start to slow everything down.

If the number of events is modest, say in the single-digits thousands, I would stick with snippet #2. If you are talking about updating tens of thousands of records or more, I would consider batching/chunking them into more manageable sized updates.

All comments

JoshuaBixby

vedur

EDIT: Just noticed an error in snippet 2, the editStopOperation() call should be after the del cursor, cursor2 statement otherwise you get an error that the cursors have been invalidated because the edit operation has stopped.

Thanks for the input Joshua, it was very helpful indeed and I'll mark is at the correct answer. However as you point out the efficient way depends on the number of events vs. possible risk of losing edits if something goes wrong. In my case the number of events is quite modest so I'll use the code from snippet 2

JoshuaBixby

I wouldn't say there is a risk of losing edits, just not getting them committed along with possible performance impacts if the number of edits are too large with one operation. If you are not working with a large number of records, I think snippet 2 represents a much more common approach and one that will likely perform quicker.

Join the Conversation

Signed in members can post, follow updates, and more. New here? Register a free account.

Quick Links

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.