nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

convert VB expression to python

Anonymous User

I am new to python. I am using a model to automate a data update process. Part of the model is to calculate a new field by concatenating 3 other fields and left trimming to remove white space as needed. Below is the VB expression. When I use python to automatically run this model it fails at the expression to calculate the field. Below is the VB expression. I cannot find an example of how this would look as a python expression. Can anyone help?

FullStreet =

LTrim( [LOCN] &" " & LTrim( [LOCD] & " " & [LOCS]))

Any help would be greatly appreciated.

Sincerely,

Nita L Hester

Find more posts tagged with

Accepted answers

All comments

JamesCrandall

You may have mentioned this already, but the examples will work with TEXT field types (eg, it's possible LOCN or you address Number column is actually a number type column?). Anyway...

See if this adaptation works better. It's just looking for empty strings (ie, "not input1") or actual strings (ie, "input1"). Also, in my sample data I thought I was looking at an empty value but it actually had a space in it --- so it was treated as an actual value and did not evaluate as expected. This is why I included the .strip() into the input variables).

def processInput(input1, input2, input3):
    if (not input1.strip()) and (not input2.strip()):    
        return input3.lstrip()
    elif (input1.strip()) and (not input2.strip()):    
        return  input1 + " " + input3
    elif (not input1.strip()) and (input2.strip()):    
        return  input2 + " " + input3 
    else:
        return input1 + " " + input2 + " " + input3

(I wish I could write this more elegantly like some of the other contributors! Need to work on that)

Anonymous User

I am using the Calculate Field tool in my model. how would I write this?

I do not know what to put in place of ' '. in your expression.

Anonymous User

Thanks for your help. I think we are almost there....

Here is the modified codeblock based on you instructions:

def processInput(input1, input2, input3):

if len(input1) == 0 and len(input2) == 0:

return input3

elif len(input1)>0 and input2 == "" :

return input1 + " " + input3

elif input1 == "" and len(input2)>0 :

return input2 + " " + input3

else:

return input1 + " " + input2 + " " + input3

processInput( !LOCN!.strip(), !LOCD!.strip(), !LOCS!.strip())

Now the only problem is the first statement. If there is no value in input 1 & 2 it does not return input 3. It is blank. I tried to add the .strip to make sure there was no spaces in the field if no other value. I also tried changing from "" to len(input1) == 0, but it still does not put a value in for just the LOCS (street name) if that is the only field that has a value.

Any suggestions?

Nita

JamesCrandall

Total pro.

bixb0012

Luke Pinner, this is definitely the most idiomatic and elegant in my mind. I would give 2 helpfuls if I could.

I know the OP used LTRIM, which is probably why you used lstrip(), but I wonder if using strip() would be better for the OP. One very minor comment, the list comprehension can be swapped for a generator expression, which then allows the expression brackets to be dropped:

' '.join(s.lstrip() for s in (LOCN,LOCD,LOCS) if s)

Anonymous User

I think we are getting close. I tryed your instructions but get a syntax error on line 4. I cannot find anything wrong though.

Let me try to better explain what I am trying to do.

LOCN = House Number

LOCD = Street direction (i.e. N, S, E, W)

LOCS = Street Name (i.e Somewhere Blvd)

Some records have only the LOCS.

Some records have the LOCN and LOCS

Some records have LOCN, LOCD, and LOCS

I need to get the end result of:

Somewhere Blvd, or

S Somewhere Blvd, or

1234 Somewhere Blvd, or

1234 S Somewhere Blvd.

With the VB expression it concatenates the LOCD and LOCS, then trims any space before the result so that if there is no LOCD it will only have the street name and remove the hard coded space. LTrim( [LOCD] & " " & [LOCS]). Then the next part is to join that result to the first part. LTrim( [LOCN] &" " & LTrim( [LOCD] & " " & [LOCS]))

The end result is that no matter what fields have values, there are spaces when needed and no extra spaces when not.

Does this explain it better? if I just do !LOCD! + !LOCS! that gives me either just the LOCS or adds the LOCD and LOCS with no space between. That is as far as I get.

I really appreciate everyones help on this!!!!!!!

Luke_Pinner

You can do it in one line with a list comprehension. The `if` statement in the list comprehension will handle empty strings.

Field calculator expression:

' '.join([s.lstrip() for s in (!LOCN,!LOCD!,!LOCS!) if s])

Basic python (assumes LOC* variables already defined)

' '.join([s.lstrip() for s in (LOCN,LOCD,LOCS) if s])

AdrianWelsh

Thanks James! You're the best. I didn't have time to write this up and this works great.

RebeccaStrauch__GISP

And to follow James' code, if you want to then call this within a python script..

def processInput(input1, input2, input3):  
  if input1 == "" or input2 == "":  
     return input3  
  else  
     return input1.strip() + "" + input2.strip() + "" + input3.strip()  """

# I'm showing passing three fields, but can be other input that needs to be passed
arcpy.CalculateField_management("inFC", "fieldToCal", "processInput( !field1!, !field2!, !field3!)", "PYTHON_9.3", myCode_block)

JamesCrandall

Like Adrian mentions, you will need to add some Pre-Logic code to the expression. From the field calculator:

1. Right click the field to calculate and in the Field calculator dialog, choose the appropriate Parser (ie, Python)

2. Place a check in the "Show Codeblock" box

3. In the Pre-Logic Script Code: section, add a def() that should look something like (I'm not totally certain about the exact logic desired, but this will get close I think):

def processInput(input1, input2, input3):
  if input1 == "" or input2 == "":
     return input3
  else
     return input1.strip() + "" + input2.strip() + "" + input3.strip()

4. In the box below the Pre-Logic script area, enter in the def() name and add your field parameters:

processInput( !LOCN!, !LOCD!, !LOCS!)

Order them appropriately.

edit: apologies as I'm showing strictly from the Field Calculator dialog, which does not specifically address the original question of a field calculation from within a model or python script. You will have to adapt this as needed.

AdrianWelsh

You will have to use the code block to make a basic logic statement utilizing If..Then.

See this article on the basics for doing this:

Calculate Field examples—Help | ArcGIS for Desktop

and scroll down to "Using code blocks"

I am guessing that you will need to check each field if it is empty or now. I would start it like:

If !LOCN!.len() <> 0

(but you'll have to tinker around with the code to make it behave properly!)

Anonymous User

Thanks, I tried this and it works, but I need to remove the white spaces if there is no LOCN and or LOCD data. How do I remove white space from after adding it between the fields if there is no associated data for both or either of the 1st 2 fields?

Anonymous User

Thanks, I tried this and it works, but I need to remove the white spaces if there is no LOCN and or LOCD data.

FreddieGibson

You'll want to look at the python help for concatenating strings. The simplest option would be as follows.

!LOCN!.lstrip() + " " + !LOCD!.lstrip() + " " + !LOCS!

A cleaner example would be to use string.format

"{0} {1} {2}".format(!LOCN!.lstrip(), !LOCD!.lstrip(), !LOCS!.lstrip())

String Concatenation and Formatting

Python String lstrip() Method

AdrianWelsh

Could you try .lstrip()?

So !LOCN!.lstrip() + " " + !LOCD!.lstrip() + " " + !LOCS!.lstrip()

Would that work?

kenbuja

Please note GeoNet Help help space is for questions about GeoNet itself, not about specific programming questions. I'm moving it to the Python space. Also, using tags when asking questions will make it easier to be searched on.

Join the Conversation

Signed in members can post, follow updates, and more. New here? Register a free account.

Quick Links

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.