nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Using a cursor to update field in point feature class from polygon

Brian_McLeer

I am working on a python script that updates a field titled 'PlanRefID' field in several point feature classes. These are populated based on a 'PlanRefID' field in a polygon feature class. The cursor will loop through and populate the 'PlanRefID' field in the point feature classes (approximately 10) correctly.

The issue I am having is that I only want it to update where the PlanRefID IS NULL in my point feature classes. However, it will loop through all records in the polygon feature class, which is taking about 1.5 - 2 hours to run. As the feature classes add more records, the processing time will only increase. I only interested in updating the point features where the PlanRefID IS NULL and referencing the polygons they intersect.

arcpy<SPAN class="punctuation token">.</SPAN>MakeFeatureLayer_management<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Database Connections\\Server Database OWNER.sde\\Database.OWNER.FeatureDataset\\Database.OWNER.Polygon"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"Database_OWNER_Polygon"</SPAN><SPAN class="punctuation token">)</SPAN>  
arcpy<SPAN class="punctuation token">.</SPAN>MakeFeatureLayer_management<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Database Connections\\Server Database OWNER.sde\\Database.OWNER.FeatureDataset\\Database.OWNER.Point"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"Database_Owner_Point"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"PlanRefID IS NULL"</SPAN><SPAN class="punctuation token">)</SPAN> 
arcpy<SPAN class="punctuation token">.</SPAN>SelectLayerByAttribute_management<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Database_Owner_Point"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"NEW_SELECTION"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"PlanRefID IS NULL"</SPAN><SPAN class="punctuation token">)</SPAN>   

rows <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>SearchCursor<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Database_OWNER_Polygon"</SPAN><SPAN class="punctuation token">)</SPAN> 
<SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> rows<SPAN class="punctuation token">:</SPAN> 
    arcpy<SPAN class="punctuation token">.</SPAN>SelectLayerByAttribute_management<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Database_OWNER_Polygon"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"NEW_SELECTION"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"\"OBJECTID\" = "</SPAN> <SPAN class="operator token">+</SPAN> str<SPAN class="punctuation token">(</SPAN>row<SPAN class="punctuation token">.</SPAN>getValue<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"OBJECTID"</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN> 
    arcpy<SPAN class="punctuation token">.</SPAN>SelectLayerByLocation_management<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Database_Owner_Point"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"INTERSECT"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"Database_OWNER_Polygon"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">""</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"NEW_SELECTION"</SPAN><SPAN class="punctuation token">)</SPAN> 
    arcpy<SPAN class="punctuation token">.</SPAN>CalculateField_management<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Database_Owner_Point"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"PlanRefID"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"'{0}'"</SPAN><SPAN class="punctuation token">.</SPAN>format<SPAN class="punctuation token">(</SPAN>str<SPAN class="punctuation token">(</SPAN>row<SPAN class="punctuation token">.</SPAN>getValue<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"PlanRefID"</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"PYTHON_9.3"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">""</SPAN><SPAN class="punctuation token">)</SPAN> <SPAN class="keyword token">print</SPAN> <SPAN class="string token">"Finished processing "</SPAN> <SPAN class="operator token">+</SPAN> str<SPAN class="punctuation token">(</SPAN>row<SPAN class="punctuation token">.</SPAN>getValue<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"PlanRefID"</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN>‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Find more posts tagged with

Accepted answers

MitchHolley1

You could build a dictionary of both geometries and compare them with arcpy. However, I don't know if this will be any faster... especially connecting to a non-local database.

I would test this on scratch data first.

<SPAN class="keyword token">import</SPAN> arcpy

<SPAN class="comment token">#datasources</SPAN>
polygon <SPAN class="operator token">=</SPAN> r<SPAN class="string token">'path\to\polygon'</SPAN>
point <SPAN class="operator token">=</SPAN> r<SPAN class="string token">'path\to\point'</SPAN>

<SPAN class="comment token">#cursor objects</SPAN>
polyCur <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>SearchCursor<SPAN class="punctuation token">(</SPAN>polygon<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'SHAPE@'</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">'PlanRefID'</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
pointCur <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>SearchCursor<SPAN class="punctuation token">(</SPAN>point<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'SHAPE@'</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">'OBJECTID'</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">"PlanRefID IS NULL"</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token">#dictionary to store geometry:value pairs for comparison</SPAN>
poly_dict <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">{</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">:</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> polyCur<SPAN class="punctuation token">}</SPAN>
point_dict <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">{</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">:</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> pointCur<SPAN class="punctuation token">}</SPAN>

<SPAN class="comment token">#populated match dictionary of polygon.PlanRefID, if point geom is within poly geom</SPAN>
<SPAN class="comment token">#see here: http://desktop.arcgis.com/en/arcmap/10.3/analyze/arcpy-classes/point.htm</SPAN>
match <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">{</SPAN><SPAN class="punctuation token">}</SPAN>
<SPAN class="keyword token">for</SPAN> pnt <SPAN class="keyword token">in</SPAN> point_dict<SPAN class="punctuation token">:</SPAN>
    <SPAN class="keyword token">for</SPAN> poly <SPAN class="keyword token">in</SPAN> poly_dict<SPAN class="punctuation token">:</SPAN>
        <SPAN class="keyword token">if</SPAN> pnt<SPAN class="punctuation token">.</SPAN>within<SPAN class="punctuation token">(</SPAN>poly<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>
            ID <SPAN class="operator token">=</SPAN> point_dict<SPAN class="punctuation token">[</SPAN>pnt<SPAN class="punctuation token">]</SPAN>
            value <SPAN class="operator token">=</SPAN> poly_dict<SPAN class="punctuation token">[</SPAN>poly<SPAN class="punctuation token">]</SPAN>
            match<SPAN class="punctuation token">[</SPAN>ID<SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">=</SPAN> value

<SPAN class="comment token">#could add qry to make it run faster.. may not work with different data formats (.shp)</SPAN>
qry <SPAN class="operator token">=</SPAN> <SPAN class="string token">"OBJECTID IN {}"</SPAN><SPAN class="punctuation token">.</SPAN>format<SPAN class="punctuation token">(</SPAN>tuple<SPAN class="punctuation token">(</SPAN>k <SPAN class="keyword token">for</SPAN> k <SPAN class="keyword token">in</SPAN> match<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token">#iterate over points w/ qry and update PlanRefID if OBJECTID is found in dictionary</SPAN>
<SPAN class="keyword token">with</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>UpdateCursor<SPAN class="punctuation token">(</SPAN>point<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'OBJECTID'</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">'PlanRefID'</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">,</SPAN>qry<SPAN class="punctuation token">)</SPAN> <SPAN class="keyword token">as</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
    <SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
        <SPAN class="keyword token">if</SPAN> row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="keyword token">in</SPAN> match<SPAN class="punctuation token">:</SPAN>
            row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">=</SPAN> match<SPAN class="punctuation token">[</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">]</SPAN>
            cursor<SPAN class="punctuation token">.</SPAN>updateRow<SPAN class="punctuation token">(</SPAN>row<SPAN class="punctuation token">)</SPAN>
<SPAN class="keyword token">del</SPAN> cursor
            
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Lastly, I created a similar ESRI Script Tool that has worked successfully with ArcMap 10.4. I call is Spatially Append Attributes.

All comments

Brian_McLeer

I usually do that but it requires a spatial join, then a table join, then a calculate field. In the case of my schema here, I don't have a unique ID field to join back to on a table join.

curtvprice

Why not use Join By Location followed by a join and calculate field? I would think that would be much faster than joining feature by feature using geometry methods. I may be wrong, but if possible I like to use the tool instead to make it Esri's problem if something doesn't work. 🙂

Brian_McLeer

Thanks, Mitch,

That worked. I was able to make a separate python file for each point feature class and just schedule it sequentially in task scheduler, takes about 10 minutes to run instead of 2 hours. I also took your advice about doing the geoprocessing on my local drive. I ended up deleting the features where the PlanRefID was NULL after exporting locally then append them back into SDE at the end of the script. Thanks for your help.

MitchHolley1

You could build a dictionary of both geometries and compare them with arcpy. However, I don't know if this will be any faster... especially connecting to a non-local database.

I would test this on scratch data first.

<SPAN class="keyword token">import</SPAN> arcpy

<SPAN class="comment token">#datasources</SPAN>
polygon <SPAN class="operator token">=</SPAN> r<SPAN class="string token">'path\to\polygon'</SPAN>
point <SPAN class="operator token">=</SPAN> r<SPAN class="string token">'path\to\point'</SPAN>

<SPAN class="comment token">#cursor objects</SPAN>
polyCur <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>SearchCursor<SPAN class="punctuation token">(</SPAN>polygon<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'SHAPE@'</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">'PlanRefID'</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
pointCur <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>SearchCursor<SPAN class="punctuation token">(</SPAN>point<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'SHAPE@'</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">'OBJECTID'</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">"PlanRefID IS NULL"</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token">#dictionary to store geometry:value pairs for comparison</SPAN>
poly_dict <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">{</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">:</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> polyCur<SPAN class="punctuation token">}</SPAN>
point_dict <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">{</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">:</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> pointCur<SPAN class="punctuation token">}</SPAN>

<SPAN class="comment token">#populated match dictionary of polygon.PlanRefID, if point geom is within poly geom</SPAN>
<SPAN class="comment token">#see here: http://desktop.arcgis.com/en/arcmap/10.3/analyze/arcpy-classes/point.htm</SPAN>
match <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">{</SPAN><SPAN class="punctuation token">}</SPAN>
<SPAN class="keyword token">for</SPAN> pnt <SPAN class="keyword token">in</SPAN> point_dict<SPAN class="punctuation token">:</SPAN>
    <SPAN class="keyword token">for</SPAN> poly <SPAN class="keyword token">in</SPAN> poly_dict<SPAN class="punctuation token">:</SPAN>
        <SPAN class="keyword token">if</SPAN> pnt<SPAN class="punctuation token">.</SPAN>within<SPAN class="punctuation token">(</SPAN>poly<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>
            ID <SPAN class="operator token">=</SPAN> point_dict<SPAN class="punctuation token">[</SPAN>pnt<SPAN class="punctuation token">]</SPAN>
            value <SPAN class="operator token">=</SPAN> poly_dict<SPAN class="punctuation token">[</SPAN>poly<SPAN class="punctuation token">]</SPAN>
            match<SPAN class="punctuation token">[</SPAN>ID<SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">=</SPAN> value

<SPAN class="comment token">#could add qry to make it run faster.. may not work with different data formats (.shp)</SPAN>
qry <SPAN class="operator token">=</SPAN> <SPAN class="string token">"OBJECTID IN {}"</SPAN><SPAN class="punctuation token">.</SPAN>format<SPAN class="punctuation token">(</SPAN>tuple<SPAN class="punctuation token">(</SPAN>k <SPAN class="keyword token">for</SPAN> k <SPAN class="keyword token">in</SPAN> match<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token">#iterate over points w/ qry and update PlanRefID if OBJECTID is found in dictionary</SPAN>
<SPAN class="keyword token">with</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>UpdateCursor<SPAN class="punctuation token">(</SPAN>point<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'OBJECTID'</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">'PlanRefID'</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">,</SPAN>qry<SPAN class="punctuation token">)</SPAN> <SPAN class="keyword token">as</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
    <SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
        <SPAN class="keyword token">if</SPAN> row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="keyword token">in</SPAN> match<SPAN class="punctuation token">:</SPAN>
            row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">=</SPAN> match<SPAN class="punctuation token">[</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">]</SPAN>
            cursor<SPAN class="punctuation token">.</SPAN>updateRow<SPAN class="punctuation token">(</SPAN>row<SPAN class="punctuation token">)</SPAN>
<SPAN class="keyword token">del</SPAN> cursor
            
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Lastly, I created a similar ESRI Script Tool that has worked successfully with ArcMap 10.4. I call is Spatially Append Attributes.

Join the Conversation

Signed in members can post, follow updates, and more. New here? Register a free account.

Quick Links

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.