nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Adding all GIS Layers from a folder

Ryan_Galbraith

Anyone know how to create a looping statement that adds all the GIS layers from a folder? Using arcpy.mapping.

Here is what I got:

arcpy.env.workspace = '#whatever the folder is'
mxd = arcpy.mapping.MapDocument("Current")
fclist = arcpy.ListFeatureClasses()
for fc in fclist:
.....#something to add to your feature classes

layer repair error message.jpg

broken layers.jpg

RTPL_AU_2-1765323923273.png

ewangxy_0-1765323777248.png

Find more posts tagged with

Accepted answers

All comments

Anonymous User

Original User: jscheirer

arcpy.MakeFeatureLayer_management(fc, fc)

JeffreyBarrette

You are on the right track. Check out the samples for MakeFeatureLayer. Also check out arcpy.mapping.AddLayer.

Jeff

Anonymous User

Original User: rdg129

arcpy.MakeFeatureLayer_management(fc, fc)

No, that, didn't work, the two fcs can't be the same.

JasonScheirer

The second one is the name of the layer in the TOC. If that's not working, something like this:

arcpy.env.workspace = '#whatever the folder is'
mxd = arcpy.mapping.MapDocument("Current")
fclist = arcpy.ListFeatureClasses()
for i, fc in enumerate(fclist):
    arcpy.CreateFeatureLayer_management(fc, "layer_%i" % i)

Anonymous User

Original User: rdg129

That doesn't work either. Not sure why not it always brings up an error.

RichardFairhurst

That doesn't work either. Not sure why not it always brings up an error.

Perhaps a dumb question, but what are you actually putting in the first line to specify the workspace folder? If the path is unspecified or invalid (such as incorrect slashes, which is common with path strings), that could be the source of the error.

arcpy.env.workspace = 'C:\\GIS_DATA\\' # or r 'C:\GIS_DATA\'
mxd = arcpy.mapping.MapDocument("Current")
fclist = arcpy.ListFeatureClasses()
for i, fc in enumerate(fclist):
    arcpy.CreateFeatureLayer_management(fc, "layer_%i" % i)

Anonymous User

Original User: rdg129

I am using shapefiles, does that matter?

RichardFairhurst

I am using shapefiles, does that matter?

I think the problem is in the fact that the fc variable is a numeric value and not a feature class because it has been converted to an enumerated value. The CreateFeatureLayer expects fc to be an actual feature class and not a number. Separte the enumeration variable i from the fc variable. Try the code below:

arcpy.env.workspace = 'C:\\GIS_DATA\\' # or r 'C:\GIS_DATA\'
mxd = arcpy.mapping.MapDocument("Current")
fclist = arcpy.ListFeatureClasses()
i = 0
for fc in fclist:
    i += 1
    arcpy.CreateFeatureLayer_management(fc, "layer_%i" % i)

Anonymous User

Original User: rdg129

GRRR. Nothing is working. thanks for all your help though.

BenjaminGale

Think this should work. I tested it on a folder of shp files.

arcpy.env.workspace = "WORKSPACE"
mxd = arcpy.mapping.MapDocument('CURRENT')
fclist = arcpy.ListFeatureClasses()
for fc in fclist:
    name = fc.split(".") #Splits the .shp from the name
    arcpy.MakeFeatureLayer_management(fc,name[0])

Join the Conversation

Signed in members can post, follow updates, and more. New here? Register a free account.

Quick Links

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.