Hi All. I'm trying to run the below python code with no luck. The 2 layers listed on line 20 are referenced again on line 37 when I attempt to cycle through their extents. The code should pull the extents and apply them to the data frame. The issue is that the list at line 20 won't work unless there are no spaces in the layer names. If enclose the names in "..." then the code is "syntax error free" but fails at line 37 when trying to extract the extent of a string object instead of a layer. How can I work around this (would prefer to not have to rename my layers in the mxd!). import arcpy from arcpy import env , mapping from bisect import bisect #input parameters; Plantation = arcpy . GetParameter ( 0 ) ForestID = arcpy . GetParameter ( 1 ) CommonName = arcpy . GetParameter ( 2 ) PYear = arcpy . GetParameter ( 3 ) OpCode = arcpy . GetParameter ( 4 ) #variables; title1 = Plantation + " PLANTATION" title2 = Plantation + "\r\nPLANTATION" title3 = Plantation + " (" + CommonName + ")" title4 = Plantation + " P" + PYear + " AREA STATEMENT" mxd = mapping . MapDocument ( "CURRENT" ) elements = mapping . ListLayoutElements ( mxd ) layers = mapping . ListLayers ( mxd ) HTL_layer_list = [ "Entered In GeoMaster" , "Entered In GeoMaster Archive" ] dflist = arcpy . mapping . ListDataFrames ( mxd , "" ) opcode_exp1 = "EnteredInGeoMaster IS NOT NULL AND Ops_Code = '" + OpCode + "'" opcode_exp2 = "Ops_Code = '" + OpCode + "'" if lyr . name == "Entered In GeoMaster" : lyr . definitionQuery = opcode_exp1 arcpy . AddMessage ( lyr . name + " definition query updated" ) elif lyr . name == "Entered In GeoMaster Archive" : lyr . definitionQuery = opcode_exp2 arcpy . AddMessage ( lyr . name + " definition query updated" ) # get current map extent xmin , xmax = dflist [ 0 ] . extent . XMin , dflist [ 0 ] . extent . XMax ymin , ymax = dflist [ 0 ] . extent . YMin , dflist [ 0 ] . extent . YMax # loop through def query layer extents and create one extent to fit them all for HTL_lyr in HTL_layer_list : HTL_ext = HTL_lyr . getExtent ( ) if HTL_ext . XMin xmin : xmin = ext . XMin if HTL_ext . YMin ymin : ymin = ext . YMin if HTL_ext . XMax > xmax : xmax = ext . XMax if HTL_ext . YMax > ymax : ymax = ext . YMax # set df extent to new extent dflist [ 0 ] . extent = arcpy . Extent ( xmin , ymin , xmax , ymax )

The issue is that line 20 does not contain layers, it contains a list of strings that represent layer names and you have no code that matches those layer names to actual layers. Also, as far as I can see your code should throw an error at line 25, because the variable lyr has never been initialized in your code. It seems like the code you posted is missing a for loop at line 24 that assigns each layer in the layers variable you created in line 19 to the lyr variable you are referencing in line 25. for lyr in layers: Line 36 should do a similar for loop and then be followed by an if statement that determines if the layer name is in the HTL_layer_list of names. Also, your code defines the HTL_ext variable, but does not define an ext variable, so I think you meant to use the HTL_ext variable throughout this section of code. This code will work: for HTL_lyr in layers: if HTL_lyr.name in HTL_layer_list: HTL_ext = HTL_lyr.getExtent() if HTL_ext.XMin xmax: xmax = HTL_ext.XMax if HTL_ext.YMax > ymax: ymax = HTL_ext.YMax

nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

How can I use a layer name with spaces in python?

LindsayRaabe_FPCWA

Hi All. I'm trying to run the below python code with no luck. The 2 layers listed on line 20 are referenced again on line 37 when I attempt to cycle through their extents. The code should pull the extents and apply them to the data frame. The issue is that the list at line 20 won't work unless there are no spaces in the layer names. If enclose the names in "..." then the code is "syntax error free" but fails at line 37 when trying to extract the extent of a string object instead of a layer. How can I work around this (would prefer to not have to rename my layers in the mxd!).

<SPAN class="keyword token">import</SPAN> arcpy
<SPAN class="keyword token">from</SPAN> arcpy <SPAN class="keyword token">import</SPAN> env<SPAN class="punctuation token">,</SPAN> mapping
<SPAN class="keyword token">from</SPAN> bisect <SPAN class="keyword token">import</SPAN> bisect

<SPAN class="comment token">#input parameters;</SPAN>
Plantation <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>GetParameter<SPAN class="punctuation token">(</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">)</SPAN>
ForestID <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>GetParameter<SPAN class="punctuation token">(</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">)</SPAN>
CommonName <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>GetParameter<SPAN class="punctuation token">(</SPAN><SPAN class="number token">2</SPAN><SPAN class="punctuation token">)</SPAN>
PYear <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>GetParameter<SPAN class="punctuation token">(</SPAN><SPAN class="number token">3</SPAN><SPAN class="punctuation token">)</SPAN>
OpCode <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>GetParameter<SPAN class="punctuation token">(</SPAN><SPAN class="number token">4</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token">#variables;</SPAN>
title1 <SPAN class="operator token">=</SPAN> Plantation <SPAN class="operator token">+</SPAN> <SPAN class="string token">" PLANTATION"</SPAN>
title2 <SPAN class="operator token">=</SPAN> Plantation <SPAN class="operator token">+</SPAN> <SPAN class="string token">"\r\nPLANTATION"</SPAN>
title3 <SPAN class="operator token">=</SPAN> Plantation <SPAN class="operator token">+</SPAN> <SPAN class="string token">" ("</SPAN> <SPAN class="operator token">+</SPAN> CommonName <SPAN class="operator token">+</SPAN> <SPAN class="string token">")"</SPAN>
title4 <SPAN class="operator token">=</SPAN> Plantation <SPAN class="operator token">+</SPAN> <SPAN class="string token">" P"</SPAN> <SPAN class="operator token">+</SPAN> PYear <SPAN class="operator token">+</SPAN> <SPAN class="string token">" AREA STATEMENT"</SPAN>
mxd <SPAN class="operator token">=</SPAN> mapping<SPAN class="punctuation token">.</SPAN>MapDocument<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"CURRENT"</SPAN><SPAN class="punctuation token">)</SPAN>
elements <SPAN class="operator token">=</SPAN> mapping<SPAN class="punctuation token">.</SPAN>ListLayoutElements<SPAN class="punctuation token">(</SPAN>mxd<SPAN class="punctuation token">)</SPAN>
layers <SPAN class="operator token">=</SPAN> mapping<SPAN class="punctuation token">.</SPAN>ListLayers<SPAN class="punctuation token">(</SPAN>mxd<SPAN class="punctuation token">)</SPAN>
HTL_layer_list <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">"Entered In GeoMaster"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"Entered In GeoMaster Archive"</SPAN><SPAN class="punctuation token">]</SPAN>
dflist <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>mapping<SPAN class="punctuation token">.</SPAN>ListDataFrames<SPAN class="punctuation token">(</SPAN>mxd<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">""</SPAN><SPAN class="punctuation token">)</SPAN>
opcode_exp1 <SPAN class="operator token">=</SPAN> <SPAN class="string token">"EnteredInGeoMaster IS NOT NULL AND Ops_Code = '"</SPAN> <SPAN class="operator token">+</SPAN> OpCode <SPAN class="operator token">+</SPAN> <SPAN class="string token">"'"</SPAN>
opcode_exp2 <SPAN class="operator token">=</SPAN> <SPAN class="string token">"Ops_Code = '"</SPAN> <SPAN class="operator token">+</SPAN> OpCode <SPAN class="operator token">+</SPAN> <SPAN class="string token">"'"</SPAN>

&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">if</SPAN> lyr<SPAN class="punctuation token">.</SPAN>name <SPAN class="operator token">==</SPAN> <SPAN class="string token">"Entered In GeoMaster"</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; lyr<SPAN class="punctuation token">.</SPAN>definitionQuery <SPAN class="operator token">=</SPAN> opcode_exp1
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; arcpy<SPAN class="punctuation token">.</SPAN>AddMessage<SPAN class="punctuation token">(</SPAN>lyr<SPAN class="punctuation token">.</SPAN>name <SPAN class="operator token">+</SPAN> <SPAN class="string token">" definition query updated"</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 
&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">elif</SPAN> lyr<SPAN class="punctuation token">.</SPAN>name <SPAN class="operator token">==</SPAN> <SPAN class="string token">"Entered In GeoMaster Archive"</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; lyr<SPAN class="punctuation token">.</SPAN>definitionQuery <SPAN class="operator token">=</SPAN> opcode_exp2
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; arcpy<SPAN class="punctuation token">.</SPAN>AddMessage<SPAN class="punctuation token">(</SPAN>lyr<SPAN class="punctuation token">.</SPAN>name <SPAN class="operator token">+</SPAN> <SPAN class="string token">" definition query updated"</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token"># get current map extent</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; xmin<SPAN class="punctuation token">,</SPAN> xmax <SPAN class="operator token">=</SPAN> dflist<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">.</SPAN>extent<SPAN class="punctuation token">.</SPAN>XMin<SPAN class="punctuation token">,</SPAN> dflist<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">.</SPAN>extent<SPAN class="punctuation token">.</SPAN>XMax
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ymin<SPAN class="punctuation token">,</SPAN> ymax <SPAN class="operator token">=</SPAN> dflist<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">.</SPAN>extent<SPAN class="punctuation token">.</SPAN>YMin<SPAN class="punctuation token">,</SPAN> dflist<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">.</SPAN>extent<SPAN class="punctuation token">.</SPAN>YMax
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token"># loop through def query layer extents and create one extent to fit them all</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">for</SPAN> HTL_lyr <SPAN class="keyword token">in</SPAN> HTL_layer_list<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; HTL_ext <SPAN class="operator token">=</SPAN> HTL_lyr<SPAN class="punctuation token">.</SPAN>getExtent<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">if</SPAN> HTL_ext<SPAN class="punctuation token">.</SPAN>XMin <SPAN class="operator token"><</SPAN> xmin<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; xmin <SPAN class="operator token">=</SPAN> ext<SPAN class="punctuation token">.</SPAN>XMin
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">if</SPAN> HTL_ext<SPAN class="punctuation token">.</SPAN>YMin <SPAN class="operator token"><</SPAN> ymin<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ymin <SPAN class="operator token">=</SPAN> ext<SPAN class="punctuation token">.</SPAN>YMin
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">if</SPAN> HTL_ext<SPAN class="punctuation token">.</SPAN>XMax <SPAN class="operator token">></SPAN> xmax<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; xmax <SPAN class="operator token">=</SPAN> ext<SPAN class="punctuation token">.</SPAN>XMax
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">if</SPAN> HTL_ext<SPAN class="punctuation token">.</SPAN>YMax <SPAN class="operator token">></SPAN> ymax<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ymax <SPAN class="operator token">=</SPAN> ext<SPAN class="punctuation token">.</SPAN>YMax
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="comment token"># set df extent to new extent</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; dflist<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">.</SPAN>extent <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>Extent<SPAN class="punctuation token">(</SPAN>xmin<SPAN class="punctuation token">,</SPAN> ymin<SPAN class="punctuation token">,</SPAN> xmax<SPAN class="punctuation token">,</SPAN> ymax<SPAN class="punctuation token">)</SPAN>‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Find more posts tagged with

Accepted answers

RichardFairhurst

The issue is that line 20 does not contain layers, it contains a list of strings that represent layer names and you have no code that matches those layer names to actual layers. Also, as far as I can see your code should throw an error at line 25, because the variable lyr has never been initialized in your code. It seems like the code you posted is missing a for loop at line 24 that assigns each layer in the layers variable you created in line 19 to the lyr variable you are referencing in line 25.

for lyr in layers:‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN></SPAN>

Line 36 should do a similar for loop and then be followed by an if statement that determines if the layer name is in the HTL_layer_list of names. Also, your code defines the HTL_ext variable, but does not define an ext variable, so I think you meant to use the HTL_ext variable throughout this section of code. This code will work:

for HTL_lyr in layers:
&nbsp; if HTL_lyr.name in HTL_layer_list:
&nbsp;&nbsp;&nbsp; HTL_ext = HTL_lyr.getExtent()
&nbsp;&nbsp;&nbsp; if HTL_ext.XMin < xmin:
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; xmin = HTL_ext.XMin
&nbsp;&nbsp;&nbsp; if HTL_ext.YMin < ymin:
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ymin = HTL_ext.YMin
&nbsp;&nbsp;&nbsp; if HTL_ext.XMax > xmax:
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; xmax = HTL_ext.XMax
&nbsp;&nbsp;&nbsp; if HTL_ext.YMax > ymax:
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ymax = HTL_ext.YMax‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

All comments

LindsayRaabe_FPCWA

Thanks. I'm going to try both solutions and I think both will likely work form the logic I'm reading.

LindsayRaabe_FPCWA

Good pickup on the missing "for lyr in layers" statement. The code was a cut down of a larger script and I missed copying the first line of that section so that's all good. I'll give the "if HTL_lyr.name in HTL_layerl_list:" section a try and see what happens. Thanks!

RichardFairhurst

for lyr in layers:‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN></SPAN>

for HTL_lyr in layers:
&nbsp; if HTL_lyr.name in HTL_layer_list:
&nbsp;&nbsp;&nbsp; HTL_ext = HTL_lyr.getExtent()
&nbsp;&nbsp;&nbsp; if HTL_ext.XMin < xmin:
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; xmin = HTL_ext.XMin
&nbsp;&nbsp;&nbsp; if HTL_ext.YMin < ymin:
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ymin = HTL_ext.YMin
&nbsp;&nbsp;&nbsp; if HTL_ext.XMax > xmax:
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; xmax = HTL_ext.XMax
&nbsp;&nbsp;&nbsp; if HTL_ext.YMax > ymax:
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ymax = HTL_ext.YMax‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

JoshuaBixby

The issue is that the list at line 20 won't work unless there are no spaces in the layer names.

It is helpful to provide the text of the error along with the Traceback. If no error is generated, describing what you expect to happen and what is happening is helpful.

If this is being run from within ArcMap, you will likely need to call RefreshActiveView—Help | ArcGIS Desktop for the changes to the definition query to take effect.

PeteCrosier

This should do it..

layer = arcpy.mapping.Layer("This is a layer in my open MXD")
layer.getExtent().XMin

Join the Conversation

Signed in members can post, follow updates, and more. New here? Register a free account.

Quick Links

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.