Filling in atrributes for a point layer from a underlying polygon layer

BretWhiteley1

I am using the following script to grab parcel and address information from one layer to fill the attribute table of a newly created feature.

There is no returned error, but the problem I am having is that there seems to be the wrong information stuck in the memory of recordselect function.  No matter where I place a point it gives the same parcel # and address. Or maybe it isn???t actually be performing the IF function properly. 


Sub Address

                Dim rsCurrentXY
                Set rsCurrentXY = Map.Layers("Violations").records
                rsCurrentXY.movelast
                Dim objXYShape
                Set objXYShape = rsCurrentXY.Fields.Shape
                Dim pControls
                Set pControls= Application.Map.selectionlayer.Forms("EDITFORM").Pages(???PAGE1???).Controls
                Dim rsGrid          
                ' Find corresponding map page to the valve point
                Set rsGrid = Map.Layers("ACPA_parcels").records
                rsGrid.movefirst
               
                Do While Not rsGrid.eof
                                If rsGrid.fields.shape.Ispointin(objXYShape) Then
                                                pControls("txtAddress").value = rsGrid.Fields("ADD1").Value
                               
                                                Exit Do
                                End If
                                rsGrid.Movenext
                Loop     
               

                ' Clean Up
                Set rsCurrentXY = Nothing
                Set objXYShape = Nothing
                Set rsGrid = Nothing
End Sub


(I have another subroutine called "PIN" that would do the exact same thing.)
I have them called when their respective edit boxes in the custom form are activated by the inspector.

Thanks for the help,
Robert

ThaiTruong

Attached is a subset of parcels. Thanks so much for taking the time. 

I'll be in the office early tomorrow.

Because you have a large parcels dataset, using IsPointIn() will slow down your data capture process.  it has to loop through all the records inside your pacel layer to find one that contains the point.
So, in your case, I would use FindNearestXY() to find a parcel intersected with the collected point.  This will perform much better on a large datasets like your.

So, here is a new "InitilizeForm" sub for you.  Let me know if it works for you.

Sub InitilizeForm  Dim objLayer  'Get a reference to the first layer  Set objLayer = Application.Map.Layers("Violations")   Dim objEditForm  Set objEditForm = objLayer.forms("EDITFORM")   Dim pControls  Set pControls = ThisEvent.Object.Pages("PAGE1").Controls   Dim dblX, dblY  dblX = Map.PointerX    dblY = Map.PointerY   'Call when adding a new feature  If objEditForm.Mode = 3 Then   pControls("txtAddress").value = ""   pControls("txtPIN").value = ""    'Find Address & PIN # from Parcels Layer   Dim objParcels   Set objParcels = Application.Map.Layers("Parcels")   Dim rsGrid   Set rsGrid = objParcels.Records    Dim Rec   Rec = rsGrid.FindNearestXY(dblX,dblY,0,map.Extent)   If Rec > 0 Then    rsGrid.MoveFirst    rsGrid.move(Rec -1)    pControls("txtAddress").value = rsGrid.Fields("ADDR1").Value    pControls("txtPIN").value = rsGrid.Fields("PIN").Value   End If  End If   Set objLayer = Nothing  Set objEditForm = Nothing  Set pControls = Nothing  Set dblX = Nothing  Set dblY = Nothing  Set objParcels = Nothing  Set rsGrid = Nothing  Set Rec = Nothing End Sub