Same AR as been used for a year and only changed numbers, now doesn't work

Question

Hello,

AR drive me nuts.  I've got AR that have been working for two years!  Have not upgraded from the same version written in (3.2.4); yet, I have only changed numbers for calculations and now all of a sudden - 'Close parenthesis expected'.  Line where it showing needing is:

if ((parea > 0) && (billclass == ""V: Vacant"") && (dor < 6647 && dor > 5399)) {
    newfee = (((parea/43560)*(12*(0.1*(12.138))))+242.76)
    }

Extra parans around the 12.138 was due to attempting to use a variable set earlier that would do the calcs to get these numbers without having to manually add them in.  But that didn't work either.  Then it continues with else if.  Again, only the 12.138 and 242.76 were changed in the line.  When checking in notepad ++, all parentheses are matched.  Checked the whole script.  All braces are matched as well.  This script was edited the same way last year as well and worked.

Thanks,

Lorinda

ChrisUnderwood · Answer

Hello @LorindaGilbert , the problem seems to be with the duplicated quotation marks around ""V: Vacant""

If you use "V: Vacant" or '"V: Vacant"' instead, then it evaluates as valid.

ChrisUnderwood · Answer

Hello @LorindaGilbert  , perhaps the data has changed so it now follows a different path through your logic to an error that it avoided before ?

I don't like this section(s) : pimparea - runway > 0
Presumably you mean this : (pimparea - runway) > 0
But maybe it could be interpreted as this : pimparea - (runway > 0)

Otherwise, are you able to post a version of your code with hardcoded var values so that we can try it without your data, eg var dor = 6000 rather than var dor = $feature.IDFUseCode

ToddW_stl · Answer

Have you ever tried to use the When Arcade function?  I see some duplicate else if sections, but i'm not sure that's causing your issue.