Dictionary to FeatureSet issues. Probably the dictionary format?

Question

I'm struggling to work out what I'm doing wrong trying to convert this Dictionary to a FeatureSet. I'm getting an invalid parameter error.

var fs = FeatureSetByPortalItem(
    portal,
    id,
    0,
    fields,
    False
)

var combinedFeatures = [];

for (var f in fs) {
        Push(combinedFeatures, {
            "Variety": f["variety1"],
            "Area": f["var1_perc"]
        });
        Push(combinedFeatures, {
            "Variety": f["variety2"],
            "Area": f["var2_perc"]
        });
        Push(combinedFeatures, {
            "Variety": f["variety3"],
            "Area": f["var3_perc"]
        });
};

var schema = { fields: [
    { name: "Variety", type: "esriFieldTypeString" },
    { name: "Area", type: "esriFieldTypeSmallInteger" }
]};

var d = Dictionary(Text(combinedFeatures, schema));

Console(d)

return FeatureSet(d)

My dictionary, as shown by Console(), looks like this:

{"0":{"Variety":null,"Area":0},"1":{"Variety":null,"Area":0},"2":{"Variety":null,"Area":0},"3":{"Variety":null,"Area":0},"4":{"Variety":null,"Area":0},"5":{"Variety":null,"Area":0},"6":{"Variety":null,"Area":0},"7":{"Variety":null,"Area":0},"8":{"Variety":null,"Area":0},"9":{"Variety":null,"Area":0},"10":{"Variety":null,"Area":0},"11":{"Variety":null,"Area":0},"12":{"Variety":null,"Area":0},..............

kenbuja · Accepted Answer

I believe what you're trying to do would be like this

var fs = FeatureSetByPortalItem(
    portal,
    id,
    0,
    fields,
    False
)

var combinedFeatures = [];

for (var f in fs) {
  Push(
    combinedFeatures,
    { attributes: { Variety: f["variety1"], Area: f["var1_perc"] } }
  );
  Push(
    combinedFeatures,
    { attributes: { Variety: f["variety2"], Area: f["var2_perc"] } }
  );
  Push(
    combinedFeatures,
    { attributes: { Variety: f["variety3"], Area: f["var3_perc"] } }
  );
}

var combinedDict = {
  fields: [
    { name: "Variety", type: "esriFieldTypeString" },
    { name: "Area", type: "esriFieldTypeInteger" }
  ],
  geometryType: "",
  features: combinedFeatures
};

var d = Dictionary(combinedDict);

Console(d);

return FeatureSet(d);