Arcade Pop-Up. First two functions work, while third fails.

JohnDriessen

Hi folks, thanks for any assistance you can offer.  Being somewhat new to Arcade I'm sure this is an amateur mistake.

Problem:  The first two lines of code work as they should.  An IFF statement to remove blank fields, followed by a prefix and suffix added to a field, creating a hyperlink.

Some of the fields (in this case ASBUILTS) need to be removed.  I've parsed those out and have a list of 30 which the find and replace with "" will run on.

//works

var ASBUILT = IIF(isEmpty($feature.AsBuiltFileName), "",
"https://asbuilts.ci.missoula.mt.us/water/" + $feature.AsBuiltFileName + ".pdf")

Replace(ASBUILT,"https://asbuilts.ci.missoula.mt.us/water/HH2-A.pdf","")

//doesn't work

var ASBUILT = IIF(isEmpty($feature.AsBuiltFileName), "",
"https://asbuilts.ci.missoula.mt.us/water/" + $feature.AsBuiltFileName + ".pdf")

Replace(ASBUILT,"https://asbuilts.ci.missoula.mt.us/water/HH2-A.pdf","")
Replace(ASBUILT,"https://asbuilts.ci.missoula.mt.us/water/010-A.pdf","")

jcarlson

If I'm understanding this correctly, you have a list of 30 values that should be removed?

While I can't be sure exactly why your code isn't working, you should know that the Replace function returns a string. Without assigning the results of that function to a variable, Arcade is going to treat that as having an implicit return. Meaning, it will read that function as providing the output of your full expression. This applies specifically when it's the final line of your expression.

In any case, those multiple Replace functions won't be doing what you think they will, and it's not the best approach.

Try something like this:

1. Establish a list of values to exclude
2. Check if your field is empty
3. If it is not empty, check if it's in the "excluded" list
4. If it's not in that list, assemble the string and return it.

This has the benefit of not needing to do a series of find/replace functions when the field is empty. If the field is empty, or it's in the exclude list, the expression simply stops there and doesn't return anything. Here's the code:

// List of items to exclude
var excluded = [
    'a',
    'list',
    'of',
    'values',
    'to',
    'exclude'
]

var asbuilt = $feature.AsBuiltFileName

var urlstart = 'https://asbuilts.ci.missoula.mt.us/water/'

// Check if not empty
if(!IsEmpty(asbuilt)){
    // Check if excluded
    if(!Includes(excluded, asbuilt)){
        return `${urlstart + asbuilt}.pdf`
    }
}

 

Here's me testing it against a couple of static values and a null value.