nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Trouble Understanding Get Count

cwh

Good day everyone,

I think I'm having some trouble understanding how to make use of Get Count. I have the following:

What I want to see happen is if Row Count = 0 > End the model. If Row Count > 0 continue the model. What I see is when Row Count > 0 the model continues and when Row Count = 0 it just seems to spin it's wheels for a bit (30 seconds) then end. I don't know if maybe it has something to do with Select Layer By Location using AddressSelect as it's Selecting Features? Or maybe I'm just using Get Count completely wrong and there's a different way I should be approaching this.

Thanks for the help,

Chris

Finde mehr Beiträge mit dem Tag

Accepted answers

curtvprice

The output of the Get Count tool is of type integer, which when it has the value of zero is interpreted as false when linked to the next tool in the chain as a precondition. This can cause problems when you want the tool to continue when the count is zero. In situations like that you are better off running the Get Count inside a Python function (arcpy.GetCount_management(lyr)) in the Calculate Value tool (that is, hiding the results from the Model Builder) and returning true or false as Boolean based on the Get Count result.

All comments

cwh

Quick update. I changed over to the following python script:

<SPAN class="keyword token">import</SPAN> arcpy
locno <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>GetParameterAsText<SPAN class="punctuation token">(</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">)</SPAN>
year <SPAN class="operator token">=</SPAN> locno<SPAN class="punctuation token">[</SPAN><SPAN class="number token">3</SPAN><SPAN class="punctuation token">:</SPAN><SPAN class="number token">7</SPAN><SPAN class="punctuation token">]</SPAN>
workspace <SPAN class="operator token">=</SPAN> <SPAN class="string token">"O:/plan/luam/1p2007/"</SPAN> <SPAN class="operator token">+</SPAN> year <SPAN class="operator token">+</SPAN> <SPAN class="string token">"/"</SPAN> <SPAN class="operator token">+</SPAN> locno <SPAN class="operator token">+</SPAN> <SPAN class="string token">"/data_for_item.gdb"</SPAN>
arcpy<SPAN class="punctuation token">.</SPAN>env<SPAN class="punctuation token">.</SPAN>workspace <SPAN class="operator token">=</SPAN> workspace
inFc <SPAN class="operator token">=</SPAN> <SPAN class="string token">'in_memory\AddressSelect'</SPAN>
numRecords <SPAN class="operator token">=</SPAN> int<SPAN class="punctuation token">(</SPAN>arcpy<SPAN class="punctuation token">.</SPAN>GetCount_management<SPAN class="punctuation token">(</SPAN>inFc<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">.</SPAN>getOutput<SPAN class="punctuation token">(</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN>
<SPAN class="keyword token">if</SPAN> numRecords <SPAN class="operator token">==</SPAN> <SPAN class="number token">0</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp; arcpy<SPAN class="punctuation token">.</SPAN>AddError<SPAN class="punctuation token">(</SPAN><SPAN class="string token">'Incorrect address. Please try again.'</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp; result <SPAN class="operator token">=</SPAN> <SPAN class="token boolean">False</SPAN>
<SPAN class="keyword token">else</SPAN><SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp; result <SPAN class="operator token">=</SPAN> <SPAN class="token boolean">True</SPAN>
arcpy<SPAN class="punctuation token">.</SPAN>SetParameterAsText<SPAN class="punctuation token">(</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">,</SPAN> result<SPAN class="punctuation token">)</SPAN>‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

I tried it both using AddWarning and AddError.

AddWarning gives the following to the output then continues to run through all tools/scripts providing either the message 'precondition is false' or 'inputs are not current':

AddError provides the following, and seems to be a bit 'cleaner' and I think easier for the end user to know that something is not right:

Something I find interesting is the script with AddWarning does display as Completed at the top left of the form while the AddError script shows Executing Test For Records... is that because in the case of AddWarning, the model did complete and with AddError it did not?

cwh

Super. Thanks for your time Curtis.

Sent from my iPhone

curtvprice

In response to this question:

Could there be a way to add in a arcpy.AddWarning("Incorrect address, try again") in addition to or in lieu of all of the precondition is false... inputs are not current...

Without building a python script to print the messages, you can do this in the Calculate Value tool. I have discovered you cannot embed "\n" in the Calculate value tool; I use chr(12) instead to print newlines.

Expression

test<SPAN class="punctuation token">(</SPAN>r<SPAN class="string token">"%AddressSelect%"</SPAN><SPAN class="punctuation token">)</SPAN>‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN></SPAN>

Code Block:

<SPAN class="keyword token">def</SPAN> <SPAN class="token function">test</SPAN><SPAN class="punctuation token">(</SPAN>lyr<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>&nbsp; 
&nbsp; <SPAN class="keyword token">if</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>GetCount_management<SPAN class="punctuation token">(</SPAN>lyr<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">.</SPAN>getOutput<SPAN class="punctuation token">(</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">)</SPAN> <SPAN class="operator token">==</SPAN> <SPAN class="string token">"0"</SPAN><SPAN class="punctuation token">:</SPAN>&nbsp;&nbsp;&nbsp; 
&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">return</SPAN> <SPAN class="string token">"{0}{0}Incorrect address{0}{0}"</SPAN><SPAN class="punctuation token">.</SPAN>format<SPAN class="punctuation token">(</SPAN>chr<SPAN class="punctuation token">(</SPAN><SPAN class="number token">12</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN>‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Data Type: String

This will print (in the middle of your messages):


Incorrect Address

‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

But I think no matter what you do you'll see all those warning messages about inputs not current. If you really want full control of messages, you need to start thinking about Python scripting. Model Builder is awesome, but it has its limits.

curtvprice

cwh

Upon further investigation, it looks like maybe it is working. When Row Count = 0 it continues going through all tools/scripts it just doesn't execute them, due to either "precondition is false" or "inputs are not current". The following is what is displayed. Now that I think it's working, would there be a way to add in a arcpy.AddWarning("Incorrect address, try again") in addition to or in lieu of all of the precondition is false... inputs are not current...

Thanks!

Executing: FinalModel22 "7 windermure rd sw" M-4

Start Time: Tue Nov 22 13:01:22 2016

Executing (GetLocNo): GetLocNoStart Time: Tue Nov 22 13:01:23 2016Running script GetLocNo...Completed script GetLocNo...Succeeded at Tue Nov 22 13:01:25 2016 (Elapsed Time: 2.50 seconds)Executing (Select): Select "Construction Layers\CALGIS.ADDRESS_POSSE" in_memory\AddressSelect "ADDRESS =UPPER('7 windermure rd sw')"Start Time: Tue Nov 22 13:01:25 2016WARNING 000117: Warning empty output generated. Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 0.73 seconds)Executing (Get Count): GetCount in_memory\AddressSelectStart Time: Tue Nov 22 13:01:26 2016Row Count = 0Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 0.00 seconds)Executing (Select Layer By Location): SelectLayerByLocation "Construction Layers\OPF - Ownership Parcel Fabric\CALGIS.OPF_PARCEL" INTERSECT in_memory\AddressSelect # NEW_SELECTIONStart Time: Tue Nov 22 13:01:26 2016The process did not execute because the precondition is false.Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 0.00 seconds)Executing (Zoom To Selected Feature): ZoomToSelectedStart Time: Tue Nov 22 13:01:26 2016All the inputs are not current.Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 0.00 seconds)Executing (Append): Append 'Construction Layers\OPF - Ownership Parcel Fabric\CALGIS.OPF_PARCEL' site_polygon NO_TEST # #Start Time: Tue Nov 22 13:01:26 2016All the inputs are not current.Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 0.00 seconds)Executing (Append (2)): Append 'Construction Layers\OPF - Ownership Parcel Fabric\CALGIS.OPF_PARCEL' "PROPOSED - proposed_LUD_polygon - OUTLINE" NO_TEST # #Start Time: Tue Nov 22 13:01:26 2016All the inputs are not current.Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 0.00 seconds)Executing (Update Proposed Lud Polygon Info): UpdateProposedLudPolygonInfo LOC2017-0016 M-4Start Time: Tue Nov 22 13:01:26 2016All the inputs are not current.Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 0.00 seconds)Executing (Update Site Polygon Info): UpdateSitePolygonInfo LOC2017-0016Start Time: Tue Nov 22 13:01:26 2016All the inputs are not current.Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 0.00 seconds)Executing (Set Scale): SetScale400Start Time: Tue Nov 22 13:01:26 2016All the inputs are not current.Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 0.00 seconds)Executing (Create Site Location): CreateSiteLocation #Start Time: Tue Nov 22 13:01:26 2016All the inputs are not current.Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 0.00 seconds)

Succeeded at Tue Nov 22 13:01:26 2016 (Elapsed Time: 3.44 seconds)

Nimm an der Unterhaltung teil

Angemeldete Mitglieder können Beiträge verfassen, Updates folgen und mehr. Neu hier? Registriere ein kostenloses Konto.

Anmelden
Registrieren

Schnellzugriffe

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.