Popups in ArcGIS v4.23 vs 4.11

TimDietz

Our app contained the following code snippet when configured to use 4.11:

popup.on('trigger-action', (event) => {
    const featureLocation = this.mapView.toMap(event.target.screenLocation);
}

We are now moving to 4.23 and the only event attribute is 'action', not 'target'. I can't quite figure out how to do it the new way. It looks like I might be able to do:

event.action.get(<something>)

but I don't know what the equivalent to 'screenLocation' would be.

Can somebody help with this and either point me to where I might find the event.action object or paste the equivalent statement?

TIA.

Tim

JoelBennett

I've found it to be working properly.  In the sandbox for the "Popup actions" sample, you can change the code in the script tag beginning on line 27 to the following:

      require([
        "esri/Map",
        "esri/layers/FeatureLayer",
        "esri/views/MapView",
        "esri/geometry/geometryEngine",
        "esri/core/reactiveUtils",
        "esri/widgets/Popup"
      ], (Map, FeatureLayer, MapView, geometryEngine, reactiveUtils, Popup) => {
        // Create the Map
        const map = new Map({
          basemap: "gray-vector"
        });

        // Create the MapView
        const view = new MapView({
          container: "viewDiv",
          map: map,
          center: [-117.08, 34.1],
          zoom: 11,
          popup: new Popup({})
        });

        /*************************************************************
         * The PopupTemplate content is the text that appears inside the
         * popup. Bracketed {fieldName} can be used to reference the value
         * of an attribute of the selected feature. HTML elements can be
         * used to provide structure and styles within the content.
         **************************************************************/

        // Add this action to the popup so it is always available in this view
        const measureThisAction = {
          title: "Measure Length",
          id: "measure-this",
          image:
            "https://developers.arcgis.com/javascript/latest/sample-code/popup-actions/live/Measure_Distance16.png"
        };

        const template = {
          // autocasts as new PopupTemplate()
          title: "Trail run",
          content: "{name}",
          actions: [measureThisAction]
        };

        const featureLayer = new FeatureLayer({
          url: "https://services.arcgis.com/V6ZHFr6zdgNZuVG0/arcgis/rest/services/TrailRuns/FeatureServer/0",
          popupTemplate: template
        });

        map.add(featureLayer);

        // Execute each time the "Measure Length" is clicked
        function measureThis() {
          const geom = view.popup.selectedFeature.geometry;
          const initDistance = geometryEngine.geodesicLength(geom, "miles");
          const distance = parseFloat(
            Math.round(initDistance * 100) / 100
          ).toFixed(2);
          view.popup.content =
            view.popup.selectedFeature.attributes.name +
            "<div style='background-color:DarkGray;color:white'>" +
            distance +
            " miles.</div>";
        }

        // Event handler that fires each time an action is clicked.
        reactiveUtils.on(
          () => view.popup,
          "trigger-action",
          (event) => {
            // Execute the measureThis() function if the measure-this action is clicked
            if (event.action.id === "measure-this") {
              measureThis();
            }
          }
        );

        view.popup.on("trigger-action", function(target, event) {
          const featureLocation = target.location;
          console.info(featureLocation.x + ", " + featureLocation.y);
          console.info(event.action.title);
          console.info(target);
          console.info(event);
        }.bind(this, view.popup));
      });

 

In the code above, changes to the original are found on lines 6-8, 19-20, and (primarily) 77-84.  After the sample is refreshed, clicking on a feature and then the "Measure Length" action in the popup produces the following in the console, showing the expected output:

If I had to guess as to why it isn't working for you, perhaps the call to bind was not made correctly.