nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Select Layer by Location not providing correct result.

SusanWhitney

I sought assistance with a portion of this code earlier. I have added an additional step, which to me would seem pretty simple, but I am still learning the ups & downs of Python.

My script creates data driven pages. I use a list to populate a layer definition query to run a specific township. Now I am trying to do a selection (SelectLayerByLocation) to only find the townships where there is data. I first just added the SelectLayerByLocation command. Did not work. With further reading, it looked like I needed to run a MakeFeatureLayer on the two sets of data involved in the selection. Still did not work. Do I need to use cursors or is the answer much simpler?

I do not have any error messages. I have added try/except to see if I can find additional information on what is happening with my script. The data exports just fine, but there are maps that do not have any data.
Thank you for any guidance.

# PoleDDpages.py # Author: slw # Date: xyz # Revisions: xyz # Description: Create Pole map book series using Data Driven Pages and #           insert a cover page  # Import ArcPy import os,arcpy  try:          # Set up variables     # Location of pole map .mxd document     mxdDoc = r"G:\GEOSPATIAL\Publishing\Pole\Pole_QtrSec.mxd"      # Create the MapDocument object     mxd = arcpy.mapping.MapDocument(mxdDoc)     df = arcpy.mapping.ListDataFrames(mxd)[0]     layer = arcpy.mapping.ListLayers (mxd, "SURVEY_GRID_BNDRY",df)[0]     poleLyr = arcpy.mapping.ListLayers (mxd, "Pole",df)[0]      # Overwrite existing file     arcpy.env.overwriteOutput = True      # Output directory for the pole maps     outDir = r"G:\GEOSPATIAL\Publishing\Pole"      # Set the workspace     arcpy.env.workspace = outDir      # List of map grids     twpList = ['\"TOWNSHIP_C\" = \'D5\' AND \"RANGE_CD\" = \'5\'',\                '\"TOWNSHIP_C\" = \'D6\' AND \"RANGE_CD\" = \'4\'']       i=1     for twpName in twpList:         layer.definitionQuery = twpName          # refresh() after changing the layer def query to 'redefine' the DDP index limits         mxd.dataDrivenPages.refresh()                 # Create temporary layers to work with the Selection         arcpy.MakeFeatureLayer_management(layer, "surveyLyr")         arcpy.MakeFeatureLayer_management(poleLyr, "poleLyr_new")          # Clear the Selection before starting         #arcpy.SelectLayerByAttribute_management("surveyLyr", "CLEAR_SELECTION", "")         #print "The selection has been cleared"                  # Select Layer By Location to limit to just maps with data         arcpy.SelectLayerByLocation_management("surveyLyr", "INTERSECT", "poleLyr_new", "", "NEW_SELECTION")          # refresh() after changing the layer def query to 'redefine' the DDP index limits         mxd.dataDrivenPages.refresh()          mxd.saveACopy(os.path.splitext(mxdDoc) [0] + str(i) + os.path.splitext(mxdDoc)[1])         i += 1                   # The final mapbook name taken from the list         finalPDFfn = outDir + "\\" + twpName [16:18] + twpName [38:39] + "Pole.pdf"                  # Create the final PDF -- which is just an empty shell right now         finalPDF = arcpy.mapping.PDFDocumentCreate(finalPDFfn)          # A temporary pdf file for processing         tmpPDF = outDir + "\\PoleMapPages.pdf"          # Let the user know what is happening!         print "Exporting " + twpName [16:18] + twpName [38:39]                  # Export the data driven pages in the mxd to a temporary PDF         print "Exporting map pages to the temporary PDF"         ddp = mxd.dataDrivenPages.exportToPDF(tmpPDF)          # Append the temporary pdf to the final pdf         # Cover, map pages, back cover         print "Appending Map Pages"         finalPDF.appendPages (r"G:\GEOSPATIAL\Publishing\Pole\PoleCovers\Covers_"\                               + twpName [16:18] + twpName [38:39] + ".pdf")         finalPDF.appendPages(tmpPDF)         finalPDF.appendPages(r"G:\GEOSPATIAL\Publishing\TwpGrid_Color8x11.pdf")          # Set properties for Adobe Reader and save PDF.         finalPDF.updateDocProperties(pdf_open_view = "USE_THUMBS", pdf_layout = "SINGLE_PAGE")         finalPDF.saveAndClose()          # Deleting temporary layers         arcpy.Delete_management("surveyLyr")         arcpy.Delete_management("poleLyr_new")      except Exception as e:     print e.message     print arcpy.GetMessages(2)      # Clean up print "Cleaning up" # Delete the temporary PDF using the ArcPy function if arcpy.Exists(tmpPDF):                  arcpy.Delete_management(tmpPDF)   # Delete objects del mxd, tmpPDF, ddp               # Finished message print "Map compilation completed. Please review the final output."

Najděte více příspěvků označených jako

Accepted answers

T__WayneWhitley

I know it is late - I feel somewhat remiss for not updating this sooner, but you know how it is when the reality of job demands interferes...
Important thing now is to post a working correction -- I believe the actual portion causing the error you were experiencing, Susan, was not the definition query and consequent DDP refreshing, but the part afterwards building the PDFs. The code is below - I still think it could be written a bit 'tighter' and if I have time to fool with it more later, I want to experiment with UpdateLayer for the index layer...but that's an aside. The code below should be functional, and is quite speedy - more time is taken (as I suspected) actually exporting and appending the pdfs.

Anyway, here it is, actually without any real error trapping...I ran it within IDLE to verify it is working code, checked the pdfs, etc. - correct the pathnames accordingly, strip out what you don't need, and so forth...

Enjoy,
Wayne

import os,arcpy  # Overwrite existing file arcpy.env.overwriteOutput = True  try:          # Set up variables     # Location of pole map .mxd document     mxdDoc = r'E:\qryDefTest\Pole_QtrSec\v10\Pole_QtrSec.mxd'      # Create the MapDocument object     mxd = arcpy.mapping.MapDocument(mxdDoc)     df = arcpy.mapping.ListDataFrames(mxd)[0]          layer = arcpy.mapping.ListLayers (mxd, "SURVEY_GRID_BNDRY",df)[0]     poleLyr = arcpy.mapping.ListLayers (mxd, "Pole",df)[0]      ##############     # Test the count of survey grids before processing     countSurveyGrid = int(arcpy.GetCount_management(layer).getOutput(0))     print "Count of All Survey Grids (Survey_Grid_Bndry) =  " + str(countSurveyGrid) + " pages"           SelectBy = [layer, poleLyr]     for lyr in SelectBy:           iniCount = int(arcpy.GetCount_management(lyr).getOutput(0))           print lyr.name + ' initial count: ' + str(iniCount)           if iniCount != 0:                arcpy.SelectLayerByAttribute_management(lyr, 'CLEAR_SELECTION')                outCount = int(arcpy.GetCount_management(lyr).getOutput(0))                print lyr.name + ' out count: ' + str(outCount)      # should now be properly 'initialized' with no prior selections, i.e., full complement datasets           arcpy.MakeFeatureLayer_management(layer, "surveyLyr")     arcpy.MakeFeatureLayer_management(poleLyr, "poleLyr_new")      countSurveyLyr = int(arcpy.GetCount_management("surveyLyr").getOutput(0))     print "Count of temp layer surveyLyr =  " + str(countSurveyLyr) + " pages"          # Select Layer By Location to limit to just maps with data     arcpy.SelectLayerByLocation_management("surveyLyr", "INTERSECT", "poleLyr_new", "", "NEW_SELECTION")      # Susan, check that this works, switching the selection...     # SelectLayerByAttribute_management (in_layer_or_view, {selection_type}, {where_clause})     arcpy.SelectLayerByAttribute_management("surveyLyr", "SWITCH_SELECTION")      # new code to get at OBJECTIDs to modify def query     IDs = []     rows = arcpy.SearchCursor("surveyLyr")     for row in rows:           IDs.append(row.OBJECTID)      del row, rows     print "delete row, rows"      subquery = '('     for each in IDs:          subquery = subquery + str(each) + ','      subquery = subquery[0:-1] + ')'     ################      # Output directory for the pole maps     outDir = r"E:\qryDefTest\Pole_QtrSec\commondata\userdata"      # Set the workspace     arcpy.env.workspace = outDir      # List of map grids     twpList = ['\"TOWNSHIP_C\" = \'D5\' AND \"RANGE_CD\" = \'5\'',\                '\"TOWNSHIP_C\" = \'C4\' AND \"RANGE_CD\" = \'7\'',\                '\"TOWNSHIP_C\" = \'B8\' AND \"RANGE_CD\" = \'4\'']      i = 1      for twpName in twpList:         # modified the definitionQuery to include the subquery exclusion clause         layer.definitionQuery = twpName + " AND \"OBJECTID\" NOT IN " + str(subquery)         countDefQryLyr = int(arcpy.GetCount_management(layer).getOutput(0))         print '-'         print "Count of temp layer surveyLyr =  " + str(countDefQryLyr) + " pages"          # refresh() after changing the layer def query to 'redefine' the DDP index limits         mxd.dataDrivenPages.refresh()          mxd.saveACopy(os.path.join(outDir, 'test' + str(i) + '.mxd'))         i += 1          testTxt = twpName [16:18] + twpName [38:39] + "Pole.pdf"         #finalPDFfn = outDir + "\\" + twpName [16:18] + twpName [38:39] + "Pole.pdf"         finalPDFfn = os.path.join(outDir, testTxt)         print finalPDFfn          # just before you create it, make sure you delete the last var ref         if os.path.exists(finalPDFfn):             os.remove(finalPDFfn)         finalPDF = arcpy.mapping.PDFDocumentCreate(finalPDFfn)          tmpPDF = outDir + "\\PoleMapPages.pdf"         print 'exporting ' + testTxt         print '...to ' + tmpPDF          if os.path.exists(tmpPDF):             os.remove(tmpPDF)         mxd.dataDrivenPages.exportToPDF(tmpPDF, 'ALL')          print "Appending Map Pages"         Cover = os.path.join(outDir, "Covers_" + testTxt[0:-8] + ".pdf")         print "Appending this page 1st: " + Cover         finalPDF.appendPages(Cover)         print '\n...now appending the rest:'         print tmpPDF         finalPDF.appendPages(tmpPDF)          # final closing treatment         finalPDF.updateDocProperties(pdf_open_view = "USE_THUMBS", pdf_layout = "SINGLE_PAGE")         finalPDF.saveAndClose()         print "\nSave and Close"  except:     print 'error'

All comments

SusanWhitney

Wayne,
You are the best. The script is working beautifully. Thank you for your time and assistance.

T__WayneWhitley

import os,arcpy  # Overwrite existing file arcpy.env.overwriteOutput = True  try:          # Set up variables     # Location of pole map .mxd document     mxdDoc = r'E:\qryDefTest\Pole_QtrSec\v10\Pole_QtrSec.mxd'      # Create the MapDocument object     mxd = arcpy.mapping.MapDocument(mxdDoc)     df = arcpy.mapping.ListDataFrames(mxd)[0]          layer = arcpy.mapping.ListLayers (mxd, "SURVEY_GRID_BNDRY",df)[0]     poleLyr = arcpy.mapping.ListLayers (mxd, "Pole",df)[0]      ##############     # Test the count of survey grids before processing     countSurveyGrid = int(arcpy.GetCount_management(layer).getOutput(0))     print "Count of All Survey Grids (Survey_Grid_Bndry) =  " + str(countSurveyGrid) + " pages"           SelectBy = [layer, poleLyr]     for lyr in SelectBy:           iniCount = int(arcpy.GetCount_management(lyr).getOutput(0))           print lyr.name + ' initial count: ' + str(iniCount)           if iniCount != 0:                arcpy.SelectLayerByAttribute_management(lyr, 'CLEAR_SELECTION')                outCount = int(arcpy.GetCount_management(lyr).getOutput(0))                print lyr.name + ' out count: ' + str(outCount)      # should now be properly 'initialized' with no prior selections, i.e., full complement datasets           arcpy.MakeFeatureLayer_management(layer, "surveyLyr")     arcpy.MakeFeatureLayer_management(poleLyr, "poleLyr_new")      countSurveyLyr = int(arcpy.GetCount_management("surveyLyr").getOutput(0))     print "Count of temp layer surveyLyr =  " + str(countSurveyLyr) + " pages"          # Select Layer By Location to limit to just maps with data     arcpy.SelectLayerByLocation_management("surveyLyr", "INTERSECT", "poleLyr_new", "", "NEW_SELECTION")      # Susan, check that this works, switching the selection...     # SelectLayerByAttribute_management (in_layer_or_view, {selection_type}, {where_clause})     arcpy.SelectLayerByAttribute_management("surveyLyr", "SWITCH_SELECTION")      # new code to get at OBJECTIDs to modify def query     IDs = []     rows = arcpy.SearchCursor("surveyLyr")     for row in rows:           IDs.append(row.OBJECTID)      del row, rows     print "delete row, rows"      subquery = '('     for each in IDs:          subquery = subquery + str(each) + ','      subquery = subquery[0:-1] + ')'     ################      # Output directory for the pole maps     outDir = r"E:\qryDefTest\Pole_QtrSec\commondata\userdata"      # Set the workspace     arcpy.env.workspace = outDir      # List of map grids     twpList = ['\"TOWNSHIP_C\" = \'D5\' AND \"RANGE_CD\" = \'5\'',\                '\"TOWNSHIP_C\" = \'C4\' AND \"RANGE_CD\" = \'7\'',\                '\"TOWNSHIP_C\" = \'B8\' AND \"RANGE_CD\" = \'4\'']      i = 1      for twpName in twpList:         # modified the definitionQuery to include the subquery exclusion clause         layer.definitionQuery = twpName + " AND \"OBJECTID\" NOT IN " + str(subquery)         countDefQryLyr = int(arcpy.GetCount_management(layer).getOutput(0))         print '-'         print "Count of temp layer surveyLyr =  " + str(countDefQryLyr) + " pages"          # refresh() after changing the layer def query to 'redefine' the DDP index limits         mxd.dataDrivenPages.refresh()          mxd.saveACopy(os.path.join(outDir, 'test' + str(i) + '.mxd'))         i += 1          testTxt = twpName [16:18] + twpName [38:39] + "Pole.pdf"         #finalPDFfn = outDir + "\\" + twpName [16:18] + twpName [38:39] + "Pole.pdf"         finalPDFfn = os.path.join(outDir, testTxt)         print finalPDFfn          # just before you create it, make sure you delete the last var ref         if os.path.exists(finalPDFfn):             os.remove(finalPDFfn)         finalPDF = arcpy.mapping.PDFDocumentCreate(finalPDFfn)          tmpPDF = outDir + "\\PoleMapPages.pdf"         print 'exporting ' + testTxt         print '...to ' + tmpPDF          if os.path.exists(tmpPDF):             os.remove(tmpPDF)         mxd.dataDrivenPages.exportToPDF(tmpPDF, 'ALL')          print "Appending Map Pages"         Cover = os.path.join(outDir, "Covers_" + testTxt[0:-8] + ".pdf")         print "Appending this page 1st: " + Cover         finalPDF.appendPages(Cover)         print '\n...now appending the rest:'         print tmpPDF         finalPDF.appendPages(tmpPDF)          # final closing treatment         finalPDF.updateDocProperties(pdf_open_view = "USE_THUMBS", pdf_layout = "SINGLE_PAGE")         finalPDF.saveAndClose()         print "\nSave and Close"  except:     print 'error'

T__WayneWhitley

Susan, I sent you a private message, if you'll check that. Also, I have a hunch if you want to test it. That's the only reason I am replying here again at this time. If the hunch doesn't prove or fix anything, then I'll try to dissect the code and look at your test data later, probably report back to you in another private message as this thread is getting pretty long.

If you're 100 percent sure you should have output from the selection query formed in your loop to pass to the final export code section and you are also confident that final section works fine, then my hunch is the Make Feature Layer operation to test the count needs to be cleared...so I suggest moving the 1 line where you are deleting layers outside the loop for 'test the count':

arcpy.Delete_management("testTheCount")

Move it up just after you set the integer variable, gridsToOuput. You can place it just before or just after your print statement that you said was reporting zero (0) on successive iterations. What you can also do is test the 'initial' count on 'layer' - this is before applying the query (remember layer is your map "SURVEY_GRID_BNDRY" which you turned into a 'virtual' or in-memory layer, "surveyLyr"). This count should be the same on successive loops, you set up the loop to further refine by TWN/RNG - by now you should know how to make a GetCount statement. You can very quickly lose track of all your virtual layers...why testing to see exactly what you have a handle on is what you think it is.

Hope that tells you something...that's what all this testing is about - you'll eventually unravel the mystery! (and it may not be much to trip up the whole works)

-Wayne

SusanWhitney

Good morning,
I am sorry to be such a needy scripter. If you don't have the time to look at this, I understand.
I used the last code that you wrote and put 3 townships in my list. All 3 townships should result in pages with data in the .pdf. The script only outputs the first map, and then shows that the next two maps have zero pages. I have attached a map package. This contains the pole data to be displayed, the index layer, and the pole layer to be used for intersection. It also contains a back cover and 4 cover pages. I included the data for the 3 townships with data and one without (D64).
Thank you

# PoleDDpages.py
# Author: slw
# Date: xyz
# Revisions: xyz
# Description: Create Pole map book series using Data Driven Pages and
#           insert a cover page

# Import ArcPy
import os,arcpy

# Overwrite existing file
arcpy.env.overwriteOutput = True

try:
    
    # Set up variables
    # Location of pole map .mxd document
    mxdDoc = r"G:\GEOSPATIAL\Publishing\Pole\Pole_QtrSec.mxd"

    # Create the MapDocument object
    mxd = arcpy.mapping.MapDocument(mxdDoc)
    df = arcpy.mapping.ListDataFrames(mxd)[0]
    layer = arcpy.mapping.ListLayers (mxd, "SURVEY_GRID_BNDRY",df)[0]
    poleLyr = arcpy.mapping.ListLayers (mxd, "Pole",df)[0]

    ################
    # moved part of code to select grids (layer) intersecting 'Pole' features (poleLyr)
    # Create temporary layers to work with the Selection,
    # 1st need to assure no prior selections...the sel by loc syntax:
    # SelectLayerByLocation_management (in_layer, {overlap_type}, {select_features}, {search_distance}, {selection_type})
    # in_layer is the index layer; select_features is the pole layer
    
    SelectBy = [layer, poleLyr]
    for lyr in SelectBy:
          iniCount = int(arcpy.GetCount_management(lyr).getOutput(0))
          if iniCount != 0:
               arcpy.SelectLayerByAttribute_management(lyr, 'CLEAR_SELECTION')

    # should now be properly 'initialized' with no prior selections, i.e., full complement datasets      
    arcpy.MakeFeatureLayer_management(layer, "surveyLyr")
    arcpy.MakeFeatureLayer_management(poleLyr, "poleLyr_new")
        
    # Select Layer By Location to limit to just maps with data
    arcpy.SelectLayerByLocation_management("surveyLyr", "INTERSECT", "poleLyr_new", "", "NEW_SELECTION")

    # Susan, check that this works, switching the selection...
    # SelectLayerByAttribute_management (in_layer_or_view, {selection_type}, {where_clause})
    arcpy.SelectLayerByAttribute_management("surveyLyr", "SWITCH_SELECTION")

    # new code to get at OBJECTIDs to modify def query
    IDs = []
    rows = arcpy.SearchCursor("surveyLyr")
    for row in rows:
          IDs.append(row.OBJECTID)

    del row, rows

    subquery = '('
    for each in IDs:
         subquery = subquery + str(each) + ','

    subquery = subquery[0:-1] + ')'
    ################

    # Output directory for the pole maps
    outDir = r"G:\GEOSPATIAL\Publishing\Pole"

    # Set the workspace
    arcpy.env.workspace = outDir

    # List of map grids
    twpList = ['\"TOWNSHIP_C\" = \'D5\' AND \"RANGE_CD\" = \'5\'',\
               '\"TOWNSHIP_C\" = \'C4\' AND \"RANGE_CD\" = \'7\'',\
               '\"TOWNSHIP_C\" = \'B8\' AND \"RANGE_CD\" = \'4\'']

    for twpName in twpList:
        # need to test the twpName with the added subquery for empty return 1st
        theQuery = twpName + " AND \"OBJECTID\" NOT IN " + str(subquery)

        # create a feature layer on index with which to test theQuery for empty set
        # MakeFeatureLayer_management (in_features, out_layer, {where_clause})
        arcpy.MakeFeatureLayer_management(layer, "testTheCount", theQuery)
        gridsToOutput = int(arcpy.GetCount_management("testTheCount").getOutput(0))
        print "Output " + str(gridsToOutput) + " pages"

        if gridsToOutput != 0:

            # modified the definitionQuery to include the subquery exclusion clause
            layer.definitionQuery = theQuery

            # refresh() after changing the layer def query to 'redefine' the DDP index limits
            print "Refresh DDP"
            mxd.dataDrivenPages.refresh()
             
            # The final mapbook name taken from the list
            finalPDFfn = outDir + "\\" + twpName [16:18] + twpName [38:39] + "Pole.pdf"
            
            # Create the final PDF -- which is just an empty shell right now
            finalPDF = arcpy.mapping.PDFDocumentCreate(finalPDFfn)

            # A temporary pdf file for processing
            tmpPDF = outDir + "\\PoleMapPages.pdf"

            # Let the user know what is happening!
            print "Exporting " + twpName [16:18] + twpName [38:39]
            
            # Export the data driven pages in the mxd to a temporary PDF
            print "Exporting map pages to the temporary PDF"
            ddp = mxd.dataDrivenPages.exportToPDF(tmpPDF)

            # Append the temporary pdf to the final pdf
            # Cover, map pages, back cover
            print "Appending Map Pages"
            finalPDF.appendPages (r"G:\GEOSPATIAL\Publishing\Pole\PoleCovers\Covers_"\
                                  + twpName [16:18] + twpName [38:39] + ".pdf")
            finalPDF.appendPages(tmpPDF)
            finalPDF.appendPages(r"G:\GEOSPATIAL\Publishing\TwpGrid_BW8x11.pdf")

            # Set properties for Adobe Reader and save PDF.
            finalPDF.updateDocProperties(pdf_open_view = "USE_THUMBS", pdf_layout = "SINGLE_PAGE")
            finalPDF.saveAndClose()

    # Deleting temporary layers
    arcpy.Delete_management("surveyLyr")
    arcpy.Delete_management("poleLyr_new")
    arcpy.Delete_management("testTheCount")

except Exception as e:
    print e.message
    print arcpy.GetMessages(2)
    
# Clean up
print "Cleaning up"
# Delete the temporary PDF using the ArcPy function
if arcpy.Exists(tmpPDF):         
        arcpy.Delete_management(tmpPDF)  
# Delete objects
del mxd, tmpPDF, ddp             

# Finished message
print "Map compilation completed. Please review the final output."

Pole_QtrSec.mpk.zip

SusanWhitney

Just as a follow up. I am working on this between other items. I have added print statements and I have replaced the township that does not have any resulting data with one that does. I get the same result with the last code that you provided. The script will look at D55, print that it has 2 pages, and create the .pdf. It then shows the next township (now using B84) has zero pages. I am working on deciphering some of the code (remember I am a newbie) so maybe I can find out why subsequent townships count as zero pages.

Thank you,
Susan

T__WayneWhitley

Repost your code, as it is now, or if you only changed the query, post that part - guess you mean the list, twpList, now has a 3rd member?

Also, check all your 'virtual' or in-mem feature layer references - could be that's getting out of control, maybe indention isn't right or something is not being cleared. No errors, right?

One more thing, print and manually check what the separate queries produce, as before when I had you troubleshoot manually refreshing the DDP.

...I haven't looked at you export process yet - are there any references there that aren't behaving?

Enjoy,
Wayne

SusanWhitney

I now have 3 townships in my list. The first and last have data, the middle or second one will result in no map sheets or no poles. The script will create the first .pdf but will not create the third .pdf ... Do we need an elif statement?

T__WayneWhitley

Susan, test this please - added 'if' block to test for empty set as a result of query...think I got the indention right, but check:

# PoleDDpages.py
# Author: slw
# Date: xyz
# Revisions: xyz
# Description: Create Pole map book series using Data Driven Pages and
#           insert a cover page

# Import ArcPy
import os,arcpy

# Overwrite existing file
arcpy.env.overwriteOutput = True

try:
    
    # Set up variables
    # Location of pole map .mxd document
    mxdDoc = r"G:\GEOSPATIAL\Publishing\Pole\Pole_QtrSec.mxd"

    # Create the MapDocument object
    mxd = arcpy.mapping.MapDocument(mxdDoc)
    df = arcpy.mapping.ListDataFrames(mxd)[0]
    layer = arcpy.mapping.ListLayers (mxd, "SURVEY_GRID_BNDRY",df)[0]
    poleLyr = arcpy.mapping.ListLayers (mxd, "Pole",df)[0]

    ################
    # moved part of code to select grids (layer) intersecting 'Pole' features (poleLyr)
    # Create temporary layers to work with the Selection,
    # 1st need to assure no prior selections...the sel by loc syntax:
    # SelectLayerByLocation_management (in_layer, {overlap_type}, {select_features}, {search_distance}, {selection_type})
    # in_layer is the index layer; select_features is the pole layer
    
    SelectBy = [layer, poleLyr]
    for lyr in SelectBy:
          iniCount = int(arcpy.GetCount_management(lyr).getOutput(0))
          if iniCount != 0:
               arcpy.SelectLayerByAttribute_management(lyr, 'CLEAR_SELECTION')

    # should now be properly 'initialized' with no prior selections, i.e., full complement datasets      
    arcpy.MakeFeatureLayer_management(layer, "surveyLyr")
    arcpy.MakeFeatureLayer_management(poleLyr, "poleLyr_new")
        
    # Select Layer By Location to limit to just maps with data
    arcpy.SelectLayerByLocation_management("surveyLyr", "INTERSECT", "poleLyr_new", "", "NEW_SELECTION")

    # Susan, check that this works, switching the selection...
    # SelectLayerByAttribute_management (in_layer_or_view, {selection_type}, {where_clause})
    arcpy.SelectLayerByAttribute_management("surveyLyr", "SWITCH_SELECTION")

    # new code to get at OBJECTIDs to modify def query
    IDs = []
    rows = arcpy.SearchCursor("surveyLyr")
    for row in rows:
          IDs.append(row.OBJECTID)

    del row, rows

    subquery = '('
    for each in IDs:
         subquery = subquery + str(each) + ','

    subquery = subquery[0:-1] + ')'
    ################

    # Output directory for the pole maps
    outDir = r"G:\GEOSPATIAL\Publishing\Pole"

    # Set the workspace
    arcpy.env.workspace = outDir

    # List of map grids
    twpList = ['\"TOWNSHIP_C\" = \'D5\' AND \"RANGE_CD\" = \'5\'',\
               '\"TOWNSHIP_C\" = \'D6\' AND \"RANGE_CD\" = \'4\'']

    for twpName in twpList:
        # need to test the twpName with the added subquery for empty return 1st
        theQuery = twpName + " AND \"OBJECTID\" NOT IN " + str(subquery)

        # create a feature layer on index with which to test theQuery for empty set
        # MakeFeatureLayer_management (in_features, out_layer, {where_clause})
        arcpy.MakeFeatureLayer_management(layer, "testTheCount", theQuery)
        gridsToOutput = int(arcpy.GetCount_management("testTheCount").getOutput(0))

        if gridsToOutput != 0:

            # modified the definitionQuery to include the subquery exclusion clause
            layer.definitionQuery = theQuery

            # refresh() after changing the layer def query to 'redefine' the DDP index limits
            mxd.dataDrivenPages.refresh()
             
            # The final mapbook name taken from the list
            finalPDFfn = outDir + "\\" + twpName [16:18] + twpName [38:39] + "Pole.pdf"
            
            # Create the final PDF -- which is just an empty shell right now
            finalPDF = arcpy.mapping.PDFDocumentCreate(finalPDFfn)

            # A temporary pdf file for processing
            tmpPDF = outDir + "\\PoleMapPages.pdf"

            # Let the user know what is happening!
            print "Exporting " + twpName [16:18] + twpName [38:39]
            
            # Export the data driven pages in the mxd to a temporary PDF
            print "Exporting map pages to the temporary PDF"
            ddp = mxd.dataDrivenPages.exportToPDF(tmpPDF)

            # Append the temporary pdf to the final pdf
            # Cover, map pages, back cover
            print "Appending Map Pages"
            finalPDF.appendPages (r"G:\GEOSPATIAL\Publishing\Pole\PoleCovers\Covers_"\
                                  + twpName [16:18] + twpName [38:39] + ".pdf")
            finalPDF.appendPages(tmpPDF)
            finalPDF.appendPages(r"G:\GEOSPATIAL\Publishing\TwpGrid_Color8x11.pdf")

            # Set properties for Adobe Reader and save PDF.
            finalPDF.updateDocProperties(pdf_open_view = "USE_THUMBS", pdf_layout = "SINGLE_PAGE")
            finalPDF.saveAndClose()

    # Deleting temporary layers
    arcpy.Delete_management("surveyLyr")
    arcpy.Delete_management("poleLyr_new")
    arcpy.Delete_management("testTheCount")

except Exception as e:
    print e.message
    print arcpy.GetMessages(2)
    
# Clean up
print "Cleaning up"
# Delete the temporary PDF using the ArcPy function
if arcpy.Exists(tmpPDF):         
        arcpy.Delete_management(tmpPDF)  
# Delete objects
del mxd, tmpPDF, ddp             

# Finished message
print "Map compilation completed. Please review the final output."

A thing worth noting here is if you're working within IDLE or some other editor, etc., is that when you enter a block where succeeding code will require indenting, you may select the code and indent the whole 'region' (in IDLE, it's Format >> Indent Region, on the main menu)...just have to be careful about mixing indention, spaces and tabs.

Hope that helps - do you think I warrant this as 'answered' well enough to get the green checkmark? Just wondering - I've learned a lot and hope you have too.

Thanks and enjoy,
Wayne

T__WayneWhitley

So the new block to select the appropriate index grid subset is working?...except for when the query produces an empty set?

Right so what you could do is modify to test the query in your loop - you have to test the formed query before setting the def:

layer.definitionQuery = twpName + " AND \"OBJECTID\" NOT IN " + str(subquery)

...so what you could do is execute a MFL on the index and test with getCount to see if it is zero (0) and if so, of course loop immediately to your 2nd query, right?

So, something like (within the loop, so you can get twpName) - I did not test this, so check my command puctuation, etc:

query = twpName + " AND \"OBJECTID\" NOT IN " + str(subquery)
arcpy.MakeFeatureLayer_management('the index', 'theTestLyrForCount', query)
TheCountBeforeExecutingRestOfLoop = int(arcpy.GetCount_management('theTestLyrForCount').getOutput(0))

if TheCountBeforeExecutingRestOfLoop != 0:
     layer.definitionQuery = query
     # finish executing the loop, etc. - don't forget to indent this region of code.
     # the following lines must be justified, i.e., indented with 'layer.definitionQuery...

Understand? ...you are almost there, if you don't understand or if this code is 'ugly', it can be fixed later. Output today without error is essential, lol!

Enjoy,
Wayne

SusanWhitney

It's working! The only issue is, if there is a map (twp/range) where there are no sheets selected, the
mxd.dataDrivenPages.refresh() fails and no other maps are output. Is there a way we can handle this?

As an additional note to your last post. The pages that do not have data, really do not have any pole data at all. Nothing on the edges trying to peek through!

Thank you,
Susan

T__WayneWhitley

Test this (it is untested, didn't even look at your PDF section, so you have to give it a try):

# PoleDDpages.py
# Author: slw
# Date: xyz
# Revisions: xyz
# Description: Create Pole map book series using Data Driven Pages and
#           insert a cover page

# Import ArcPy
import os,arcpy

# Overwrite existing file
arcpy.env.overwriteOutput = True

try:
    
    # Set up variables
    # Location of pole map .mxd document
    mxdDoc = r"G:\GEOSPATIAL\Publishing\Pole\Pole_QtrSec.mxd"

    # Create the MapDocument object
    mxd = arcpy.mapping.MapDocument(mxdDoc)
    df = arcpy.mapping.ListDataFrames(mxd)[0]
    layer = arcpy.mapping.ListLayers (mxd, "SURVEY_GRID_BNDRY",df)[0]
    poleLyr = arcpy.mapping.ListLayers (mxd, "Pole",df)[0]

    ################
    # moved part of code to select grids (layer) intersecting 'Pole' features (poleLyr)
    # Create temporary layers to work with the Selection,
    # 1st need to assure no prior selections...the sel by loc syntax:
    # SelectLayerByLocation_management (in_layer, {overlap_type}, {select_features}, {search_distance}, {selection_type})
    # in_layer is the index layer; select_features is the pole layer
    
    SelectBy = [layer, poleLyr]
    for lyr in SelectBy:
          iniCount = int(arcpy.GetCount_management(lyr).getOutput(0))
          if iniCount != 0:
               arcpy.SelectLayerByAttribute_management(lyr, 'CLEAR_SELECTION')

    # should now be properly 'initialized' with no prior selections, i.e., full complement datasets      
    arcpy.MakeFeatureLayer_management(layer, "surveyLyr")
    arcpy.MakeFeatureLayer_management(poleLyr, "poleLyr_new")
        
    # Select Layer By Location to limit to just maps with data
    arcpy.SelectLayerByLocation_management("surveyLyr", "INTERSECT", "poleLyr_new", "", "NEW_SELECTION")

    # Susan, check that this works, switching the selection...
    # SelectLayerByAttribute_management (in_layer_or_view, {selection_type}, {where_clause})
    arcpy.SelectLayerByAttribute_management("surveyLyr", "SWITCH_SELECTION")

    # new code to get at OBJECTIDs to modify def query
    IDs = []
    rows = arcpy.SearchCursor("surveyLyr")
    for row in rows:
          IDs.append(row.OBJECTID)

    del row, rows

    subquery = '('
    for each in IDs:
         subquery = subquery + str(each) + ','

    subquery = subquery[0:-1] + ')'
    ################

    # Output directory for the pole maps
    outDir = r"G:\GEOSPATIAL\Publishing\Pole"

    # Set the workspace
    arcpy.env.workspace = outDir

    # List of map grids
    twpList = ['\"TOWNSHIP_C\" = \'D5\' AND \"RANGE_CD\" = \'5\'',\
               '\"TOWNSHIP_C\" = \'D6\' AND \"RANGE_CD\" = \'4\'']

    for twpName in twpList:
        # modified the definitionQuery to include the subquery exclusion clause
        layer.definitionQuery = twpName + " AND \"OBJECTID\" NOT IN " + str(subquery)

        # refresh() after changing the layer def query to 'redefine' the DDP index limits
        mxd.dataDrivenPages.refresh()
         
        # The final mapbook name taken from the list
        finalPDFfn = outDir + "\\" + twpName [16:18] + twpName [38:39] + "Pole.pdf"
        
        # Create the final PDF -- which is just an empty shell right now
        finalPDF = arcpy.mapping.PDFDocumentCreate(finalPDFfn)

        # A temporary pdf file for processing
        tmpPDF = outDir + "\\PoleMapPages.pdf"

        # Let the user know what is happening!
        print "Exporting " + twpName [16:18] + twpName [38:39]
        
        # Export the data driven pages in the mxd to a temporary PDF
        print "Exporting map pages to the temporary PDF"
        ddp = mxd.dataDrivenPages.exportToPDF(tmpPDF)

        # Append the temporary pdf to the final pdf
        # Cover, map pages, back cover
        print "Appending Map Pages"
        finalPDF.appendPages (r"G:\GEOSPATIAL\Publishing\Pole\PoleCovers\Covers_"\
                              + twpName [16:18] + twpName [38:39] + ".pdf")
        finalPDF.appendPages(tmpPDF)
        finalPDF.appendPages(r"G:\GEOSPATIAL\Publishing\TwpGrid_Color8x11.pdf")

        # Set properties for Adobe Reader and save PDF.
        finalPDF.updateDocProperties(pdf_open_view = "USE_THUMBS", pdf_layout = "SINGLE_PAGE")
        finalPDF.saveAndClose()

        # Deleting temporary layers
        arcpy.Delete_management("surveyLyr")
        arcpy.Delete_management("poleLyr_new")    

except Exception as e:
    print e.message
    print arcpy.GetMessages(2)
    
# Clean up
print "Cleaning up"
# Delete the temporary PDF using the ArcPy function
if arcpy.Exists(tmpPDF):         
        arcpy.Delete_management(tmpPDF)  
# Delete objects
del mxd, tmpPDF, ddp             

# Finished message
print "Map compilation completed. Please review the final output."

This time, if it does not work, I just need better or more feedback from you - more details about what you see...such as perhaps pages with 'no data' - exactly what you mean by that, because just maybe you actually do have pole data on the very edge of the index page so that by the strictest definition you do have intersecting pole data. Make sure too that what is defined in the index layer DDP is what is actually exported...you know the drill, eliminate by parts or steps all possibilities where things may go awry...

Enjoy,
Wayne

T__WayneWhitley

...one more I guess parting thought for the day on this matter -- the thing about Make Feature Layer is that it 'stamps' whatever may be selected on a given layer into memory. I have assumed nothing is selected and that when we preprocessed layers for the next step, Select by Location, I intended to then 'stamp' one full layer with the other full layer. So that being said, this operation only works as I intended if there are no selections 1st.

Tell me that isn't the problem, lol! Could be the select processing is a little off...but no worries, I am looking at another tool I wrote here that at one point had a similar problem - a user was running a script tool where initially I assumed there were no preselected features --- the tool inadvertently returned no results when that should not have been the case...all due to starting with a subset 'stamped' by Make Feature Layer. (no prior selections results in the whole compliment of features included in the layer).

Anyway, there it is...have to consider it.

Enjoy,
Wayne

SusanWhitney

Yes, I checked the sheets in the mxd itself.
We are working in 10.1, so I need to make everything version 10.0.
I'll try to get that out today or tomorrow.
Thank you for all of your help, Wayne.
Susan

T__WayneWhitley

Could be something silly - the problem here is I'm 'flying blind', cannot see the same thing you are looking at.
You are limited here as to the size of what you can attach, but can you save a copy of your mxd in 10.0 with only the pole and index (township/range) layers making sure to retain the DDP setup, make it 'relative-pathed' with just the relevant layers in a ver 10.0 gdb (or shapefile format is fine), and attach here?

Quicker to troubleshoot that way - I can pick apart your code way faster and tell you what I have done after having completed it.

Sorry for your trouble! Also, when you're checking your sheets, you are checking the pages in the mxd itself, correct?

-Wayne

SusanWhitney

Did all of that exactly. Still get pages with no data.

T__WayneWhitley

Great now we are getting somewhere, Susan - now what I want you to do as part of the troubleshooting process, if you have not already done so, paste one of those queries in the index layer's def query window (of your original mxd) - but click the query button to bring up the query builder dialog, then enter and click 'Verify'....if the query can be evaluated, you should get the msg in a pop-up, "The expression was successfully verified." If so, go refresh the DDP index layer and check out the data in your view - do you still get pages where there is 'no data'. If so, then either something is wrong with the construction of the query or you are looking for something other than what is defined in the problem - the result should be only pages containing pole data.

Hope that helps.

-Wayne

SusanWhitney

The .mxd was created in version 10.1, so I don't know if that would be the problem.

I added the print statement to the script and this was the result (I stripped out the extra statements):

"TOWNSHIP_C" = 'D5' AND "RANGE_CD" = '5'AND"OBJECTID"NOT IN(186,226,227,248,271,272,274,275,297,322,347,348)
Exporting D55

"TOWNSHIP_C" = 'D6' AND "RANGE_CD" = '4'AND"OBJECTID"NOT IN(186,226,227,248,271,272,274,275,297,322,347,348)
Exporting D64

When adding this to the definition query in the original .mxd, it still results in pages without data for both instances.
Thank you,
Susan

T__WayneWhitley

hmmm, that's very interesting. Not entirely informative, but interesting nevertheless.

I am not saying this is your problem, but it could be you are dealing with an 'older' mxd document, do you know if that is the case?

What you can try is altering the version mxd to saveACopy to - this is the syntax:

saveACopy (file_name, {version})

...where 'version' is the optional parameter -- unfortunately I don't think you can test for the original mxd version, but if you think it is an earlier version causing this save corruption to a more recent version, you can test saving it to one of the earlier versions by specifying that optional param (I forgot the current software version you are currently using?):

Directly from the 10.1 webhelp:

MapDocument (arcpy.mapping)
Desktop » Geoprocessing » ArcPy » Mapping module
http://resources.arcgis.com/en/help/main/10.1/index.html#//00s30000000n000000
******************************
A string that sets the output version number. The default value will use the current version.

�?�10.1 �??Version 10.1
�?�10.0 �??Version 10.0
�?�8.3 �??Version 8.3
�?�9.0 �??Version 9.0/9.1
�?�9.2 �??Version 9.2
�?�9.3 �??Version 9.3

(The default value is None)
******************************

So, you can try changing the relevant line in your code to (I have entered the string in bold letters - try an earlier version as necessary):
mxd.saveACopy(os.path.splitext(mxdDoc) [0] + str(i) + os.path.splitext(mxdDoc)[1], '10.0')

And if this is not your problem, I'll try to test the the code segment related to setting the def query later today.

Enjoy,
Wayne

EDIT: Better yet, if you can open your py script in IDLE, and enter a print command to print the def query just before you set it for the layer:

print twpName + " AND \"OBJECTID\" NOT IN " + str(subquery)

...then, instead of trying to fix how the test mxds are being saved, you may directly test the def query to see if it is working properly (I could tell you if you pasted it here). Test it 'manually' by copying the result of the print statement from the IDLE window, open your orig mxd and paste it in the def query window, hit OK, then go to your DDP toolbar and refresh your index...

Check your map results...are the index pages correctly 'refined' to the extent of your pole layer? If not, then the def query process needs work. If so, the remaining pdf export component of your code needs work.

SusanWhitney

First you are correct in your statement "To be specific, the code I last posted runs without error and the exported map sheets reflect some index pages without pole data?"

I ran the script again with the str modification you noted in the definition query and received the same result.

I tried to open the mxd files G:\GEOSPATIAL\Publishing\Pole\Pole_QtrSec1.mxd and Pole_QtrSec2.mxd. The files would not open. Got a large ArcMap error ...

Opening the selected Arcmap document failed.
The standard document information of the map document could not be read.
The data frames of the map document could not be read due to the following error:
0x80040111 (Class factory cannot supply requested class)
The last successfully loaded component was:
esriDisplay.RgbColor ({7EE9C496-D123-11D0-8383-080009b996cc})
the specified file does not contain a valid ArcMap document

... so I was not able to check the definition query. I did try to open on more than one machine.

Before I started trying to add the select by location, the definition query was working and providing only the township/range I was asking for. I still get the correct township/range in the resulting file, it's just that I also have pages (sections) that do not have any data.

Looks like I had better research on better error trapping. I guess the beginning class was not enough!
Thank you,
Susan

T__WayneWhitley

I did discover an error in the the part I added to the def query - forgot to convert to string and got this error:

TypeError: cannot concatenate 'str' and 'tuple' objects

The error occurs on adding 'subquery' which is not a string:

layer.definitionQuery = twpName + " AND \"OBJECTID\" NOT IN " + subquery

...so the fix is to add the conversion, simply add 'str' to the line as follows:

layer.definitionQuery = twpName + " AND \"OBJECTID\" NOT IN " + str(subquery)

I did not test the rest of your code, but it seems you should look into better error trapping too.

Hope that helps - run it again, and if for some reason the PDFs aren't right, follow the instructions on my last post to check the test mxds to let me know at least the definition queries are working. After we know everything is working, you shouldn't need that line anymore to print the mxds - you should be printing your final output from the 'parent' DDP document you've set in the beginning.

Enjoy,
Wayne

T__WayneWhitley

To be specific, the code I last posted runs without error and the exported map sheets reflect some index pages without pole data?

Immediately after the def query was refreshed, as a check, the following command executed in your loop:
mxd.saveACopy(os.path.splitext(mxdDoc) [0] + str(i) + os.path.splitext(mxdDoc)[1])

...and should have written the 2 mxd documents:
G:\GEOSPATIAL\Publishing\Pole\Pole_QtrSec1.mxd
G:\GEOSPATIAL\Publishing\Pole\Pole_QtrSec2.mxd

In those documents, can you check the index layer def query and the consequent DDP to see if the refresh of those pages has or has not taken place? That will help isolate the error. I suspect if the def query is not in the index layer's properties, then the Select By Location operation did not go as planned. If you will, just copy/paste the different def queries here. If that went well, then I know to look at the pdf export portion of the code.

Enjoy,
Wayne

SusanWhitney

No errors, Wayne, but I still have the map sheets that do not have any data.

T__WayneWhitley

Susan - this is your modified code going the modified def query route I initially suggested. Not sure which is the better performer, however this should not require any extra layers or use of a temp gdb - please try it, as it has not been tested, and let me know if you get any errors:

# PoleDDpages.py
# Author: slw
# Date: xyz
# Revisions: xyz
# Description: Create Pole map book series using Data Driven Pages and
#           insert a cover page

# Import ArcPy
import os,arcpy

# Overwrite existing file
arcpy.env.overwriteOutput = True

try:
    
    # Set up variables
    # Location of pole map .mxd document
    mxdDoc = r"G:\GEOSPATIAL\Publishing\Pole\Pole_QtrSec.mxd"

    # Create the MapDocument object
    mxd = arcpy.mapping.MapDocument(mxdDoc)
    df = arcpy.mapping.ListDataFrames(mxd)[0]
    layer = arcpy.mapping.ListLayers (mxd, "SURVEY_GRID_BNDRY",df)[0]
    poleLyr = arcpy.mapping.ListLayers (mxd, "Pole",df)[0]

    ################
    # moved part of code to select grids (layer) intersecting 'Pole' features (poleLyr)

    # Create temporary layers to work with the Selection
    arcpy.MakeFeatureLayer_management(layer, "surveyLyr")
    arcpy.MakeFeatureLayer_management(poleLyr, "poleLyr_new")

    arcpy.SelectLayerByAttribute_management("surveyLyr", "CLEAR_SELECTION")
        
    # Select Layer By Location to limit to just maps with data
    arcpy.SelectLayerByLocation_management("surveyLyr", "INTERSECT", "poleLyr_new", "", "NEW_SELECTION")

    # Susan, check that this works, switching the selection...
    arcpy.SelectLayerByAttribute_management("surveyLyr", "SWITCH_SELECTION")

    # new code to get at OBJECTIDs to modify def query
    IDs = []
    rows = arcpy.SearchCursor("surveyLyr")
    for row in rows:
          newID = row.OBJECTID
          if newID not in IDs:
               IDs.append(newID)

    del row, rows

    subquery = '('
    for each in IDs:
         subquery = subquery + str(each) + ','

    subquery = subquery[0:-1] + ')'
    ################

    # Output directory for the pole maps
    outDir = r"G:\GEOSPATIAL\Publishing\Pole"

    # Set the workspace
    arcpy.env.workspace = outDir

    # List of map grids
    twpList = ['\"TOWNSHIP_C\" = \'D5\' AND \"RANGE_CD\" = \'5\'',\
               '\"TOWNSHIP_C\" = \'D6\' AND \"RANGE_CD\" = \'4\'']


    i=1
    for twpName in twpList:
        # modified the definitionQuery to include the subquery exclusion clause
        layer.definitionQuery = twpName + " AND \"OBJECTID\" NOT IN " + subquery

        # refresh() after changing the layer def query to 'redefine' the DDP index limits
        mxd.dataDrivenPages.refresh()
       
        mxd.saveACopy(os.path.splitext(mxdDoc) [0] + str(i) + os.path.splitext(mxdDoc)[1])
        i += 1
         
        # The final mapbook name taken from the list
        finalPDFfn = outDir + "\\" + twpName [16:18] + twpName [38:39] + "Pole.pdf"
        
        # Create the final PDF -- which is just an empty shell right now
        finalPDF = arcpy.mapping.PDFDocumentCreate(finalPDFfn)

        # A temporary pdf file for processing
        tmpPDF = outDir + "\\PoleMapPages.pdf"

        # Let the user know what is happening!
        print "Exporting " + twpName [16:18] + twpName [38:39]
        
        # Export the data driven pages in the mxd to a temporary PDF
        print "Exporting map pages to the temporary PDF"
        ddp = mxd.dataDrivenPages.exportToPDF(tmpPDF)

        # Append the temporary pdf to the final pdf
        # Cover, map pages, back cover
        print "Appending Map Pages"
        finalPDF.appendPages (r"G:\GEOSPATIAL\Publishing\Pole\PoleCovers\Covers_"\
                              + twpName [16:18] + twpName [38:39] + ".pdf")
        finalPDF.appendPages(tmpPDF)
        finalPDF.appendPages(r"G:\GEOSPATIAL\Publishing\TwpGrid_Color8x11.pdf")

        # Set properties for Adobe Reader and save PDF.
        finalPDF.updateDocProperties(pdf_open_view = "USE_THUMBS", pdf_layout = "SINGLE_PAGE")
        finalPDF.saveAndClose()

        # Deleting temporary layers
        arcpy.Delete_management("surveyLyr")
        arcpy.Delete_management("poleLyr_new")    

except Exception as e:
    print e.message
    print arcpy.GetMessages(2)
    
# Clean up
print "Cleaning up"
# Delete the temporary PDF using the ArcPy function
if arcpy.Exists(tmpPDF):         
        arcpy.Delete_management(tmpPDF)  
# Delete objects
del mxd, tmpPDF, ddp             

# Finished message
print "Map compilation completed. Please review the final output."

T__WayneWhitley

Susan, I do not know why this didn't dawn on me before, but I think you could do this, provided I have assumed correctly you want to be 'sensitive' to how your pole layer has grown within your grid index layer:

1- Before the loop on your query, run Select By Location (intersect is fine) the grid index layer with the pole layer.

The result should be only grid index features where you have pole layer features. Consider this a 'prefilter' or intermediate result - you were trying to run this in your loop which is not only unnecessary but more processing intensive as well.

2- Copy features to a temp gdb, overwriting as necessary (think you already have this set). Have a lyr file sourced to this temp fc. [or, if you like, I think you could directly source your index layer to the temp fc]

3- Use UpdateLayer to 'get' the lyr file to update your index layer in your map (from the dynamically 'prefiltered' temp gdb fc of your grid index layer). [This step won't be necessary if you have replaced the datasource as in step 2]

4- Do your loop to then filter on section/ranges with your query and export pdfs...this way, you only need to refresh the index once for each loop.

That clear? Hope that clears things up, and essentially you were doing things 'backwards'. Also, you could do it via the def query as I suggested earlier, but think that would be more processing intensive as well.

Hope that helps.

-Wayne

SusanWhitney

Good morning,
Definition query defines the township/range to process and the select by location selects only the sections and quarter sections in the township/range that do not have data.

So are you saying to not use the select by location and set it up as a separate definition query or do the select by location first and then the definition query.

I appreciate your assistance. This scripting is my trek into unknown waters.

T__WayneWhitley

I think you should have to refresh the DDP after you set the def query...and the reason for that is you need to make the DDP function 'aware' of the change you made to the index layer, because it generates pages based on it --- kind of similar to refreshing a cache, if you know what I mean? (I added that about the cache to help in a 'conceptual' way.)

So, once DDP 'understands' what it is to export, I am not quite sure the need to 're-refresh', if you'll pardon the term? Even if you had to refresh once just before exporting, that should be sufficient. If you would please, clarify your select or query operation you intend to do in-between the def query set on the index layer (which I know runs fine) and your export to PDF?

Thanks,
Wayne

EDIT: Tell me please the reason you need to redefine what is visible in your layers to match the index layer which itself has been redefined? I cannot 'see' what is going on, but it doesn't seem necessary if your redefined index layer by design will only show what is on those pages.

Are you just trying to filter out unanticipated 'no data' pages?

1:50 PM-
Okay, I think I understand now and see what is wrong - you are trying to further refine the index layer, but you haven't futher manipulated the def query on that layer, so the 2nd 'refresh' command is meaningless. I think you need to get the sections where there is no data (if that is what you're trying to further limit your index layer with) and add to the def query, reset it on the index layer, and then run your refresh again.

Make sense now? ...something like this logic (but of course make it 'grammatically' correct):

layer.definitionQuery = twnName + 'and not in [twn1, twn2, twn3, etc....]'

...where twn1, twn2, twn3 and so forth represent the townships of no data extracted from your select by location results. Then refresh and your 'layer' should be made aware... I think you're on the right track.

SusanWhitney

Thank you, I'll try adding the Traceback to see if I get any information.

The definition query works correctly. I got that to work before I added the selection statement. The extra backslash was added so I could put the next 'item' on a new line. It just lets python know that the line continues.
Thank you

MikeMacRae

The only thing I see is in your List, it seems like there might be an extra back slash between your 2 items. The one after your comma. Should this be there? If I am right, then the definition query is returning nothing and therefore selecting nothing.

twpList = ['\"TOWNSHIP_C\" = \'D5\' AND \"RANGE_CD\" = \'5\'',\
'\"TOWNSHIP_C\" = \'D6\' AND \"RANGE_CD\" = \'4\'']

Also, I really like the Traceback error handling code to better identify the first line in error. maybe there is something else not firing along the way before it gets to that. Give it a shot:

http://resources.arcgis.com/en/help/main/10.1/index.html#//002z0000000q000000

Připojte se k diskusi

Přihlášení členové mohou přispívat, sledovat aktualizace a další. Jste tu noví? Zaregistrujte si bezplatný účet.

Přihlásit se
Registrovat

Rychlé odkazy

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.