nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

The calculated value is invalid for the row with object id = 1

ZachHewitt1

I am currently running a large model and when I get to the part where there is a field calculation needed, it gives me this error. If I choose to continue running the model, it continues fine. It just seems to be at this part that the field calculation gets hung up. The problem occurs with the first row of data, which is no different from any of the other rows of data. Has anyone else ever had this issue?

Najděte více příspěvků označených jako

Accepted answers

All comments

TedKowal

RichardFairhurst

I could just as easily directly assign those variable names in VB Script without a Dim statement to an empty array at any point in my calculation, unlike VBA aand VB.Net where errors would occur if I did not explicitly cast the array to a real type, i.e, Dim MyArray() as String. Using the syntax of VBA and VB.Net of Dim MyArray() as String throws an error and was the sole reason for months of posts on the forum after the release of 10.0 saying "My calculation broke at 10.0 and I don't know why". So I stopped using it and have not had a problem debugging my calculations as a result.

Using Option Explicit has never been discussed on the forum that I can recall and I was unaware it had any effect in VB Script, so I never tried it. That practice is not well established in any posts here on the forum or in the VB Script help. Without the inclusion of that option, the use of Dim makes no difference. So you needed to say that the use of Option Explicit is a good practice in conjunction with Dim, otherwise the statement about the value of Dim is misleading

Anyway, this user was misusing Dim by including it multiple times for the same variable name in his calculation. That resets the variable, breaks the logic of having successive if statements and led to errors in the calculation, so using Dim like that is definitely a bad practice.

TedKowal

New to me, I am looking at various vbscripts I use with Dim statements....

Option Explicit

Dim MyArray()

ReDim AnotherArray().....

I do not disagree with VB Script using only Variant... properly Dim statements work and is good programming practice and helpful in debuging even VB Script

Simple example of why DIM is good programming practice

StudentFinalGrade = 100

StudentHomeworkGrade = 100

StudentCourseGrade = ((StudentFialnGrade + StudentHomeworkGrade)/200)*100

(Will not produce an error but is incorrect and the answer is wrong) Difficult to debug

---------------------------------------------------------------

Option Explicit

Dim StudentFinalGrade, StudentHomeworkGrade

StudentFinalGrade = 100

StudentHomeworkGrade = 100

StudentCourseGrade = ((StudentFialnGrade + StudentHomeworkGrade)/200)*100

Will produce an error and the error is obvious [StudentFialnGrade should be StudentFinalGrade

RichardFairhurst

The Field Calculator uses VB Script which only supports type Variant. If you try to Dim to any other type like string, integer, double, object, etc. an error will be thrown. Using Dim is only a good practice in VBA or VB.Net, not VB Script.

TedKowal

Looks like the question is well handled.....

Just wanted to make a small observing comment. I still find it a good idea to explicitly define/dimension all variables. A lot of nasty type conversion errors can be avoided by explicitly knowing what type of variable you wish filled.

Another observation: Dim n "is not a string, integer, double or object" In vb it is a "Variant" which could be any of all types. I generally avoid variants except when I do not know what type of data that is being received into the variable.

RichardFairhurst

I am assuming this is all one calculation. Try:

if (([SummaryStatistics.SUM_DrainArea_SF]) > 0 And ([SummaryStatistics.SUM_DrainArea_SF])) <= 299 then

n = "MINOR"

else

n = "COMPLIANT"

end if

if [Lat_Defects.ProposedWork] = "35" then

n = "XCONNECT"

end if

if ([Summary_Statistics_2.SUM_DrainArea_SF]) > 299 then

n = "MAJOR"

end if

Make sure your output field is text and at least 9 characters long so that it can hold the value "COMPLIANT". If it is less than 9 characters long it will throw an error. Are you sure all records in Lat_Defects have a matching record in both Summary_Statistics and Summary_Statistics_2? Are you sure none of these 3 fields have Null values? If any of them have an unmatched record or a Null value that will throw an error. Have you checked that the join worked for both tables on the record with ObjectID 84 in the main table, especially if this is a 3-table join?

If you still have problems, you are going to have to at least post a screen shot of your data with the join in place, since it in not fair to ask us about errors that only occur for specific records if we cannot see those records.

ZachHewitt1

Ok I removed the Dim statements from the script and I am still hitting that error in the last section of code. It is saying that the Calculated Value is Invalid for the row with object id = 84 in this case.

RichardFairhurst

Dim was only useful when VBA was used in the field calculator prior to 10.0, since VBA has several types of variables that can be instantiated by the Dim clause. After 10.0 calculations use VB Script and there is only one type of variable, so just by assigning a variable a value it is given a variable name and type without using the Dim clause.

ZachHewitt1

I am still running 10.2 so does that statement hold true for removing the Dim statements? Also, doesn't the Dim declare what my variable is?

RichardFairhurst

Remove the Dim statements. If this is all one calcuation, they cause the n variable to be reset before each section so the first and second section calculations are destroyed and overridden even when the condition of clause 3 is not met. Dim is useless in VB script and not to be used ever. If these are separate calculations they all need an else clause.

ZachHewitt1

Within my model I have three sections of code. The second section overrides the first and the third section overrides the second. There is an else statement in the first section of code within the model. Here are the three sections of code, in order from 1 to 3.

Dim n

if (([SummaryStatistics.SUM_DrainArea_SF]) > 0 And ([SummaryStatistics.SUM_DrainArea_SF])) <= 299 then

n = "MINOR"

else n = "COMPLIANT"

end if

Dim n

if [Lat_Defects.ProposedWork] = "35" then

n = "XCONNECT"

end if

Dim n

if ([Summary_Statistics_2.SUM_DrainArea_SF]) > 299 then

n = "MAJOR"

end if

In between these code sections there are other things going on but there are no other field calculations. There are simple things like Add Joins and Remove Joins.

Thanks

RichardFairhurst

Dim is not necessary anymore with VB Script. You have to have an else clause to output a value when the condition you have written is not met. Every record has to have an output. So change the calculation to the following where you replace [OUTPUT_FIELD] with the actual name of the Output Field (so that whatever is already in the output field is not changed):

Parser: VB Script

Use Codeblock: checked

Pre-Logic Codeblock:

if ([Summary_Statistics_2.SUM_DrainArea_SF]) > 299 then

n = "MAJOR"

else

n = [OUTPUT_FIELD]

end if

Field expression: n

DarrenWiens2

I believe you're running into the error because your expression does not return anything for certain cases, where the value is <= 299. Add an 'else' statement to always return a value.

if ([Summary_Statistics_2.SUM_DrainArea_SF]) > 299 then

n = "MAJOR"

else

n = ""

end if

ZachHewitt1

The expression I am using goes as follows:

Dim n

if ([Summary_Statistics_2.SUM_DrainArea_SF]) > 299 then

n = "MAJOR"

end if

The Summary_Statistics_2.SUM_DrainArea_SF field is a double field type and the variable of n is a string field type. Based off of what number is in the Summary_Statistics_2.SUM_DrainArea_SF, the variable is populated with one of four choices, Major, Minor, Xconnect or Compliant. When the error pops up I can choose to continue to run the model, and if I do the rest of the rows get the field populated with data. It seems to only happen to the first row that the tool hits.

Thanks

JakeSkinner

Hi Zach,

Can you provide more information. For example, what is the expression you are using for the field calculation? Could you also provide the value(s) of the field(s) you are using in the expression?

Připojte se k diskusi

Přihlášení členové mohou přispívat, sledovat aktualizace a další. Jste tu noví? Zaregistrujte si bezplatný účet.

Rychlé odkazy

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.