I have two point feature layers. One represents cleaning and the other catch basins. The cleaning layer exists as a hosted feature service in ArcGIS Online. In ArcGIS Pro, I am trying to run the below code to snap cleaning points to catch basin points so they are coincident. It only runs through the main loop one time. It used to run fine but now I can't figure out why. I am not a programmer so I am hoping someone that is can help me figure out why my code won't loop more than once. Any ideas? Thanks! arcpy . env . overwriteOutput = True arcpy . env . workspace = "E:\MDC\Catch Basin Cleaning\map_docs\Catch Basin Cleaning 2018\Inspection 2018 Review.gdb" cleaning_fc = 'Cleaning and Sediment Monitoring' catchBasin_fc = 'ssCatchbasin' objId_field = 'OBJECTID' name_field = 'SAPLINKID_FK' name_field2 = 'SAPLINKID' #Create a where clause based on the cleaning date aCleanDateWhereClause = "CleanDate >= timestamp '2018-06-26 01:10:00'" aTownWhereClause = "TOWNCODE = '01'" #Create layer files cleaning_layer = arcpy . MakeFeatureLayer_management ( cleaning_fc , "cleaning_lyr" , aCleanDateWhereClause ) catchbasin_layer = arcpy . MakeFeatureLayer_management ( catchBasin_fc , "catchbasin_lyr" , aTownWhereClause ) #Clear any selections arcpy . management . SelectLayerByAttribute ( cleaning_layer , "CLEAR_SELECTION" ) arcpy . management . SelectLayerByAttribute ( catchbasin_layer , "CLEAR_SELECTION" ) #Create a search cursor using an SQL expression to count #total number of cleaning records to be snapped totalRec = 0 with arcpy . da . SearchCursor ( cleaning_layer , [ objId_field , name_field ] ) as cursor : for row in cursor : totalRec += 1 print ( "Total Cleaning Recs: " + str ( totalRec ) ) #I get 734 records here #Create a search cursor using an SQL expression to loop through only #those points that have been created since a specific date. Snap those #cleaning points to the ssCatchbasin so they are coincident curRec = 0 #counter for keep tracking of where we are in the loop #the same loop below only runs one time with arcpy . da . SearchCursor ( cleaning_layer , [ objId_field , name_field ] ) as cursor : for row in cursor : curRec += 1 sapLinkId = row [ 1 ] if "GIS" in sapLinkId : layer1 = arcpy . management . SelectLayerByAttribute ( cleaning_layer , "NEW_SELECTION" , "SAPLINKID_FK=" + "'" + row [ 1 ] + "'" ) layer2 = arcpy . management . SelectLayerByAttribute ( catchbasin_layer , "NEW_SELECTION" , "SAPLINKID=" + "'" + row [ 1 ] + "'" ) arcpy . Snap_edit ( layer1 , [ [ layer2 , "VERTEX" , "120000 feet" ] ] ) percentDone = round ( ( curRec / totalRec ) * 100 , 0 ) print ( "Processing row " + str ( row [ 0 ] ) + " for SAPLINKID " + row [ 1 ] + " (" + str ( percentDone ) + "% percent complete)" ) print ( "Done!" )

Even if a statement or expression is syntactically correct, it may cause an error when an attempt is made to execute it. Errors detected during execution are called exceptions and are not unconditionally fatal. Exceptions help in handling errors in a convenient way so that your program does not crash. Exception handling should be used when you feel that you have a code that is capable of producing an error. It is possible to write programs that handle selected exceptions. Regards Azharuddin Python Developer

I am pretty sure that running a search cursor on the layer, then within the read loop apply a selection is going to work as a strategy.

nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Python Script to Snap by Attribute Not Working

wysorj

I have two point feature layers. One represents cleaning and the other catch basins. The cleaning layer exists as a hosted feature service in ArcGIS Online. In ArcGIS Pro, I am trying to run the below code to snap cleaning points to catch basin points so they are coincident. It only runs through the main loop one time. It used to run fine but now I can't figure out why. I am not a programmer so I am hoping someone that is can help me figure out why my code won't loop more than once. Any ideas? Thanks!

arcpy<SPAN class="punctuation token">.</SPAN>env<SPAN class="punctuation token">.</SPAN>overwriteOutput <SPAN class="operator token">=</SPAN> <SPAN class="token boolean">True</SPAN>
arcpy<SPAN class="punctuation token">.</SPAN>env<SPAN class="punctuation token">.</SPAN>workspace <SPAN class="operator token">=</SPAN> <SPAN class="string token">"E:\MDC\Catch Basin Cleaning\map_docs\Catch Basin Cleaning 2018\Inspection 2018 Review.gdb"</SPAN>

cleaning_fc <SPAN class="operator token">=</SPAN> <SPAN class="string token">'Cleaning and Sediment Monitoring'</SPAN>
catchBasin_fc <SPAN class="operator token">=</SPAN> <SPAN class="string token">'ssCatchbasin'</SPAN>
objId_field <SPAN class="operator token">=</SPAN> <SPAN class="string token">'OBJECTID'</SPAN>
name_field <SPAN class="operator token">=</SPAN> <SPAN class="string token">'SAPLINKID_FK'</SPAN>
name_field2 <SPAN class="operator token">=</SPAN> <SPAN class="string token">'SAPLINKID'</SPAN>

<SPAN class="comment token">#Create a where clause based on the cleaning date</SPAN>
aCleanDateWhereClause <SPAN class="operator token">=</SPAN> <SPAN class="string token">"CleanDate >= timestamp '2018-06-26 01:10:00'"</SPAN>
aTownWhereClause <SPAN class="operator token">=</SPAN> <SPAN class="string token">"TOWNCODE = '01'"</SPAN>

<SPAN class="comment token">#Create layer files</SPAN>
cleaning_layer <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>MakeFeatureLayer_management<SPAN class="punctuation token">(</SPAN>cleaning_fc<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"cleaning_lyr"</SPAN><SPAN class="punctuation token">,</SPAN> aCleanDateWhereClause<SPAN class="punctuation token">)</SPAN>
catchbasin_layer <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>MakeFeatureLayer_management<SPAN class="punctuation token">(</SPAN>catchBasin_fc<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"catchbasin_lyr"</SPAN><SPAN class="punctuation token">,</SPAN> aTownWhereClause<SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token">#Clear any selections</SPAN>
arcpy<SPAN class="punctuation token">.</SPAN>management<SPAN class="punctuation token">.</SPAN>SelectLayerByAttribute<SPAN class="punctuation token">(</SPAN>cleaning_layer <SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"CLEAR_SELECTION"</SPAN><SPAN class="punctuation token">)</SPAN>
arcpy<SPAN class="punctuation token">.</SPAN>management<SPAN class="punctuation token">.</SPAN>SelectLayerByAttribute<SPAN class="punctuation token">(</SPAN>catchbasin_layer <SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"CLEAR_SELECTION"</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token">#Create a search cursor using an SQL expression to count</SPAN>
<SPAN class="comment token">#total number of cleaning records to be snapped</SPAN>
totalRec <SPAN class="operator token">=</SPAN> <SPAN class="number token">0</SPAN>
<SPAN class="keyword token">with</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>SearchCursor<SPAN class="punctuation token">(</SPAN>cleaning_layer<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN>objId_field<SPAN class="punctuation token">,</SPAN> name_field<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN> <SPAN class="keyword token">as</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; totalRec <SPAN class="operator token">+=</SPAN> <SPAN class="number token">1</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">print</SPAN> <SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Total Cleaning Recs:&nbsp; "</SPAN> <SPAN class="operator token">+</SPAN> str<SPAN class="punctuation token">(</SPAN>totalRec<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN> <SPAN class="comment token">#I get 734 records here</SPAN>

<SPAN class="comment token">#Create a search cursor using an SQL expression to loop through only</SPAN>
<SPAN class="comment token">#those points that have been created since a specific date.&nbsp; Snap those</SPAN>
<SPAN class="comment token">#cleaning points to the ssCatchbasin so they are coincident</SPAN>
curRec <SPAN class="operator token">=</SPAN> <SPAN class="number token">0</SPAN> <SPAN class="comment token">#counter for keep tracking of where we are in the loop</SPAN>

<SPAN class="comment token">#the same loop below only runs one time</SPAN>
<SPAN class="keyword token">with</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>SearchCursor<SPAN class="punctuation token">(</SPAN>cleaning_layer<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN>objId_field<SPAN class="punctuation token">,</SPAN> name_field<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN> <SPAN class="keyword token">as</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; curRec <SPAN class="operator token">+=</SPAN> <SPAN class="number token">1</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; sapLinkId <SPAN class="operator token">=</SPAN> row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">if</SPAN> <SPAN class="string token">"GIS"</SPAN> <SPAN class="keyword token">in</SPAN> sapLinkId<SPAN class="punctuation token">:</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; layer1 <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>management<SPAN class="punctuation token">.</SPAN>SelectLayerByAttribute<SPAN class="punctuation token">(</SPAN>cleaning_layer <SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"NEW_SELECTION"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"SAPLINKID_FK="</SPAN> <SPAN class="operator token">+</SPAN><SPAN class="string token">"'"</SPAN><SPAN class="operator token">+</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="operator token">+</SPAN><SPAN class="string token">"'"</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; layer2 <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>management<SPAN class="punctuation token">.</SPAN>SelectLayerByAttribute<SPAN class="punctuation token">(</SPAN>catchbasin_layer <SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"NEW_SELECTION"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"SAPLINKID="</SPAN> <SPAN class="operator token">+</SPAN><SPAN class="string token">"'"</SPAN><SPAN class="operator token">+</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="operator token">+</SPAN><SPAN class="string token">"'"</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; arcpy<SPAN class="punctuation token">.</SPAN>Snap_edit<SPAN class="punctuation token">(</SPAN>layer1<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="punctuation token">[</SPAN>layer2<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"VERTEX"</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="string token">"120000 feet"</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; percentDone <SPAN class="operator token">=</SPAN> round<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">(</SPAN>curRec<SPAN class="operator token">/</SPAN>totalRec<SPAN class="punctuation token">)</SPAN><SPAN class="operator token">*</SPAN><SPAN class="number token">100</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">)</SPAN>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <SPAN class="keyword token">print</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Processing row "</SPAN> <SPAN class="operator token">+</SPAN> str<SPAN class="punctuation token">(</SPAN>row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN> <SPAN class="operator token">+</SPAN> <SPAN class="string token">" for SAPLINKID "</SPAN> <SPAN class="operator token">+</SPAN> row<SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN> <SPAN class="operator token">+</SPAN> <SPAN class="string token">" ("</SPAN><SPAN class="operator token">+</SPAN> str<SPAN class="punctuation token">(</SPAN>percentDone<SPAN class="punctuation token">)</SPAN> <SPAN class="operator token">+</SPAN> <SPAN class="string token">"% percent complete)"</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="keyword token">print</SPAN> <SPAN class="punctuation token">(</SPAN><SPAN class="string token">"Done!"</SPAN><SPAN class="punctuation token">)</SPAN>‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Najděte více příspěvků označených jako

Accepted answers

All comments

wysorj

For what it's worth, I can run this script in ArcMap and it runs as expected.

wysorj

Dedented lines 45 & 46 with the same results:

Total Cleaning Recs: 983
row[0]16000 row[1]GIS6089793
Processing row 16000 for SAPLINKID GIS6089793 (0.0% percent complete)
row[0]16001 row[1]GIS6093070

I put some print statements inside the for loop and the script appears to hang on the first select layer by attribute statement (line 41) when the loop begins its second iteration. But I can't see anything that is wrong that would cause the script to not run beyond this point without throwing an error message of some kind.

DanPatterson_Retired

Accessing data using cursors—ArcPy Get Started | ArcGIS Desktop

I didn't think you needed to do a reset() on the cursor with a 'with' statement.

Also, dedent lines 45, 46 to see if it is printing anything outside of the if statement.

I can't see why it won't print the last line

wysorj

Hi Dan,

Thanks for your help!

Here is the result:

Total Cleaning Recs: 826
row[0]16000 row[1]GIS6089793
Processing row 16000 for SAPLINKID GIS6089793 (0.0% percent complete)
row[0]16001 row[1]GIS6093070

My final print statement never runs either.

DanPatterson_Retired

throw a print statement in between lines 39 and 40 to see what it returns

print("row[0] {} row[1] {}".format(row[0], row[1]))

DanPatterson_Retired

Your code is incorrectly indented.

This could be the problem or it is the result of improper formatting

/blogs/dan_patterson/2016/08/14/script-formatting

Připojte se k diskusi

Přihlášení členové mohou přispívat, sledovat aktualizace a další. Jste tu noví? Zaregistrujte si bezplatný účet.

Rychlé odkazy

Všechny komunity
Nedávné příspěvky
Sledovaný obsah
Pomoc komunity

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.