Attribute Rule: What am I doing wrong?

ThomasColson

From arcade-expressions/CopyValueIntersectingFeature.md at master · Esri/arcade-expressions · GitHub , I have 

<SPAN class="comment token">// This rule will populate the edited features field with a value from an intersecting feature</SPAN>

<SPAN class="comment token">// Value to copy from the intersected feature</SPAN>
var intersecting_field <SPAN class="operator token">=</SPAN> <SPAN class="string token">"GRTS_ID"</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="comment token">//Field rule is assigned to in the Attribute Rule</SPAN>
var feature_field <SPAN class="operator token">=</SPAN> <SPAN class="string token">"GRTS_ID"</SPAN><SPAN class="punctuation token">;</SPAN>

<SPAN class="comment token">// Create feature set to the intersecting class using the GDB Name</SPAN>
var intersecting_featset <SPAN class="operator token">=</SPAN> <SPAN class="token function">FeatureSetByName</SPAN><SPAN class="punctuation token">(</SPAN>$datastore<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'NABAT_CONUS_10x10_KM_GRID_CELLS_PRJ'</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN>intersecting_field<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">,</SPAN> <SPAN class="token boolean">true</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

<SPAN class="comment token">// Intersect the edited feature with the feature set and retrieve the first feature</SPAN>
var intersected_feature <SPAN class="operator token">=</SPAN> <SPAN class="token function">First</SPAN><SPAN class="punctuation token">(</SPAN><SPAN class="token function">Intersects</SPAN><SPAN class="punctuation token">(</SPAN>intersecting_featset<SPAN class="punctuation token">,</SPAN> $feature<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">;</SPAN>

<SPAN class="comment token">// Check to make sure there was an intersected feature, if not, return the original value</SPAN>
<SPAN class="keyword token">if</SPAN> <SPAN class="punctuation token">(</SPAN>intersected_feature <SPAN class="operator token">==</SPAN> null<SPAN class="punctuation token">)</SPAN>
<SPAN class="punctuation token">{</SPAN>
    <SPAN class="keyword token">return</SPAN> $feature<SPAN class="punctuation token">[</SPAN>feature_field<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="punctuation token">}</SPAN>
<SPAN class="comment token">// If the intersected feature is null, return the original value</SPAN>
<SPAN class="keyword token">if</SPAN> <SPAN class="punctuation token">(</SPAN><SPAN class="token function">IsEmpty</SPAN><SPAN class="punctuation token">(</SPAN>intersected_feature<SPAN class="punctuation token">.</SPAN>GRTS_ID<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN>
<SPAN class="punctuation token">{</SPAN>
    <SPAN class="keyword token">return</SPAN> $feature<SPAN class="punctuation token">[</SPAN>feature_field<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">;</SPAN>
<SPAN class="punctuation token">}</SPAN>
<SPAN class="comment token">// Return the intersected features value</SPAN>
<SPAN class="keyword token">return</SPAN> intersected_feature<SPAN class="punctuation token">[</SPAN>intersecting_field<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">;</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

and 

Where NABAT_CONUS_10x10_KM_GRID_CELLS_PRJ is a polygon feature class with the field GRTS_ID (Type Long) and the field I'm wanting to edit in the source feature class is also GRTS_ID (Type Long). 

What is happening though is on insert and update, the GRTS_ID field in the feature class being edit instead gets the ObjectID of the intersecting Polygon. 100% sure I've gotten something wrong here. 

kelly.koenig

I created some dummy data with your layer/attribute names and created an attribute rule using the exact code you pasted. The 'GRTS_ID' attribute from the 'NABAT_CONUS_10x10_KM_GRID_CELLS_PRJ' layer was copied as expected instead of the Object ID so I don't think your code is wrong.

Maybe try deleting the rule that's giving you trouble, restarting Pro, and creating the rule again? Or you could export a copy of the two datasets and create the rule using the copied layers to see if it's a quirk with the original feature layer.