Deleting feature stops working

Question

Hi All

I'm attempting to run a batch process which cuts a polygon and deletes the original polygon after inserting the two new 'post cut' polygons into the feature class. The code I've included below works fine and then all of a sudden it just stops deleting the 'pre-cut' polygon. This then causes problems else where in the process where I find intersecting polygons and should only return one and of course it finds two and throws an error. As you can see I've even tried to pause the code to let ArcObjects do it's thing with no success. Any ideas out there why all of a sudden the polygons stop getting deleted?

Cheers

Adrian
        private void CutPolygonFeature(IPoint offsetPoint1, IPoint offsetPoint2, ref IFeature pFeatPoly, ref IFeatureClass polyFC, ref IApplication App)
        {
            IPolyline pLine;
            ITopologicalOperator4 pTopo;
            IGeometryCollection pGeoCol;
            IFeature pFeatNew;
            int i, j;

try
            {

pLine = CreatePolylineByPoints(offsetPoint1, offsetPoint2);

//cut with intLine
                pTopo = (ITopologicalOperator4)pFeatPoly.Shape;
                pGeoCol = pTopo.Cut2(pLine);

pEditor.StartOperation();
                for (i = 0; i < pGeoCol.GeometryCount; i++)
                {
                    pFeatNew = polyFC.CreateFeature();
                    pFeatNew.Shape = pGeoCol.get_Geometry(i);
                    for (j = 2; j < pFeatPoly.Fields.FieldCount; j++)
                    {
                        pFeatNew.set_Value(j, pFeatPoly.get_Value(j));
                    }
                    pFeatNew.Store();
                }

pFeatPoly.Delete();
                polyFC.Update(null, true);
                Thread.Sleep(100);
                pEditor.StopOperation("Cut made");
                //function to activate the save edits command button on the Editor toolbar
                ArcCom.SaveEdits(App);
                Thread.Sleep(100);

}
            finally
            {
                offsetPoint1 = null;
                offsetPoint2 = null;
                pLine = null;
                pTopo = null;
                pGeoCol = null;
                pFeatNew = null;
            }

}

AlexanderGray · Answer

If you are editing an SDE database and no one is accessing it at the time.  You might consider locking everyone out, connecting as the data owner and putting the featureclass in loadonlymode (IFeatureClassLoad.)  That will avoid updating the spatial index and should make it faster.
Good Luck

AKitch · Answer

Thanks Alex and Jeff

Your advice seems to have solved the issues. I tried the non-recycling cursor alone which still failed. So I went the insert cursor and featurebuffer way which seems to have done the trick. I removed the Edit Ops completely as I don't need to undo. I wasn't sure if they were needed and didn't want to fill the 'undo history' (if that exists) which is why I originally had the Edit Ops in the loop. The update feature instead of deleting is also working well. Hadn't thought of that. I haven't had much experience using cursors to their fullest so looks like I've got some reading to do.

As to your last query Jeff. The outer loop in the code I supplied can have up to ~400 iterations but usually substantially less. That loop is actually a part of code that is accessed occasionally in another (outer outer) loop. The CutPolygonFeature() method is accessed mainly from this outer outer loop potentially several 1000 times. I'm running the process on the full dataset tonight so will see if it can handle it. In short I'm dicing a set of regional polygons into very small directional sub-regions. This is being done by cutting the relevant region polygon with regular perpendicular lines stemming from a directional line running along the length and centre of the region polygon.

Thanks again for the advice. Very valuable and appreciated.

Cheers

JeffreyHamblin · Answer

I'll second most of what agray1 wrote, although I guess the edit operation is needed if the features participate in a topology or network.

I would certainly try a non-recycling cursor first, since that's an easy change to test.

Next, take a close look at the IFeature ref that is getting passed around.

Lastly, try moving the edit ops outside the loops.

Out of curiosity, how many times does the outer loop typically interate?

-Jeff