nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Edit operation not deleting rows in table

succip

Hello,

I'm having an issue deleting rows from a table using the EditOperation class. My code is as follows:

            QueuedTask.Run(() =>
            {
                Table dnoXrefTable = Utilities.GetPrdTable("SPATIAL.DNO_XREF");
                QueryFilter qf = new QueryFilter { WhereClause = $"FACILITYID='{facilityId}' AND FEATURECLASS='{featureClassName}'" };
                var deleteOperation = new EditOperation();
                deleteOperation.Name = "Delete features";
                using (var rowCursor = dnoXrefTable.Search(qf, false))
                {
                    while (rowCursor.MoveNext())
                    {
                        using (var row = rowCursor.Current)
                        {
                            deleteOperation.Delete(row);
                        }
                    }
                }
                deleteOperation.Execute();
            });

No errors but data isn't removed from the table after it runs. I can delete the features manually so I don't think it's a permissions issue.

Thanks in advance for any help!

Najděte více příspěvků označených jako

Accepted answers

Wolf

Actually, after i tried your use case with my code snippet again i realized that my dataset didn't really represent the one-to-many (related records) use case property, instead with my data i always only had one related record that was correctly deleted. After changing my query logic, i was able to duplicate the same problem that you are seeing. I think that this is actually a bug. I will pass this on to the Editor team.

However, there is a workaround for this issue. You can use the EditOperation Delete method on the table instead of deleting each row. The following code snippet worked for me:

// collect all object ids that need to be deleted
List<long> ids = new List<long>();
using (var tableCursor = _countyTable.Search(qf))
{
  while (tableCursor.MoveNext())
  {
    using (var tableRow = tableCursor.Current)
    {
      //not working as expected: deleteEditOp.Delete(tableRow);
      ids.Add(tableRow.GetObjectID());
    }
  }
}
// delete all records with objects ids
deleteEditOp.Delete(_countyTable, ids);

Can you check if this works for you?

All comments

Wolf

There are two issues i can see here:

1) When you use: 'var deleteOperation = args.Operation;' meaning you try to use the existing (executing) EditOperation, you cannot include a table or feature class that is not already on the map (table of content) during that edit session. In other words, you can only include tables and feature classes that are part of your map in your editoparation in order to make any changes part of an undo/redo operation.

2) You should not open a new database connection each time you delete a record. The database connection should be established once in your session for various reasons.

If you really can't include the standalone table in your TOC you should still adhere to my 2. point above and try to create the database connection only once and then use Table.DeleteRows (QueryFilter) (DeleteRows Method—ArcGIS Pro) to delete the related rows.

succip

Sorry Wolf if I could add one more addendum to this: I'm still having issues deleting records from the table using DatabaseConnectionProperties instead of through the ToC and I'm wondering if this is also a bug. Running with breakpoints I see the table is populated but nothing is deleted after it finishes. Accessing this table in my other dockpane using the same code works as expected, but only has issues in the RowDeletedEvent.

protected static void OnRowDeletedEvent(RowChangedEventArgs args)
        {
            DatabaseConnectionProperties connectionProperties = new DatabaseConnectionProperties(EnterpriseDatabaseType.Oracle)
            {
                AuthenticationMode = AuthenticationMode.DBMS,
                User = "user",
                Password = "password",
                Instance = @"instance"
            };

            Geodatabase geodatabase = new Geodatabase(connectionProperties);
            Table dnoTable = geodatabase.OpenDataset<Table>("SPATIAL.DNO_XREF");

            var deleteOperation = args.Operation;
            QueryFilter qf = new QueryFilter { WhereClause = $"FACILITYID='{args.Row["FACILITYID"]}' AND FEATURECLASS='{args.Row.GetTable().GetDefinition().GetModelName()}'" }; 
            List<long> oids = new List<long>();
            using (var rc = dnoTable.Search(qf))
            {
                while (rc.MoveNext())
                {
                    using (var deleteRow = rc.Current)
                    {
                        oids.Add(deleteRow.GetObjectID());
                    }
                }
            }
            deleteOperation.Delete(dnoTable, oids);
        }

succip

Yes, that works! What a relief, thank you again for your help.

Wolf

However, there is a workaround for this issue. You can use the EditOperation Delete method on the table instead of deleting each row. The following code snippet worked for me:

// collect all object ids that need to be deleted
List<long> ids = new List<long>();
using (var tableCursor = _countyTable.Search(qf))
{
  while (tableCursor.MoveNext())
  {
    using (var tableRow = tableCursor.Current)
    {
      //not working as expected: deleteEditOp.Delete(tableRow);
      ids.Add(tableRow.GetObjectID());
    }
  }
}
// delete all records with objects ids
deleteEditOp.Delete(_countyTable, ids);

Can you check if this works for you?

succip

Yep, I see see each unique ObjectID in the output. I'm on ArcGIS Pro 3.0.0, I will try updating to the latest version.

Maybe also worth mentioning: I have a similar function somewhere else in my add-in, but this is tied to a dockpane to allow users to delete entries manually. The code here is as follows, with the main difference (as far as I can see) being this doesn't use the RowDeletedEvent:

public ICommand CmdDeleteDrawing
        {
            get
            {
                return new RelayCommand(() =>
                {
                    if (_selectedDrawingEntry == null)
                    {
                        MessageBox.Show("Please select a drawing to remove first.");
                    }
                    else
                    {
                        QueuedTask.Run(async () =>
                        {
                            Table dnoXrefTable = Utilities.GetPrdTable("SPATIAL.DNO_XREF");
                            var deleteDrawing = new EditOperation();
                            deleteDrawing.Name = "Delete Drawing";
                            QueryFilter qf = new QueryFilter { WhereClause = $"DNO_ID={_selectedDrawingEntry.DnoId} AND FACILITYID={_selectedDrawingEntry.FacilityId}" };
                            RowCursor rc = dnoXrefTable.Search(qf, false);
                            while (rc.MoveNext())
                            {
                                Row dr = rc.Current;
                                deleteDrawing.Delete(dr);
                                deleteDrawing.Execute();
                                await Project.Current.SaveEditsAsync();
                            }
                        });
                    }
                });
            }
        }

This method works no problem.

Wolf

So you see the "Objectid: ..." output for multiple records but only the last record is being deleted? I have implemented the same scenario also with a one-to-many relationship and all my related records are deleted.

Which release of ArcGIS Pro are you using?

succip

Thanks Wolf for all your help thus far. I found swapping my getPrdTable() function for finding it in the table of contents works, so I'll have to diagnose that function, but it still only deletes one row. It iterates through all the rows but after finishing only the last one is deleted. Any idea why? My code for the RowDeletedEvent is as follows:

        protected static void OnRowDeletedEvent(RowChangedEventArgs args)
        {
            //Table dnoTable = Utilities.GetPrdTable("SPATIAL.DNO_XREF");
            StandaloneTable dnoTable = MapView.Active.Map.GetStandaloneTablesAsFlattenedList().OfType<StandaloneTable>().FirstOrDefault(); // (only one standalone table in ToC)
            var deleteOperation = args.Operation;

            QueryFilter qf = new QueryFilter { WhereClause = $"FACILITYID='{args.Row["FACILITYID"]}' AND FEATURECLASS='{args.Row.GetTable().GetDefinition().GetModelName()}'" }; // multiple feautres
            using (var rc = dnoTable.Search(qf))
            {
                while (rc.MoveNext())
                {
                    using (var deleteRow = rc.Current)
                    {
                        string oid = deleteRow["OBJECTID"].ToString();
                        deleteOperation.Delete(deleteRow);
                    }
                }
            }
        }

Wolf

This code worked for me. To test I have a feature class (County) and a table with related records (CountyTable).

After i subscribe to the featureclass's row delete event, the related record is deleted after the feature is deleted. This screen shot is after i deleted the 'Larimer' county:

I used the following code to accomplish this. I think the issue is that you have to attach your delete (of the related row) to the 'parent edit operation'.

internal class ActivateRelatedDeletes : Button
{
  private SubscriptionToken _rowDeletedToken;
  private StandaloneTable _countyTable = null;

  protected override void OnClick()
  {
    if (MapView.Active == null)
    {
      MessageBox.Show("No active map");
      return;
    }
    QueuedTask.Run(() =>
    {
      _countyTable = MapView.Active.Map.GetStandaloneTablesAsFlattenedList().OfType<StandaloneTable>().Where(fl => fl.Name.Contains("CountyTable")).FirstOrDefault();
      if (_countyTable == null)
      {
        MessageBox.Show("Cannot find County Table");
        return;
      }
      var featureLayer = MapView.Active.Map.GetLayersAsFlattenedList().OfType<FeatureLayer>().Where(fl => fl.Name.Contains("County")).FirstOrDefault();
      if (featureLayer == null)
      {
        MessageBox.Show("No County feature layer found");
        return;
      }
      var addLinkedOperation = new EditOperation
      {
        Name = "Add linked rows"
      };
      _rowDeletedToken = RowDeletedEvent.Subscribe(OnRowEvent, featureLayer.GetTable());

    });
  }

  private void OnRowEvent(RowChangedEventArgs delEventArgs)
  {
    // get the parent Edit operation
    var deleteEditOp = delEventArgs.Operation;

    // delete all related records using the FIPS relationship
    System.Diagnostics.Trace.WriteLine($@"Deleted related: {delEventArgs.Row["NAME"]}");
    var atts = new Dictionary<string, object>();
    QueryFilter qf = new QueryFilter { WhereClause = $"FIPS = '{delEventArgs.Row["FIPS"]}'" };
    using (var tableCursor = _countyTable.Search(qf))
    {
      while (tableCursor.MoveNext())
      {
        using (var tableRow = tableCursor.Current)
        {
          deleteEditOp.Delete(tableRow);
        }
      }
    }
  }
}

succip

It's an oracle gdb, and yes I have the table in my Table of Contents to verify the feature is removed/not removed.

Sorry I should also mention that this is following a RowDeletedEvent. So I delete another feature in the enterprise GDB, and then as part of this process it should delete the corresponding table links in the XREF table.

Wolf

What kind of Enterprise GDB are you using and is the table (or feature class) in the content of your map?

succip

Thanks again Wolf, I may have a clue in the ErrorMessage property, but it only tells me, "Not successful: Edit operation failed." and nothing else.

Wolf

I tried your code snippet with a SQL Server Enterprise GDB and it works as expected. Here are my modifications:

protected override void OnClick()
{
  if (MapView.Active == null)
  {
    MessageBox.Show("No active map");
    return;
  }
  QueuedTask.Run(() =>
  {
    var featureLayer = MapView.Active.Map.GetLayersAsFlattenedList().OfType<FeatureLayer>().FirstOrDefault();
    if (featureLayer == null)
    {
      MessageBox.Show("No Counties feature layer found");
      return;
    }
    Table dnoXrefTable = featureLayer.GetTable();
    QueryFilter qf = new QueryFilter { WhereClause = $"STATE_NAME like ('New%')" };
    var deleteOperation = new EditOperation
    {
      Name = "Delete features"
    };
    using (var rowCursor = dnoXrefTable.Search(qf, false))
    {
      while (rowCursor.MoveNext())
      {
        using (var row = rowCursor.Current)
        {
          deleteOperation.Delete(row);
        }
      }
    }
    var delResult = deleteOperation.Execute();
    if (delResult != true)
      MessageBox.Show($@"Not successful: {deleteOperation.ErrorMessage}");
    MessageBox.Show("Edit operation complete");
  });
}

I am using a copy of the Counties dataset (from the c:\data\admin folder using Community Samples data). I coded my queryfilter to delete all counties where the state name contains 'New...'.

Here are my screen shots:

1. Before i click my delete button:

2. the delete function has completed:

3. After the OnClick exits (New York and New Hampshire are gone):

If i run the same delete function again i get this message:

So you get no message at all?

Wolf

Well it was worth a try. I will use an Enterprise table to try this. I didn't see anything wrong with your code.

succip

Thanks Wolf. Unfortunately I get an error saying it cannot be edited outside of an edit session (I assume because it's an enterprise table).

Wolf

Instead of using EditOperation you can also use this:

dnoXrefTable.DeleteRows(qf);

Připojte se k diskusi

Přihlášení členové mohou přispívat, sledovat aktualizace a další. Jste tu noví? Zaregistrujte si bezplatný účet.

Rychlé odkazy

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.