nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

How do you loop through a list of files, getting the filenames, and then adding the names to a standalone table?

RPGIS

Hi,

i am relatively new to python but I am trying to work on a script that works in conjunction with modelbuilder and so far things were working up to a point. The issue that I am having is I am trying to loop through a list of files, get the filenames, and update a table with the names from the files. Here is the script that I have currently:

<SPAN class="keyword token">import</SPAN> arcpy
<SPAN class="keyword token">import</SPAN> os

<SPAN class="comment token">#Set Parameters</SPAN>
inFiles <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>GetParameterAsText<SPAN class="punctuation token">(</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">)</SPAN>
inTable <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>GetParameterAsText<SPAN class="punctuation token">(</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">)</SPAN>
inField <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>GetParameterAsText<SPAN class="punctuation token">(</SPAN><SPAN class="number token">2</SPAN><SPAN class="punctuation token">)</SPAN>
outTable <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>SetParameterAsText<SPAN class="punctuation token">(</SPAN><SPAN class="number token">3</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="comment token">#Iterate through files in folder, insert rows based on file names, and make table view layer</SPAN>
<SPAN class="keyword token">with</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>InsertCursor<SPAN class="punctuation token">(</SPAN>inTable<SPAN class="punctuation token">,</SPAN> inField<SPAN class="punctuation token">)</SPAN> <SPAN class="keyword token">as</SPAN> cursor<SPAN class="punctuation token">:</SPAN>
    <SPAN class="comment token">#List Files</SPAN>
    flist <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>List<SPAN class="punctuation token">(</SPAN>inFiles<SPAN class="punctuation token">)</SPAN>

    <SPAN class="keyword token">for</SPAN> f <SPAN class="keyword token">in</SPAN> flist<SPAN class="punctuation token">:</SPAN>
        
        <SPAN class="comment token">#Make table view</SPAN>
        arcpy<SPAN class="punctuation token">.</SPAN>MakeTableView_management<SPAN class="punctuation token">(</SPAN>inTable<SPAN class="punctuation token">)</SPAN>
        
        <SPAN class="comment token">#Get filename(s)</SPAN>
        f <SPAN class="operator token">=</SPAN> os<SPAN class="punctuation token">.</SPAN>path<SPAN class="punctuation token">.</SPAN>basename<SPAN class="punctuation token">(</SPAN>flist<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">.</SPAN>rstrip<SPAN class="punctuation token">(</SPAN>os<SPAN class="punctuation token">.</SPAN>path<SPAN class="punctuation token">.</SPAN>splitext<SPAN class="punctuation token">(</SPAN>flist<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
        
        <SPAN class="comment token">#Insert values and rows in table</SPAN>
        cursor<SPAN class="punctuation token">.</SPAN>insertRow<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">[</SPAN>f<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="keyword token">del</SPAN> cursor

<SPAN class="comment token">#Add Message</SPAN>
arcpy<SPAN class="punctuation token">.</SPAN>AddMessage<SPAN class="punctuation token">(</SPAN><SPAN class="string token">"This row {0} was added."</SPAN><SPAN class="punctuation token">.</SPAN>format<SPAN class="punctuation token">(</SPAN>f<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

Any help on this would be greatly appreciated.

Find more posts tagged with

Accepted answers

All comments

RPGIS

Thanks Henry,

I was actually able to get the result that I was looking for through my coworker. He went in a different direction but the end result turned out to be what I was looking for(with some minor changes). I didn't consider using the f.split as an option and I think that might have made things a bit simpler for me. I am learning that with python that there simply isn't just one way to go about things, depending on direction and desired outcome. Thank you very much for that example. I will keep practicing using the examples provided as well as testing other options just to see what directions are possible.

HenryLindemann

also have a look at InsertCursor—Help | ArcGIS for Desktop

HenryLindemann

import arcpy
import os

# Set Parameters
inFiles = arcpy.GetParameterAsText(0)
inTable = arcpy.GetParameterAsText(1)
inField = arcpy.GetParameterAsText(2) # inField must be in list format ['myField'] 
outTable = arcpy.SetParameterAsText(3)

# Iterate through files in folder, insert rows based on file names, and make table view layer
with arcpy.da.InsertCursor(inTable, inField) as cursor:
    # inField must be a list of fields
    
    # List Files
    # a list can be represented as []
    flist = [inFiles]

    for f in flist:
        
        # Get filename(s)
        # if a file name  use split then split on the spaces
        file_name = f.split('/')[-1] # get the last name in the file path 
        arcpy.AddMessage("file to add {0}".format(file_name))

        # Insert values and rows in table
        cursor.insertRow([file_name])

del cursor

# Add Message
arcpy.AddMessage("This row {0} was added.".format(f))

HenryLindemann

Hi So in pure python you just want this

import arcpy

cursor = arcpy.da.InsertCursor('E:/temp/test.gdb/test', ['inField'])

list_of_files = ['file', 'file1', 'file2']

for file in list_of_files:
    cursor.insertRow(['file Path'])

del cursor

Hope it helps

PavanYadav

Robert, they are two different but similar functions. See the Discussion section at this help page: Walk—Data Access module | ArcGIS Desktop
in most cases, os.walk works. So, please don't worry about changing it.

RPGIS

Thanks Pavan. I didn't write that portion of the script, somebody else did and so I used it to test the script and it worked. I know that with the cursors you have to use .da. I didn't know that os.walk also needed the .da as well. I will be sure to remember that.

PavanYadav

Hi Robert , I notice you are using os.walk not arcpy.da.Walk. That's okay if it serves your purpose but os.walk is file based and does not recognize database contents such as geodatabase feature classes, tables, or rasters. I thought I should point it out because in the future you might find it useful.

GailMorrison

This might be easier to do in Excel: I can't give you all the steps as they have govt. pathnames within the screen scratches. When you click on From Folder, a gui opens to allow you to Browse to a folder path, then click OK. Once a directory list is created, you can move the columns around. Using the Extension down'arrow, you can sort for just *gdb, *shp, etc. Last, Close & Load To ... (an excel worksheet). It's very fast & easy to use.

www.youtube.com/watch?v=GO-Q8j2lW2s

Get a List of File Names from Folders & Sub-folders in Excel (using Power Query) - YouTube

Last step:

RPGIS

Thanks Pavan,

I checked with one of my coworkers on this and he walked me through a process that you mentioned. Here is the script that he gave me as well as my own additions(mostly his).

<SPAN class="keyword token">import</SPAN> os

path <SPAN class="operator token">=</SPAN> r<SPAN class="string token">"C:\Folder\FolderName"</SPAN>

files <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="punctuation token">]</SPAN>

<SPAN class="keyword token">for</SPAN> r<SPAN class="punctuation token">,</SPAN> d<SPAN class="punctuation token">,</SPAN> f <SPAN class="keyword token">in</SPAN> os<SPAN class="punctuation token">.</SPAN>walk<SPAN class="punctuation token">(</SPAN>path<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">:</SPAN>
    <SPAN class="keyword token">for</SPAN> file <SPAN class="keyword token">in</SPAN> f<SPAN class="punctuation token">:</SPAN>
        <SPAN class="keyword token">if</SPAN> <SPAN class="string token">'.mdb'</SPAN> <SPAN class="keyword token">in</SPAN> file<SPAN class="punctuation token">:</SPAN>
            files<SPAN class="punctuation token">.</SPAN>append<SPAN class="punctuation token">(</SPAN>file<SPAN class="punctuation token">)</SPAN>

<SPAN class="keyword token">for</SPAN> f <SPAN class="keyword token">in</SPAN> files<SPAN class="punctuation token">:</SPAN>
    <SPAN class="comment token">##print(f)</SPAN>
    strip <SPAN class="operator token">=</SPAN> os<SPAN class="punctuation token">.</SPAN>path<SPAN class="punctuation token">.</SPAN>basename<SPAN class="punctuation token">(</SPAN>file<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">.</SPAN>rstrip<SPAN class="punctuation token">(</SPAN>os<SPAN class="punctuation token">.</SPAN>path<SPAN class="punctuation token">.</SPAN>splitext<SPAN class="punctuation token">(</SPAN>file<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">[</SPAN><SPAN class="number token">1</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
    <SPAN class="keyword token">print</SPAN> strip‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

This solution was what I was actually trying to get to but, with my knowledge of python being so limited, I don't have a firm grasp on it. I meet with a friend every now and then to study python, but there is more to python than I can feasibly grasp.

-Robert

PavanYadav

Not sure if arcpy.da.Walk will fix your issue but you might want to use if you're interested in listing datasets in subdirectories as well.

RPGIS

Ok. Because for some reason I am able to parse the path using modelbuilder and it returns the correct record. The only issue I have with using the script in modelbuilder is that I receive an error message stating the table either does't exists or it simply doesn't open. I have a slightly more dumbed down version of the model that works but I my end goal is to use the script in process with the model which would make this process more seamless. Otherwise the model and script combination that is working currently, works as two separate model tools. So I am simply trying to figure out the best approach to make two processes work as one.

LaurenceLanglois1

This might be an obvious trick, it is a manual step though.

In Windows Explorer.

Select all files in you directory.

Hold Shift and 'Right Click'

'Copy as Path'

Paste into excel or notepad.

Save record

Point to your new file...

JamesCrandall

That's what it should be doing as it's simply using whatever you add to the "inFiles" list. In my example it would only add the 3 items. If you had populated the list with 20 file references then it would have added 20 rows to the table. Not sure if that answers your question.

RPGIS

Hey James,

So I tested your script and it works but it populates the table with 20+ records, and so I am wondering if there is a way for me to have the table records update based on the number of files added. So if I add 3 files, then the tool adds 3 records to the table with the file names. I am really close to getting where I want to be and so I am working on this little tiny detail.

Thanks,

Robert

RPGIS

Thanks James,

I was trying to make sense of the parse path script and loop. I am vaguely familiar with loops but the parse path script form the esri documentation wasn't making much sense to me. The reason I was trying to utilize the Make Table View script is because when I ran the script in process within a model, I would receive an error stating the item cannot be opened or it does not exist. I think this link that I was utilizing might have been adding my confusion but I could be wrong.

Parse Path—Help | ArcGIS for Desktop

I am trying to get a better understanding on how python works in terms of context and flow. I have several scripts that I have created that work the way I intended, but when I start to get into developing more complicated script, I start to get a bit confused.

Huge thanks for your help James

-Robert.

JamesCrandall

Looks like you just need to update the list of files to remove the path, leaving a file name then just append to a new list to use in the InsertCursor. Also, MakeTableView_management is expecting another parameter (you only provided a single "inTable" and it needs the output name of the table view you want to create.

inFiles <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'H:\\file1.txt'</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">'H:\\file2.txt'</SPAN><SPAN class="punctuation token">,</SPAN><SPAN class="string token">'H:\\file3.txt'</SPAN><SPAN class="punctuation token">]</SPAN>
inTable <SPAN class="operator token">=</SPAN> r<SPAN class="string token">'\\computer1\home$\user\Docs\ArcGIS\Default.gdb\tabSourceIn'</SPAN>
inField <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'filenames'</SPAN><SPAN class="punctuation token">]</SPAN>

rowvalues <SPAN class="operator token">=</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="punctuation token">]</SPAN>

<SPAN class="keyword token">for</SPAN> file <SPAN class="keyword token">in</SPAN> inFiles<SPAN class="punctuation token">:</SPAN>
    rowvalues<SPAN class="punctuation token">.</SPAN>append<SPAN class="punctuation token">(</SPAN>os<SPAN class="punctuation token">.</SPAN>path<SPAN class="punctuation token">.</SPAN>splitext<SPAN class="punctuation token">(</SPAN>os<SPAN class="punctuation token">.</SPAN>path<SPAN class="punctuation token">.</SPAN>basename<SPAN class="punctuation token">(</SPAN>file<SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="punctuation token">[</SPAN><SPAN class="number token">0</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>

cursor <SPAN class="operator token">=</SPAN> arcpy<SPAN class="punctuation token">.</SPAN>da<SPAN class="punctuation token">.</SPAN>InsertCursor<SPAN class="punctuation token">(</SPAN>inTable<SPAN class="punctuation token">,</SPAN> <SPAN class="punctuation token">[</SPAN><SPAN class="string token">'filenames'</SPAN><SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>
<SPAN class="keyword token">for</SPAN> row <SPAN class="keyword token">in</SPAN> rowvalues<SPAN class="punctuation token">:</SPAN>
    cursor<SPAN class="punctuation token">.</SPAN>insertRow<SPAN class="punctuation token">(</SPAN><SPAN class="punctuation token">[</SPAN>row<SPAN class="punctuation token">]</SPAN><SPAN class="punctuation token">)</SPAN>

<SPAN class="keyword token">del</SPAN> cursor

arcpy<SPAN class="punctuation token">.</SPAN>MakeTableView_management<SPAN class="punctuation token">(</SPAN>inTable<SPAN class="punctuation token">,</SPAN> <SPAN class="string token">'outputTableView'</SPAN><SPAN class="punctuation token">)</SPAN><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN>

JoshuaBixby

A few questions:

What does arcpy.GetParameterAsText(0) look like?
1. A comma- or semicolon-delimited string?
2. Is the list using full paths?
You have an outTable parameter but aren't using it anywhere? Why are you including it?
As Johannes Bierer‌ mentioned already, what is arcpy.List?

JohannesBierer

What if you put in a

(f)
after line 20, does it throws something out?

I think your code needs to be "rebuilt", it's easier to do this with hard coded "parameters" rather thanarcpy<SPAN class="">.</SPAN>GetParameterAsText<SPAN class="">(</SPAN><SPAN class="">0</SPAN><SPAN class="">)</SPAN>arcpy<SPAN class="">.</SPAN>AddMessage<SPAN class=""></SPAN>

RPGIS

Thanks Johannes. I did manage to get the script working, however, I get an empty output when I run the tool and so I am not sure what I am doing wrong exactly.

JohannesBierer

Does arcpy.List () exists? I would start with this:

Erstellen von Datenlisten—ArcPy Get Started | ArcGIS Desktop

RPGIS

I never used the code formatting before so it's new to me.

JohannesBierer

Could you use code formatting?

/blogs/dan_patterson/2016/08/14/script-formatting

Join the Conversation

Signed in members can post, follow updates, and more. New here? Register a free account.

Quick Links

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.