nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

export map layout with loop definition query

MahmoudHegazy

i would like to complete my script to zoom to layer per definition and export pdf but the script give me bugs when it export pdf and not zooming can any help me

import arcpy, os

arcpy.env.overwriteOutput = True
mxd = arcpy.mapping.MapDocument("CURRENT")
df = arcpy.mapping.ListDataFrames(mxd)[0]

layerName = arcpy.GetParameterAsText(0)
fieldName = arcpy.GetParameterAsText(1)
imgLocation = arcpy.GetParameterAsText(2)
whereList = []

layerFile = arcpy.mapping.Layer(layerName)
layerFile.definitionQuery = ""

print df.name

with arcpy.da.SearchCursor(layerName, fieldName) as cursor:
for row in cursor:
for item in row:
whereList.append(item)

for wl in whereList:
layerFile.definitionQuery = fieldName + "= '" + wl + "'"
df = layerFile.getExtent()
df.extent = outFile
outFile = imgLocation + "\\" + wl + ".pdf"

arcpy.mapping.ExportToPDF(mxd, outFile)

del mxd

Find more posts tagged with

Accepted answers

DavidPike

.strip() would only remove trailing and leading stuff. Probably best to do something like this:

name = ''
for char in wl:
  if char.isalpha():
    name+=char
outFile = imgLocation + '\\' + name + '.pdf'

DavidPike

ah I think I made a silly error, I'm unable to test this.

side note - why are you using mxd.save() and why have you got outFile variable created then overwritten 2 lines later?

import arcpy, os

arcpy.env.overwriteOutput = True
mxd = arcpy.mapping.MapDocument("CURRENT")

df = arcpy.mapping.ListDataFrames(mxd)[0]

layerName = arcpy.GetParameterAsText(0)
fieldName = arcpy.GetParameterAsText(1)
imgLocation = arcpy.GetParameterAsText(2)
whereList = []

layerFile = arcpy.mapping.Layer(layerName)
layerFile.definitionQuery = ""

print df.name


with arcpy.da.SearchCursor(layerName, fieldName) as cursor:
    for row in cursor:
        for item in row:
            whereList.append(item)

for wl in whereList:

    arcpy.RefreshActiveView()
    mxd.save()   
    layerFile.definitionQuery = fieldName + "= '" + wl + "'"
    new_extent = layerFile.getExtent()
    df.extent = new_extent
    df.scale *= 1.5
    
    for elm in arcpy.mapping.ListLayoutElements(mxd, "TEXT_ELEMENT", "title"):      
    
        if elm.name == "title":
           elm.text = wl

    arcpy.RefreshActiveView()
    outFile = os.path.join(imgLocation, wl + ".pdf")
    arcpy.AddMessage(outFile)
    outFile = imgLocation + "\\" + wl + ".pdf"   
    arcpy.mapping.ExportToPDF(mxd, outFile, "PAGE_LAYOUT")
del mxd

DavidPike

Can you share your final code?

You're saying that the second image is the pdf produced?

Are you sure you're specifying the same MXD which contains the layout?

The layout should be used as default in arcpy.mapping.ExportToPDF(mxd, outFile), but maybe try this just in case:

arcpy.mapping.ExportToPDF(mxd, outFile, "PAGE_LAYOUT")

and what if you try JPEG or PNG etc. ?

outFile = os.path.join(imgLocation, wl + ".jpg")
arcpy.mapping.ExportToJPEG(mxd, outFile)

DavidPike

probably adjust the scale factor e.g.

df.scale *= 1.15

DavidPike

what path are you supplying for imgLocation?

I prefer to use the os.path.join() method when constructing paths:

outFile = os.path.join(imgLocation, wl + ".pdf")
arcpy.AddMessage(outFile)

MahmoudHegazy

the extent run very well but still getting error to export pdf

File "c:\program files (x86)\arcgis\desktop10.4\arcpy\arcpy\mapping.py", line 1156, in ExportToPDF
layout.exportToPDF(*args)
AttributeError: Invalid destination path

Failed to execute (Script)

DavidPike

This bit makes no sense

#variables are all messed up
for wl in whereList:
  layerFile.definitionQuery = fieldName + "= '" + wl + "'"
  df = layerFile.getExtent()
  df.extent = outFile
  outFile = imgLocation + "\\" + wl + ".pdf"

#should be
for wl in whereList:
  layerFile.definitionQuery = fieldName + "= '" + wl + "'"
  new_extent = layerFile.getExtent()
  df.extent = new_extent
  arcpy.RefreshActiveView()
  outFile = imgLocation + "\\" + wl + ".pdf"

All comments

MahmoudHegazy

error in arcgis pro

invalid syntax line 31

import arcpy, os

arcpy.env.overwriteOutput = True
aprx = arcpy.mp.ArcGISProject("CURRENT")
df = aprx.listMaps()[0]

layerName = arcpy.GetParameterAsText(0)
fieldName = arcpy.GetParameterAsText(1)
imgLocation = arcpy.GetParameterAsText(2)
whereList = []

layerFile = df.listLayers(layerName)[0]
layerFile.definitionQuery = ""

print ((df.name))


with arcpy.da.SearchCursor(layerName, fieldName) as cursor:
    for row in cursor:
        for item in row:
            whereList.append(item)

for wl in whereList:      
    layerFile.definitionQuery = fieldName + "= '" + wl + "'"
    #new_extent = layerFile.getExtent()
    lay = aprx.listLayouts("Layout")
    mf = lay.listElements("Layers Map Frame","New Data Frame Map Frame")
    new_extent = mf.camera.setExtent(mf.getLayerExtent(layerFile, False, True)
    #df.extent = new_extent
    #df.scale *= 1.5
    for lyt in aprx.listLayouts("Layout"):
        for elm in lyt.listElements("TEXT_ELEMENT"):
            if elm.name == "Text":
                elm.text = wl

MahmoudHegazy

how can i set camera object extent instead of get extent

import arcpy, os

arcpy.env.overwriteOutput = True
aprx = arcpy.mp.ArcGISProject("CURRENT")
df = aprx.listMaps()[0]

layerName = arcpy.GetParameterAsText(0)
fieldName = arcpy.GetParameterAsText(1)
imgLocation = arcpy.GetParameterAsText(2)
whereList = []

layerFile = df.listLayers(layerName)[0]
layerFile.definitionQuery = ""

print ((df.name))


with arcpy.da.SearchCursor(layerName, fieldName) as cursor:
    for row in cursor:
        for item in row:
            whereList.append(item)

for wl in whereList:

    
       
    layerFile.definitionQuery = fieldName + "= '" + wl + "'"
    #new_extent = layerFile.getExtent()
    new_extent = df.camera.setExtent(df.getLayerExtent(layerFile, False, True))
    df.extent = new_extent
    df.scale *= 1.5
    
    for elm in arcpy.mp.ListLayoutElements(mxd, "TEXT_ELEMENT", "title"):      
    
        if elm.name == "title":
           elm.text = wl

    
    name = ''
    for char in wl:
        if char.isalpha():
            name+=char

    outFile = imgLocation + "\\" + name  + ".pdf"   
    arcpy.mp.ExportToPDF(mxd, outFile, "PAGE_LAYOUT")
del aprx

MahmoudHegazy

it worked, thanks so much

i made a post as you said to make anyone help me to convert the script to arcgis pro becouse of dynamic table

in the linke blow:

https://community.esri.com/t5/python-questions/convert-script-python-work-with-quot-export-layout/m-p/1099539#M62477

DavidPike

.strip() would only remove trailing and leading stuff. Probably best to do something like this:

name = ''
for char in wl:
  if char.isalpha():
    name+=char
outFile = imgLocation + '\\' + name + '.pdf'

MahmoudHegazy

the code worked

MahmoudHegazy

firstly i would like to thank a lot for your effort

i made in mxd save and overwrite beacouse the code write from the field have char like )(.\ and the code run out while was running so

saving mxd to know the last extent while the cod was run

what iam thinking now to put the function .strip() int outfile name to clear char like this ()\|?

DavidPike

ah I think I made a silly error, I'm unable to test this.

side note - why are you using mxd.save() and why have you got outFile variable created then overwritten 2 lines later?

import arcpy, os

arcpy.env.overwriteOutput = True
mxd = arcpy.mapping.MapDocument("CURRENT")

df = arcpy.mapping.ListDataFrames(mxd)[0]

layerName = arcpy.GetParameterAsText(0)
fieldName = arcpy.GetParameterAsText(1)
imgLocation = arcpy.GetParameterAsText(2)
whereList = []

layerFile = arcpy.mapping.Layer(layerName)
layerFile.definitionQuery = ""

print df.name


with arcpy.da.SearchCursor(layerName, fieldName) as cursor:
    for row in cursor:
        for item in row:
            whereList.append(item)

for wl in whereList:

    arcpy.RefreshActiveView()
    mxd.save()   
    layerFile.definitionQuery = fieldName + "= '" + wl + "'"
    new_extent = layerFile.getExtent()
    df.extent = new_extent
    df.scale *= 1.5
    
    for elm in arcpy.mapping.ListLayoutElements(mxd, "TEXT_ELEMENT", "title"):      
    
        if elm.name == "title":
           elm.text = wl

    arcpy.RefreshActiveView()
    outFile = os.path.join(imgLocation, wl + ".pdf")
    arcpy.AddMessage(outFile)
    outFile = imgLocation + "\\" + wl + ".pdf"   
    arcpy.mapping.ExportToPDF(mxd, outFile, "PAGE_LAYOUT")
del mxd

MahmoudHegazy

i made test and change the lebel to "title" as you see in the screen shot but the pdf exportefd without chang

e the dynamic lebel can you retest the code and see it again

my final look code is this

import arcpy, os

arcpy.env.overwriteOutput = True
mxd = arcpy.mapping.MapDocument("CURRENT")

df = arcpy.mapping.ListDataFrames(mxd)[0]

layerName = arcpy.GetParameterAsText(0)
fieldName = arcpy.GetParameterAsText(1)
imgLocation = arcpy.GetParameterAsText(2)
whereList = []

layerFile = arcpy.mapping.Layer(layerName)
layerFile.definitionQuery = ""

print df.name


with arcpy.da.SearchCursor(layerName, fieldName) as cursor:
    for row in cursor:
        for item in row:
            whereList.append(item)

for wl in whereList:

    arcpy.RefreshActiveView()
    mxd.save()   
    layerFile.definitionQuery = fieldName + "= '" + wl + "'"
    new_extent = layerFile.getExtent()
    df.extent = new_extent
    df.scale *= 1.5
    
    for elm in arcpy.mapping.ListLayoutElements(mxd, "TEXT_ELEMENT"):      
    
        if elm.text == "title":
           elm.text = wl

    arcpy.RefreshActiveView()
    outFile = os.path.join(imgLocation, wl + ".pdf")
    arcpy.AddMessage(outFile)
    outFile = imgLocation + "\\" + wl + ".pdf"   
    arcpy.mapping.ExportToPDF(mxd, outFile, "PAGE_LAYOUT")
del mxd

DavidPike

Having the for loop for the text element as the initial loop is a bit off imho. also note your element would have to be named 'title' (in the text element properties on your layout there is a name box where you can specify this)

    
for wl in whereList:

    arcpy.RefreshActiveView()
    mxd.save()   
    layerFile.definitionQuery = fieldName + "= '" + wl + "'"
    new_extent = layerFile.getExtent()
    df.extent = new_extent
    df.scale *= 1.5
    
    for elm in arcpy.mapping.ListLayoutElements(mxd, "TEXT_ELEMENT"):      
    
        if elm.text == "title":
           elm.text = wl

    arcpy.RefreshActiveView()
    outFile = os.path.join(imgLocation, wl + ".pdf")
    arcpy.AddMessage(outFile)
    outFile = imgLocation + "\\" + wl + ".pdf"   
    arcpy.mapping.ExportToPDF(mxd, outFile, "PAGE_LAYOUT")

MahmoudHegazy

import arcpy, os

arcpy.env.overwriteOutput = True
mxd = arcpy.mapping.MapDocument("CURRENT")

df = arcpy.mapping.ListDataFrames(mxd)[0]

layerName = arcpy.GetParameterAsText(0)
fieldName = arcpy.GetParameterAsText(1)
imgLocation = arcpy.GetParameterAsText(2)
whereList = []

layerFile = arcpy.mapping.Layer(layerName)
layerFile.definitionQuery = ""

print df.name


with arcpy.da.SearchCursor(layerName, fieldName) as cursor:
    for row in cursor:
        for item in row:
            whereList.append(item)
#the code blow for lebel Dynamic in the layout
mxd.activeView = "PAGE_LAYOUT"
for elm in arcpy.mapping.ListLayoutElements(mxd, "TEXT_ELEMENT"):      
    for wl in whereList:
        if elm.text == "title":
           elm.text = elm.text.replace(elm,wl)
        arcpy.RefreshActiveView()
        mxd.save()   
        layerFile.definitionQuery = fieldName + "= '" + wl + "'"
        new_extent = layerFile.getExtent()
        df.extent = new_extent
        df.scale *= 1.5
        arcpy.RefreshActiveView()
        outFile = os.path.join(imgLocation, wl + ".pdf")
        arcpy.AddMessage(outFile)
        outFile = imgLocation + "\\" + wl + ".pdf"   
        arcpy.mapping.ExportToPDF(mxd, outFile, "PAGE_LAYOUT")

del mxd

DavidPike

If you properly format your code I might be able to assist. Code formatting ... the Community Version - Esri Community

MahmoudHegazy

thanks i will do it but befor i want to add a dynamic text in arcmap each layout want the dynamic lebel change i tried to this but not organized my code

import arcpy, os

arcpy.env.overwriteOutput = True
mxd = arcpy.mapping.MapDocument("CURRENT")

df = arcpy.mapping.ListDataFrames(mxd)[0]

layerName = arcpy.GetParameterAsText(0)
fieldName = arcpy.GetParameterAsText(1)
imgLocation = arcpy.GetParameterAsText(2)
whereList = []

layerFile = arcpy.mapping.Layer(layerName)
layerFile.definitionQuery = ""

print df.name

with arcpy.da.SearchCursor(layerName, fieldName) as cursor:
for row in cursor:
for item in row:
whereList.append(item)
mxd.activeView = "PAGE_LAYOUT"
for elm in arcpy.mapping.ListLayoutElements(mxd, "TEXT_ELEMENT"):
for wl in whereList:
if elm.text == "title":
elm.text = elm.text.replace(elm,wl)
arcpy.RefreshActiveView()
mxd.save()
layerFile.definitionQuery = fieldName + "= '" + wl + "'"
new_extent = layerFile.getExtent()
df.extent = new_extent
df.scale *= 1.5
arcpy.RefreshActiveView()
outFile = os.path.join(imgLocation, wl + ".pdf")
arcpy.AddMessage(outFile)
outFile = imgLocation + "\\" + wl + ".pdf"
arcpy.mapping.ExportToPDF(mxd, outFile, "PAGE_LAYOUT")

del mxd

DavidPike

Did what I say work? If so what was the issue and what solved it?

Re converting it to Pro, it will be more than a simple changing of a few things, as there's a different mapping class, camera objects etc. I'd recommend putting this thread to rest and posting an entirely new question.

MahmoudHegazy

you helped me more thanks this the final script by DavidPike
i want use the dynamic table and this not in armap this onlyy in arcgis pro so i want convert my final script to arcgis pro

import arcpy, os

arcpy.env.overwriteOutput = True
mxd = arcpy.mapping.MapDocument("CURRENT")

df = arcpy.mapping.ListDataFrames(mxd)[0]

layerName = arcpy.GetParameterAsText(0)
fieldName = arcpy.GetParameterAsText(1)
imgLocation = arcpy.GetParameterAsText(2)
whereList = []

layerFile = arcpy.mapping.Layer(layerName)
layerFile.definitionQuery = ""

print df.name

with arcpy.da.SearchCursor(layerName, fieldName) as cursor:
for row in cursor:
for item in row:
whereList.append(item)

for wl in whereList:
layerFile.definitionQuery = fieldName + "= '" + wl + "'"

new_extent = layerFile.getExtent()
df.extent = new_extent
df.scale *= 1.5
arcpy.RefreshActiveView()
outFile = os.path.join(imgLocation, wl + ".pdf")
arcpy.AddMessage(outFile)
outFile = imgLocation + "\\" + wl + ".pdf"
arcpy.mapping.ExportToPDF(mxd, outFile, "PAGE_LAYOUT")

del mxd

DavidPike

Can you share your final code?

You're saying that the second image is the pdf produced?

Are you sure you're specifying the same MXD which contains the layout?

The layout should be used as default in arcpy.mapping.ExportToPDF(mxd, outFile), but maybe try this just in case:

arcpy.mapping.ExportToPDF(mxd, outFile, "PAGE_LAYOUT")

and what if you try JPEG or PNG etc. ?

outFile = os.path.join(imgLocation, wl + ".jpg")
arcpy.mapping.ExportToJPEG(mxd, outFile)

MahmoudHegazy

how i export the pdf from the layout ?

MahmoudHegazy

this my layout and after i export the layout to pdf after i export it looked this

and the size page is A1

DavidPike

probably adjust the scale factor e.g.

df.scale *= 1.15

MahmoudHegazy

it worked thanks but when it get extent , the extent 100% i want to customize it to 115% to make the feature fully visible

DavidPike

what path are you supplying for imgLocation?

I prefer to use the os.path.join() method when constructing paths:

outFile = os.path.join(imgLocation, wl + ".pdf")
arcpy.AddMessage(outFile)

MahmoudHegazy

the extent run very well but still getting error to export pdf

File "c:\program files (x86)\arcgis\desktop10.4\arcpy\arcpy\mapping.py", line 1156, in ExportToPDF
layout.exportToPDF(*args)
AttributeError: Invalid destination path

Failed to execute (Script)

DavidPike

This bit makes no sense

#variables are all messed up
for wl in whereList:
  layerFile.definitionQuery = fieldName + "= '" + wl + "'"
  df = layerFile.getExtent()
  df.extent = outFile
  outFile = imgLocation + "\\" + wl + ".pdf"

#should be
for wl in whereList:
  layerFile.definitionQuery = fieldName + "= '" + wl + "'"
  new_extent = layerFile.getExtent()
  df.extent = new_extent
  arcpy.RefreshActiveView()
  outFile = imgLocation + "\\" + wl + ".pdf"

Join the Conversation

Signed in members can post, follow updates, and more. New here? Register a free account.

Quick Links

Community Help
Find useful guides, FAQs, and documents to help you navigate and make the most of Esri Community.